Ashish Kalra
9edf20e5a1
ACPI: APEI: Fix integer overflow in ghes_estatus_pool_init() ...
[ Upstream commit 43d2748394c3feb86c0c771466f5847e274fc043 ]
Change num_ghes from int to unsigned int, preventing an overflow
and causing subsequent vmalloc() to fail.
The overflow happens in ghes_estatus_pool_init() when calculating
len during execution of the statement below as both multiplication
operands here are signed int:
len += (num_ghes * GHES_ESOURCE_PREALLOC_MAX_SIZE);
The following call trace is observed because of this bug:
[ 9.317108] swapper/0: vmalloc error: size 18446744071562596352, exceeds total pages, mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0-1
[ 9.317131] Call Trace:
[ 9.317134] <TASK>
[ 9.317137] dump_stack_lvl+0x49/0x5f
[ 9.317145] dump_stack+0x10/0x12
[ 9.317146] warn_alloc.cold+0x7b/0xdf
[ 9.317150] ? __device_attach+0x16a/0x1b0
[ 9.317155] __vmalloc_node_range+0x702/0x740
[ 9.317160] ? device_add+0x17f/0x920
[ 9.317164] ? dev_set_name+0x53/0x70
[ 9.317166] ? platform_device_add+0xf9/0x240
[ 9.317168] __vmalloc_node+0x49/0x50
[ 9.317170] ? ghes_estatus_pool_init+0x43/0xa0
[ 9.317176] vmalloc+0x21/0x30
[ 9.317177] ghes_estatus_pool_init+0x43/0xa0
[ 9.317179] acpi_hest_init+0x129/0x19c
[ 9.317185] acpi_init+0x434/0x4a4
[ 9.317188] ? acpi_sleep_proc_init+0x2a/0x2a
[ 9.317190] do_one_initcall+0x48/0x200
[ 9.317195] kernel_init_freeable+0x221/0x284
[ 9.317200] ? rest_init+0xe0/0xe0
[ 9.317204] kernel_init+0x1a/0x130
[ 9.317205] ret_from_fork+0x22/0x30
[ 9.317208] </TASK>
Signed-off-by: Ashish Kalra <ashish.kalra@amd.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-11-10 18:14:22 +01:00
2022-04-08 14:40:31 +02:00
2022-11-10 18:14:22 +01:00
2022-02-16 12:54:22 +01:00
2021-08-04 12:46:39 +02:00
2021-10-06 15:55:46 +02:00
2021-09-30 10:11:04 +02:00
2021-11-18 14:04:26 +01:00
2022-01-27 10:54:13 +01:00
2021-11-18 14:04:00 +01:00
2021-07-20 16:05:49 +02:00
2021-06-03 09:00:33 +02:00
2020-09-25 18:25:51 +02:00
2021-03-04 11:38:22 +01:00
2020-10-16 17:58:52 +02:00
2022-10-30 09:41:16 +01:00
2020-05-09 11:29:16 +02:00
2022-08-21 15:15:30 +02:00
2020-10-16 11:11:18 -07:00
2021-07-14 16:56:12 +02:00
2020-09-25 18:25:51 +02:00
2020-12-30 11:54:06 +01:00
2020-10-16 18:11:27 +02:00
2021-07-14 16:56:12 +02:00
2022-10-26 13:25:44 +02:00
2020-05-09 11:29:17 +02:00
2022-03-28 09:57:10 +02:00
2021-07-14 16:56:12 +02:00
2022-01-27 10:54:13 +01:00
2020-11-09 19:29:41 +01:00
2020-09-25 18:25:51 +02:00
2022-08-21 15:16:20 +02:00
2021-05-11 14:47:12 +02:00
2020-09-25 18:25:51 +02:00
2021-07-14 16:56:11 +02:00
2021-07-14 16:56:12 +02:00
2021-07-14 16:56:12 +02:00
2022-08-21 15:15:30 +02:00
2020-11-09 19:08:06 +01:00
2020-11-09 19:25:20 +01:00
2021-07-14 16:56:11 +02:00
2021-07-14 16:56:11 +02:00
2022-01-27 10:53:52 +01:00
2021-07-28 14:35:39 +02:00
2021-07-14 16:56:01 +02:00
2020-09-11 16:45:00 +02:00
2020-11-09 19:08:06 +01:00
2020-11-09 19:08:06 +01:00
2022-08-25 11:38:16 +02:00
2020-10-13 14:45:36 +02:00
2020-09-25 18:25:51 +02:00
2021-07-14 16:56:12 +02:00
2020-01-07 11:46:36 +01:00
2020-09-25 18:25:51 +02:00
2020-09-25 18:25:51 +02:00
2022-08-21 15:15:32 +02:00
2020-11-09 19:08:06 +01:00
2022-08-31 17:15:23 +02:00
2020-04-04 16:28:24 +02:00
2022-08-25 11:37:58 +02:00
2020-10-16 18:04:52 +02:00
2021-08-04 12:46:39 +02:00
2020-11-09 19:08:06 +01:00
2020-11-09 19:08:06 +01:00
2020-11-09 19:08:06 +01:00
2022-01-27 10:54:00 +01:00
2022-08-21 15:15:30 +02:00
2020-04-04 19:45:18 +02:00
2020-07-09 14:09:28 +02:00
2022-05-30 09:33:23 +02:00
2021-04-07 15:00:08 +02:00
2021-02-03 23:28:37 +01:00
2020-09-25 18:25:51 +02:00
2020-10-22 18:58:26 +02:00
2022-10-30 09:41:19 +01:00
2020-11-09 19:08:06 +01:00
9edf20e5a1