iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/tipc
History
Hoang Le 60b8b4e631 tipc: fix NULL deref in tipc_link_xmit() 
[ Upstream commit b77413446408fdd256599daf00d5be72b5f3e7c6 ]

The buffer list can have zero skb as following path:
tipc_named_node_up()->tipc_node_xmit()->tipc_link_xmit(), so
we need to check the list before casting an &sk_buff.

Fault report:
 [] tipc: Bulk publication failure
 [] general protection fault, probably for non-canonical [#1] PREEMPT [...]
 [] KASAN: null-ptr-deref in range [0x00000000000000c8-0x00000000000000cf]
 [] CPU: 0 PID: 0 Comm: swapper/0 Kdump: loaded Not tainted 5.10.0-rc4+ #2
 [] Hardware name: Bochs ..., BIOS Bochs 01/01/2011
 [] RIP: 0010:tipc_link_xmit+0xc1/0x2180
 [] Code: 24 b8 00 00 00 00 4d 39 ec 4c 0f 44 e8 e8 d7 0a 10 f9 48 [...]
 [] RSP: 0018:ffffc90000006ea0 EFLAGS: 00010202
 [] RAX: dffffc0000000000 RBX: ffff8880224da000 RCX: 1ffff11003d3cc0d
 [] RDX: 0000000000000019 RSI: ffffffff886007b9 RDI: 00000000000000c8
 [] RBP: ffffc90000007018 R08: 0000000000000001 R09: fffff52000000ded
 [] R10: 0000000000000003 R11: fffff52000000dec R12: ffffc90000007148
 [] R13: 0000000000000000 R14: 0000000000000000 R15: ffffc90000007018
 [] FS:  0000000000000000(0000) GS:ffff888037400000(0000) knlGS:000[...]
 [] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 [] CR2: 00007fffd2db5000 CR3: 000000002b08f000 CR4: 00000000000006f0

Fixes: af9b028e270fd ("tipc: make media xmit call outside node spinlock context")
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
Link: https://lore.kernel.org/r/20210108071337.3598-1-hoang.h.le@dektech.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-01-23 16:04:00 +01:00
..
addr.c
tipc: initialise addr_trail_end when setting node addresses
2019-08-11 21:40:04 -07:00
addr.h
tipc: add 128-bit node identifier
2018-03-23 13:12:18 -04:00
bcast.c
tipc: fix incorrect setting window for bcast link
2020-10-16 14:09:12 -07:00
bcast.h
tipc: update a binding service via broadcast
2020-06-17 08:53:34 -07:00
bearer.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
bearer.h
tipc: introduce variable window congestion control
2019-12-10 17:31:15 -08:00
core.c
tipc: fix a deadlock when flushing scheduled work
2020-09-07 12:08:53 -07:00
core.h
tipc: fix a deadlock when flushing scheduled work
2020-09-07 12:08:53 -07:00
crypto.c
mm: remove kzfree() compatibility definition
2020-10-25 11:39:02 -07:00
crypto.h
tipc: add automatic rekeying for encryption key
2020-09-18 13:58:37 -07:00
diag.c
tipc: switch to rhashtable iterator
2018-08-29 18:04:54 -07:00
discover.c
net: tipc: kerneldoc fixes
2020-07-13 17:20:40 -07:00
discover.h
tipc: some cleanups in the file discover.c
2018-03-23 13:12:17 -04:00
eth_media.c
tipc: Use is_broadcast_ether_addr() instead of memcmp()
2020-08-03 16:21:46 -07:00
group.c
tipc: Fix memory leak in tipc_group_create_member()
2020-09-14 16:36:20 -07:00
group.h
tipc: extend sock diag for group communication
2018-06-30 21:05:42 +09:00
ib_media.c
tipc: introduce variable window congestion control
2019-12-10 17:31:15 -08:00
Kconfig
tipc: not enable tipc when ipv6 works as a module
2020-08-16 21:04:55 -07:00
link.c
tipc: fix NULL deref in tipc_link_xmit()
2021-01-23 16:04:00 +01:00
link.h
tipc: add support for broadcast rcv stats dumping
2020-05-26 15:16:52 -07:00
Makefile
tipc: remove meaningless assignment in Makefile
2020-01-08 12:38:54 -08:00
monitor.c
tipc: add NULL pointer check to prevent kernel oops
2020-03-15 00:07:00 -07:00
monitor.h
tipc: update mon's self addr when node addr generated
2019-11-12 19:45:45 -08:00
msg.c
tipc: fix memory leak caused by tipc_buf_append()
2020-10-29 09:51:52 -07:00
msg.h
tipc: add automatic session key exchange
2020-09-18 13:58:37 -07:00
name_distr.c
tipc: fix NULL pointer dereference in tipc_named_rcv
2020-10-09 18:29:06 -07:00
name_distr.h
tipc: update a binding service via broadcast
2020-06-17 08:53:34 -07:00
name_table.c
tipc: update a binding service via broadcast
2020-06-17 08:53:34 -07:00
name_table.h
tipc: update a binding service via broadcast
2020-06-17 08:53:34 -07:00
net.c
tipc: fix a deadlock when flushing scheduled work
2020-09-07 12:08:53 -07:00
net.h
tipc: fix a deadlock when flushing scheduled work
2020-09-07 12:08:53 -07:00
netlink_compat.c
genetlink: move to smaller ops wherever possible
2020-10-02 19:11:11 -07:00
netlink.c
tipc: add automatic rekeying for encryption key
2020-09-18 13:58:37 -07:00
netlink.h
net: tipc: allocate attrs locally instead of using genl_family_attrbuf in compat_dumpit()
2019-10-06 15:44:47 +02:00
node.c
net: tipc: prevent possible null deref of link
2020-12-08 15:53:41 -08:00
node.h
tipc: add automatic session key exchange
2020-09-18 13:58:37 -07:00
socket.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-09-22 16:45:34 -07:00
socket.h
tipc: call tsk_set_importance from tipc_topsrv_create_listener
2020-05-28 11:11:46 -07:00
subscr.c
tipc: fix unbalanced reference counter
2018-04-12 21:46:10 -04:00
subscr.h
tipc: fix failed service subscription deletion
2020-05-13 12:33:19 -07:00
sysctl.c
tipc: add automatic session key exchange
2020-09-18 13:58:37 -07:00
topsrv.c
tipc: fix memory leak in tipc_topsrv_start()
2020-11-11 14:39:23 -08:00
topsrv.h
tipc: rename tipc_server to tipc_topsrv
2018-02-16 15:26:34 -05:00
trace.c
tipc: remove unneeded semicolon in trace.c
2019-01-17 22:04:43 -08:00
trace.h
tipc: add support for broadcast rcv stats dumping
2020-05-26 15:16:52 -07:00
udp_media.c
net: tipc: Supply missing udp_media.h include file
2020-09-18 14:56:44 -07:00
udp_media.h
tipc: implement configuration of UDP media MTU
2018-04-20 11:04:05 -04:00