Gaosheng Cui ad27f74e90 scsi: snic: Fix possible UAF in snic_tgt_create()
[ Upstream commit e118df492320176af94deec000ae034cc92be754 ]

Smatch reports a warning as follows:

drivers/scsi/snic/snic_disc.c:307 snic_tgt_create() warn:
  '&tgt->list' not removed from list

If device_add() fails in snic_tgt_create(), tgt will be freed, but
tgt->list will not be removed from snic->disc.tgt_list, then list traversal
may cause UAF.

Remove from snic->disc.tgt_list before free().

Fixes: c8806b6c9e82 ("snic: driver for Cisco SCSI HBA")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Link: https://lore.kernel.org/r/20221117035100.2944812-1-cuigaosheng1@huawei.com
Acked-by: Narsimhulu Musini <nmusini@cisco.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-01-14 10:15:52 +01:00
..
2020-10-14 15:15:35 -07:00
2020-10-16 12:21:15 -07:00
2020-03-11 23:07:59 -04:00
2020-10-14 15:15:35 -07:00
2020-10-23 16:19:02 -07:00
2020-10-23 16:19:02 -07:00
2019-11-12 22:21:35 -05:00
2020-02-24 14:54:25 -05:00
2020-03-11 23:07:59 -04:00
2020-10-07 21:48:28 -04:00
2020-09-02 22:49:06 -04:00
2020-09-02 22:49:06 -04:00
2020-08-23 17:36:59 -05:00
2023-01-14 10:15:52 +01:00
2021-05-14 09:50:27 +02:00
2020-07-24 22:09:55 -04:00
2022-02-16 12:54:20 +01:00
2020-09-15 17:34:18 -04:00
2020-08-23 17:36:59 -05:00
2020-10-14 15:15:35 -07:00
2020-10-14 15:15:35 -07:00
2021-05-14 09:50:27 +02:00
2022-01-27 10:54:23 +01:00
2022-01-27 10:54:23 +01:00
2020-02-24 15:01:57 -05:00
2021-05-14 09:50:27 +02:00
2019-07-11 15:14:01 -07:00