Jan Beulich 00805af45a xen-blkback: fix error handling in xen_blkbk_map()
commit 871997bc9e423f05c7da7c9178e62dde5df2a7f8 upstream.

The function uses a goto-based loop, which may lead to an earlier error
getting discarded by a later iteration. Exit this ad-hoc loop when an
error was encountered.

The out-of-memory error path additionally fails to fill a structure
field looked at by xen_blkbk_unmap_prepare() before inspecting the
handle which does get properly set (to BLKBACK_INVALID_HANDLE).

Since the earlier exiting from the ad-hoc loop requires the same field
filling (invalidation) as that on the out-of-memory path, fold both
paths. While doing so, drop the pr_alert(), as extra log messages aren't
going to help the situation (the kernel will log oom conditions already
anyway).

This is XSA-365.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Julien Grall <julien@xen.org>
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-02-23 15:53:24 +01:00
..
2020-10-13 12:12:44 -07:00
2020-10-02 17:54:45 -06:00
2020-10-24 12:46:42 -07:00
2020-09-10 09:32:30 -06:00
2020-09-10 09:32:30 -06:00
2020-09-24 13:43:39 -06:00
2020-09-10 09:32:30 -06:00
2021-01-17 14:17:03 +01:00
2020-11-12 13:59:04 -07:00
2020-10-21 10:34:10 -07:00
2020-09-10 09:32:31 -06:00
2020-09-10 09:32:30 -06:00
2018-11-09 08:14:14 -07:00