iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/cifs
History
Paulo Alcantara 0c54b79d1d smb: client: fix OOB in smbCalcSize() 
[ Upstream commit b35858b3786ddbb56e1c35138ba25d6adf8d0bef ]

Validate @smb->WordCount to avoid reading off the end of @smb and thus
causing the following KASAN splat:

  BUG: KASAN: slab-out-of-bounds in smbCalcSize+0x32/0x40 [cifs]
  Read of size 2 at addr ffff88801c024ec5 by task cifsd/1328

  CPU: 1 PID: 1328 Comm: cifsd Not tainted 6.7.0-rc5 #9
  Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS
  rel-1.16.2-3-gd478f380-rebuilt.opensuse.org 04/01/2014
  Call Trace:
   <TASK>
   dump_stack_lvl+0x4a/0x80
   print_report+0xcf/0x650
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? __phys_addr+0x46/0x90
   kasan_report+0xd8/0x110
   ? smbCalcSize+0x32/0x40 [cifs]
   ? smbCalcSize+0x32/0x40 [cifs]
   kasan_check_range+0x105/0x1b0
   smbCalcSize+0x32/0x40 [cifs]
   checkSMB+0x162/0x370 [cifs]
   ? __pfx_checkSMB+0x10/0x10 [cifs]
   cifs_handle_standard+0xbc/0x2f0 [cifs]
   ? srso_alias_return_thunk+0x5/0xfbef5
   cifs_demultiplex_thread+0xed1/0x1360 [cifs]
   ? __pfx_cifs_demultiplex_thread+0x10/0x10 [cifs]
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? lockdep_hardirqs_on_prepare+0x136/0x210
   ? __pfx_lock_release+0x10/0x10
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? mark_held_locks+0x1a/0x90
   ? lockdep_hardirqs_on_prepare+0x136/0x210
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? __kthread_parkme+0xce/0xf0
   ? __pfx_cifs_demultiplex_thread+0x10/0x10 [cifs]
   kthread+0x18d/0x1d0
   ? kthread+0xdb/0x1d0
   ? __pfx_kthread+0x10/0x10
   ret_from_fork+0x34/0x60
   ? __pfx_kthread+0x10/0x10
   ret_from_fork_asm+0x1b/0x30
   </TASK>

This fixes CVE-2023-6606.

Reported-by: j51569436@gmail.com
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218218
Cc: stable@vger.kernel.org
Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-01-05 15:12:29 +01:00
..
asn1.c
cifs: remove bogus debug code
2020-10-22 12:17:52 -05:00
cache.c
smb3: extend fscache mount volume coherency check
2020-06-06 11:16:25 -05:00
cifs_debug.c
cifs: Display local UID details for SMB sessions in DebugData
2020-07-01 19:38:19 -05:00
cifs_debug.h
cifs: Standardize logging output
2020-06-01 00:10:18 -05:00
cifs_dfs_ref.c
cifs: prevent NULL deref in cifs_compose_mount_options()
2021-07-25 14:36:17 +02:00
cifs_fs_sb.h
…
cifs_ioctl.h
cifs: add SMB3 change notification support
2020-02-06 09:14:28 -06:00
cifs_spnego.c
cifs: spnego: add ';' in HOST_KEY_LEN
2023-11-28 16:54:55 +00:00
cifs_spnego.h
…
cifs_unicode.c
CIFS: Fix a potencially linear read overflow
2021-09-15 09:50:43 +02:00
cifs_unicode.h
…
cifs_uniupr.h
…
cifsacl.c
cifs: fix a memleak with modefromsid
2020-11-15 23:05:33 -06:00
cifsacl.h
cifs: delete duplicated words in header files
2020-08-02 18:00:26 -05:00
cifsencrypt.c
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
cifsfs.c
cifs: Fix non-availability of dedup breaking generic/304
2023-12-13 18:27:07 +01:00
cifsfs.h
cifs: fix DFS traversal oops without CONFIG_CIFS_DFS_UPCALL
2023-04-05 11:23:49 +02:00
cifsglob.h
cifs: fix oops during encryption
2023-01-14 10:16:25 +01:00
cifspdu.h
cifs: Adjust key sizes and key generation routines for AES256 encryption
2021-03-30 14:32:07 +02:00
cifsproto.h
cifs: fix oops during encryption
2023-01-14 10:16:25 +01:00
cifsroot.c
cifs: Standardize logging output
2020-06-01 00:10:18 -05:00
cifssmb.c
cifs: prevent infinite recursion in CIFSGetDFSRefer()
2023-04-05 11:23:49 +02:00
connect.c
cifs: fix confusing debug message
2023-01-14 10:16:34 +01:00
dfs_cache.c
cifs: check pointer before freeing
2021-01-19 18:27:19 +01:00
dfs_cache.h
cifs: handle RESP_GET_DFS_REFERRAL.PathConsumed in reconnect
2020-08-02 18:00:26 -05:00
dir.c
cifs: report error instead of invalid when revalidating a dentry fails
2021-02-10 09:29:17 +01:00
dns_resolve.c
…
dns_resolve.h
…
export.c
…
file.c
cifs: Release folio lock on fscache read hit.
2023-08-26 15:26:55 +02:00
fs_context.c
cifs: move smb version mount options into fs_context.c
2020-10-22 12:17:31 -05:00
fs_context.h
cifs: move smb version mount options into fs_context.c
2020-10-22 12:17:31 -05:00
fscache.c
smb3: extend fscache mount volume coherency check
2020-06-06 11:16:25 -05:00
fscache.h
smb3: extend fscache mount volume coherency check
2020-06-06 11:16:25 -05:00
inode.c
new helper: inode_wrong_type()
2021-09-08 08:49:01 +02:00
ioctl.c
cifs: Fix wrong return value checking when GETFLAGS
2022-11-25 17:45:48 +01:00
Kconfig
smb3: smbdirect support can be configured by default
2020-04-07 13:39:00 -05:00
link.c
cifs: Fix uninitialized memory read for smb311 posix symlink create
2023-01-18 11:44:54 +01:00
Makefile
cifs: add files to host new mount api
2020-10-22 12:16:24 -05:00
misc.c
smb: client: fix OOB in smbCalcSize()
2024-01-05 15:12:29 +01:00
netmisc.c
cifs`: handle ERRBaduid for SMB1
2020-08-02 18:00:25 -05:00
nterr.c
…
nterr.h
…
ntlmssp.h
…
readdir.c
SMB3: add support for recognizing WSL reparse tags
2020-10-22 12:17:59 -05:00
rfc1002pdu.h
…
sess.c
cifs: Fix xid leak in cifs_ses_add_channel()
2022-10-30 09:41:17 +01:00
smb1ops.c
cifs: smb1: Try failing back to SetFileInfo if SetPathInfo fails
2020-08-02 18:00:25 -05:00
smb2file.c
cifs: remove useless parameter 'is_fsctl' from SMB2_ioctl()
2022-09-15 11:32:04 +02:00
smb2glob.h
cifs: Adjust key sizes and key generation routines for AES256 encryption
2021-03-30 14:32:07 +02:00
smb2inode.c
cifs: Fix smb2_set_path_size()
2023-03-22 13:30:03 +01:00
smb2maperror.c
cifs: map STATUS_ACCOUNT_LOCKED_OUT to -EACCES
2020-10-15 23:58:14 -05:00
smb2misc.c
smb: client: fix NULL deref in asn1_ber_decoder()
2024-01-05 15:12:26 +01:00
smb2ops.c
smb: client: fix OOB in smb2_query_reparse_point()
2024-01-05 15:12:23 +01:00
smb2pdu.c
smb: client: fix OOB in SMB2_query_info_init()
2024-01-05 15:12:29 +01:00
smb2pdu.h
ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE
2024-01-05 15:12:22 +01:00
smb2proto.h
cifs: remove useless parameter 'is_fsctl' from SMB2_ioctl()
2022-09-15 11:32:04 +02:00
smb2status.h
…
smb2transport.c
cifs: fix check of rc in function generate_smb3signingkey
2023-11-28 16:54:55 +00:00
smbdirect.c
smbdirect: missing rc checks while waiting for rdma events
2023-11-08 17:30:46 +01:00
smbdirect.h
cifs: smbd: Do not schedule work to send immediate packet on every receive
2020-04-07 12:41:16 -05:00
smbencrypt.c
…
smberr.h
…
smbfsctl.h
smb3: add some missing definitions from MS-FSCC
2020-10-23 15:38:10 -05:00
trace.c
…
trace.h
smb3: add dynamic trace point to trace when credits obtained
2020-10-20 11:50:42 -05:00
transport.c
cifs: Move the in_send statistic to __smb_send_rqst()
2023-03-22 13:29:55 +01:00
winucase.c
Replace HTTP links with HTTPS ones: CIFS
2020-07-05 14:23:38 -06:00
xattr.c
smb3: fix caching of ctime on setxattr
2023-12-08 08:46:15 +01:00