iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/include/net
History
Dan Carpenter 9a865a11d6 netfilter: nf_tables: fix pointer math issue in nft_byteorder_eval() 
commit c301f0981fdd3fd1ffac6836b423c4d7a8e0eb63 upstream.

The problem is in nft_byteorder_eval() where we are iterating through a
loop and writing to dst[0], dst[1], dst[2] and so on...  On each
iteration we are writing 8 bytes.  But dst[] is an array of u32 so each
element only has space for 4 bytes.  That means that every iteration
overwrites part of the previous element.

I spotted this bug while reviewing commit caf3ef7468f7 ("netfilter:
nf_tables: prevent OOB access in nft_byteorder_eval") which is a related
issue.  I think that the reason we have not detected this bug in testing
is that most of time we only write one element.

Fixes: ce1e7989d989 ("netfilter: nft_byteorder: provide 64bit le/be conversion")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
[Ajay: Modified to apply on v5.10.y]
Signed-off-by: Ajay Kaher <ajay.kaher@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-02-23 08:42:32 +01:00
..
9p
net: 9p: drop duplicate word in comment
2020-07-15 20:34:11 -07:00
bluetooth
Bluetooth: Fix bogus check for re-auth no supported with non-ssp
2024-01-25 14:37:46 -08:00
caif
net: caif: add proper error handling
2021-06-10 13:39:24 +02:00
iucv
net/af_iucv: clean up function prototypes
2020-05-19 12:50:14 -07:00
netfilter
netfilter: nf_tables: fix pointer math issue in nft_byteorder_eval()
2024-02-23 08:42:32 +01:00
netns
xfrm: fix a data-race in xfrm_gen_index()
2023-10-25 11:54:19 +02:00
nfc
nfc: constify several pointers to u8, char and sk_buff
2023-07-27 08:43:37 +02:00
phonet
…
sctp
sctp: add a refcnt in sctp_stream_priorities to avoid a nested loop
2023-03-11 16:40:12 +01:00
tc_act
net/sched: act_pedit: really ensure the skb is writable
2022-05-18 10:23:44 +02:00
6lowpan.h
6lowpan: Replace zero-length array with flexible-array member
2020-02-28 14:51:30 +01:00
act_api.h
net: sched: fix err handler in tcf_action_init()
2021-04-14 08:42:05 +02:00
addrconf.h
net: ipv6: support reporting otherwise unknown prefix flags in RTM_NEWPREFIX
2023-12-20 15:44:27 +01:00
af_ieee802154.h
…
af_rxrpc.h
rxrpc: Make rxrpc_kernel_get_srtt() indicate validity
2020-08-20 18:21:28 +01:00
af_unix.h
af_unix: fix lockdep positive in sk_diag_dump_icons()
2024-02-23 08:42:17 +01:00
af_vsock.h
vsock: each transport cycles only on its own sockets
2022-03-23 09:13:27 +01:00
ah.h
…
arp.h
ipv4: Invalidate neighbour for broadcast address upon address addition
2022-04-13 21:00:57 +02:00
atmclip.h
…
ax25.h
ax25: fix reference count leaks of ax25_dev
2022-04-20 09:23:31 +02:00
ax88796.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
bareudp.h
bareudp: Reverted support to enable & disable rx metadata collection
2020-07-21 18:30:47 -07:00
bond_3ad.h
net: bonding: Share lacpdu_mcast_addr definition
2022-09-28 11:10:31 +02:00
bond_alb.h
bonding (gcc13): synchronize bond_{a,t}lb_xmit() types
2023-06-14 11:09:31 +02:00
bond_options.h
bonding: add an option to specify a delay between peer notifications
2019-07-04 12:30:48 -07:00
bonding.h
bonding: fix macvlan over alb bond support
2023-08-30 16:23:14 +02:00
bpf_sk_storage.h
bpf: Change bpf_sk_storage_*() to accept ARG_PTR_TO_BTF_ID_SOCK_COMMON
2020-09-25 13:58:01 -07:00
busy_poll.h
net: Fix a data-race around sysctl_net_busy_poll.
2022-08-31 17:15:20 +02:00
calipso.h
…
cfg80211-wext.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
cfg80211.h
wifi: cfg80211: fix sband iftype data lookup for AP_VLAN
2023-08-16 18:21:02 +02:00
cfg802154.h
cfg802154: Replace zero-length array with flexible-array member
2020-02-29 14:39:08 +01:00
checksum.h
net: Force inlining of checksum functions in net/checksum.h
2022-03-02 11:42:50 +01:00
cipso_ipv4.h
cipso: Remove unused inline functions
2020-07-15 07:45:24 -07:00
cls_cgroup.h
bpf: Allow to retrieve cgroup v1 classid from v2 hooks
2020-03-27 19:40:38 -07:00
codel_impl.h
…
codel_qdisc.h
…
codel.h
…
compat.h
net: simplify cBPF setsockopt compat handling
2020-07-19 18:16:40 -07:00
datalink.h
…
dcbevent.h
…
dcbnl.h
…
devlink.h
devlink: Add enable_remote_dev_reset generic parameter
2020-10-09 12:06:53 -07:00
dsa.h
net: dsa: propagate switchdev vlan_filtering prepare phase to drivers
2020-10-05 05:56:48 -07:00
dsfield.h
ipv6: Annotate bitwise IPv6 dsfield pointer cast
2019-12-16 16:09:44 -08:00
dst_cache.h
wireguard: device: reset peer src endpoint when netns exits
2021-12-08 09:03:22 +01:00
dst_metadata.h
net: fix a memleak when uncloning an skb dst and its metadata
2022-02-16 12:54:26 +01:00
dst_ops.h
ipv6: remove max_size check inline with ipv4
2024-01-15 18:48:07 +01:00
dst.h
net: Remove unused inline function dst_hold_and_use()
2023-06-21 15:45:40 +02:00
erspan.h
erspan: Add type I version 0 support.
2020-05-05 13:23:29 -07:00
esp.h
esp: limit skb_page_frag_refill use to a single page
2022-04-27 13:53:48 +02:00
espintcp.h
xfrm: espintcp: save and call old ->sk_destruct
2020-04-20 07:34:16 +02:00
ethoc.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
failover.h
…
fib_notifier.h
ipv6: Remove old route notifications and convert listeners
2019-12-24 22:37:30 -08:00
fib_rules.h
ipv6: fix memory leak in fib6_rule_suppress
2021-12-08 09:03:21 +01:00
firewire.h
…
flow_dissector.h
net/sched: flower: fix parsing of ethertype following VLAN header
2022-04-20 09:23:11 +02:00
flow_offload.h
netfilter: nf_tables: bail out early if hardware offload is not supported
2022-06-14 18:32:40 +02:00
flow.h
inet: shrink struct flowi_common
2023-11-20 11:06:55 +01:00
fou.h
…
fq_impl.h
net/fq_impl: use skb_get_hash instead of skb_get_hash_perturb
2020-07-31 09:24:24 +02:00
fq.h
net/fq_impl: use skb_get_hash instead of skb_get_hash_perturb
2020-07-31 09:24:24 +02:00
garp.h
treewide: Use sizeof_field() macro
2019-12-09 10:36:44 -08:00
gen_stats.h
net_sched: extend packet counter to 64bit
2019-11-05 18:20:55 -08:00
genetlink.h
drop_monitor: Require 'CAP_SYS_ADMIN' when joining "events" group
2023-12-13 18:27:06 +01:00
geneve.h
…
gre.h
…
gro_cells.h
…
gtp.h
…
gue.h
GUE: Fix a typo
2020-06-22 21:12:44 -07:00
hwbm.h
net: hwbm: if CONFIG_NET_HWBM unset, make stub functions static
2019-10-25 16:24:32 -07:00
icmp.h
net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending
2021-03-04 11:38:46 +01:00
ieee80211_radiotap.h
mac80211: add radiotap flag to prevent sequence number overwrite
2020-07-31 09:27:00 +02:00
ieee802154_netdev.h
net: ieee802154: return -EINVAL for unknown addr type
2022-10-26 13:25:55 +02:00
if_inet6.h
net: ipv6: support reporting otherwise unknown prefix flags in RTM_NEWPREFIX
2023-12-20 15:44:27 +01:00
ife.h
…
ila.h
…
inet6_connection_sock.h
…
inet6_hashtables.h
net: allow unbound socket for packets in VRF when tcp_l3mdev_accept set
2022-08-21 15:15:51 +02:00
inet_common.h
bpf: Allow any port in bpf_bind helper
2020-05-09 00:48:20 +02:00
inet_connection_sock.h
tcp: make sure init the accept_queue's spinlocks once
2024-02-23 08:41:55 +01:00
inet_ecn.h
inet_ecn: Fix endianness of checksum update when setting ECT(1)
2020-12-01 17:16:54 -08:00
inet_frag.h
inet: frags: annotate races around fqdir->dead and fqdir->high_thresh
2022-01-27 10:54:33 +01:00
inet_hashtables.h
net: allow unbound socket for packets in VRF when tcp_l3mdev_accept set
2022-08-21 15:15:51 +02:00
inet_sock.h
net: allow unbound socket for packets in VRF when tcp_l3mdev_accept set
2022-08-21 15:15:51 +02:00
inet_timewait_sock.h
tcp: honor SO_PRIORITY in TIME_WAIT state
2019-09-27 12:05:02 +02:00
inetpeer.h
…
ip6_checksum.h
tcp: remove indirect calls for icsk->icsk_af_ops->send_check
2020-06-20 17:47:53 -07:00
ip6_fib.h
ipv6: annotate accesses to fn->fn_sernum
2022-02-01 17:25:44 +01:00
ip6_route.h
net: ipv6: fix returned variable type in ip6_skb_dst_mtu
2021-08-12 13:22:07 +02:00
ip6_tunnel.h
ip_gre, ip6_gre: Fix race condition on o_seqno in collect_md mode
2022-05-09 09:05:04 +02:00
ip_fib.h
ipv4/fib: send notify when delete source address routes
2023-10-25 11:54:23 +02:00
ip_tunnels.h
ip_tunnels: use DEV_STATS_INC()
2023-09-19 12:20:27 +02:00
ip_vs.h
ipvs: Update width of source for ip_vs_sync_conn_options
2023-05-30 12:57:49 +01:00
ip.h
ipv4: ignore dst hint for multipath routes
2023-09-19 12:20:26 +02:00
ipcomp.h
…
ipconfig.h
…
ipv6_frag.h
inet: frags: annotate races around fqdir->dead and fqdir->high_thresh
2022-01-27 10:54:33 +01:00
ipv6_stubs.h
net: ipv6: add fib6_nh_release_dsts stub
2021-12-01 09:19:05 +01:00
ipv6.h
ipv6: fix ip6_sock_set_addr_preferences() typo
2023-09-19 12:20:30 +02:00
ipx.h
bonding/alb: properly access headers in bond_alb_xmit()
2020-02-05 14:28:09 +01:00
iw_handler.h
…
kcm.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
l3mdev.h
l3mdev: add infrastructure for table to VRF mapping
2020-06-20 17:22:22 -07:00
lag.h
…
lapb.h
…
lib80211.h
…
llc_c_ac.h
…
llc_c_ev.h
…
llc_c_st.h
…
llc_conn.h
llc: fix sk_buff leak in llc_conn_service()
2019-10-08 13:23:05 -07:00
llc_if.h
…
llc_pdu.h
llc: Drop support for ETH_P_TR_802_2.
2024-02-23 08:41:56 +01:00
llc_s_ac.h
…
llc_s_ev.h
…
llc_s_st.h
…
llc_sap.h
…
llc.h
llc: fix out-of-bound array index in llc_sk_dev_hash()
2021-11-18 14:04:27 +01:00
lwtunnel.h
lwt: Check LWTUNNEL_XMIT_CONTINUE strictly
2023-09-19 12:20:09 +02:00
mac80211.h
mac80211: Fix NULL ptr deref for injected rate info
2021-06-23 14:42:52 +02:00
mac802154.h
…
macsec.h
net: macsec: indicate next pn update when offloading
2023-10-25 11:54:14 +02:00
mip6.h
net: mip6: Replace zero-length array with flexible-array member
2020-03-02 11:16:27 -08:00
mld.h
net: ipv6: mld: Replace zero-length array with flexible-array member
2020-02-29 21:52:20 -08:00
mpls_iptunnel.h
net: mpls: Replace zero-length array with flexible-array member
2020-02-28 12:08:37 -08:00
mpls.h
net: Make mpls_entry_encode() available for generic users
2020-05-29 21:20:20 -07:00
mptcp.h
mptcp: remove MPTCP 'ifdef' in TCP SYN cookies
2023-01-14 10:16:51 +01:00
mrp.h
mrp: introduce active flags to prevent UAF when applicant uninit
2023-01-14 10:16:18 +01:00
ncsi.h
…
ndisc.h
ipv6: ndisc: adjust ndisc_ifinfo_sysctl_change prototype
2020-08-24 06:40:07 -07:00
neighbour.h
neighbour: delete neigh_lookup_nodev as not used
2023-06-21 15:45:40 +02:00
net_failover.h
…
net_namespace.h
net: make get_net_ns return error if NET_NS is disabled
2021-06-23 14:42:44 +02:00
net_ratelimit.h
…
netevent.h
…
netlabel.h
…
netlink.h
netlink: export policy in extended ACK
2020-10-09 20:22:32 -07:00
netprio_cgroup.h
netprio: use css ID instead of cgroup ID
2019-11-12 08:18:03 -08:00
netrom.h
…
nexthop.h
net: ipv4: Fix rtnexthop len when RTA_FLOW is present
2021-10-06 15:55:53 +02:00
nl802154.h
net: ieee802154: handle iftypes as u32
2021-12-01 09:19:03 +01:00
nsh.h
…
p8022.h
…
page_pool.h
mm: fix struct page layout on 32-bit systems
2021-05-19 10:13:17 +02:00
pie.h
pie: realign comment
2020-03-04 13:25:55 -08:00
ping.h
…
pkt_cls.h
net: zero-initialize tc skb extension on allocation
2021-06-03 09:00:51 +02:00
pkt_sched.h
net/sched: make psched_mtu() RTNL-less safe
2023-07-27 08:44:24 +02:00
pptp.h
…
protocol.h
tcp/udp: Make early_demux back namespacified.
2022-11-10 18:14:26 +01:00
psample.h
psample: Add a fwd declaration for skbuff
2021-08-18 08:59:11 +02:00
psnap.h
…
raw.h
raw: Fix a data-race around sysctl_raw_l3mdev_accept.
2022-07-21 21:20:10 +02:00
rawv6.h
…
red.h
sch_red: fix off-by-one checks in red_check_params()
2021-04-14 08:42:07 +02:00
regulatory.h
net/wireless: regulatory.h: drop duplicate word in comment
2020-07-31 09:24:23 +02:00
request_sock.h
tcp: bpf: Optionally store mac header in TCP_SAVE_SYN
2020-08-24 14:35:00 -07:00
rose.h
…
route.h
lsm,selinux: pass flowi_common instead of flowi to the LSM hooks
2022-06-09 10:21:09 +02:00
rpl.h
ipv6: rpl: Fix Route of Death.
2023-06-14 11:09:42 +02:00
rsi_91x.h
…
rtnetlink.h
net: validate veth and vxcan peer ifindexes
2023-08-30 16:23:13 +02:00
rtnh.h
…
sch_generic.h
net/sched: act_mirred: refactor the handle of xmit
2023-05-30 12:57:56 +01:00
scm.h
scm: fix MSG_CTRUNC setting condition for SO_PASSSEC
2023-05-17 11:47:47 +02:00
secure_seq.h
secure_seq: use the 64 bits of the siphash for port offset calculation
2022-05-30 09:33:23 +02:00
seg6_hmac.h
…
seg6_local.h
…
seg6.h
seg6: fix seg6_validate_srh() to avoid slab-out-of-bounds
2020-06-04 15:39:32 -07:00
slhc_vj.h
…
smc.h
net/smc: introduce CHID callback for ISM devices
2020-09-28 15:19:03 -07:00
snmp.h
net/tls: add skeleton of MIB statistics
2019-10-05 16:29:00 -07:00
sock_reuseport.h
udp: Update reuse->has_conns under reuseport_lock.
2022-10-30 09:41:19 +01:00
sock.h
net: annotate data-races around sk->sk_dst_pending_confirm
2023-11-28 16:54:50 +00:00
Space.h
…
stp.h
…
strparser.h
bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding
2021-11-18 14:04:27 +01:00
switchdev.h
bridge: switchdev: Notify about VLAN protocol changes
2022-12-02 17:39:57 +01:00
tcp_states.h
…
tcp.h
tcp: fix cookie_init_timestamp() overflows
2023-11-20 11:06:46 +01:00
timewait_sock.h
…
tipc.h
…
tls_toe.h
net/tls: rename tls_hw_* functions tls_toe_*
2019-10-04 14:07:07 -07:00
tls.h
net/tls: Check for errors in tls_device_init
2022-07-21 21:20:13 +02:00
transp_v6.h
tcp: move ipv4_specific to tcp include file
2020-06-23 20:10:15 -07:00
tso.h
net: tso: cache transport header length
2020-06-18 20:46:23 -07:00
tun_proto.h
…
udp_tunnel.h
udp: call udp_encap_enable for v6 sockets when enabling encap
2022-04-08 14:39:54 +02:00
udp.h
tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
2023-04-26 11:27:41 +02:00
udplite.h
tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
2023-04-26 11:27:41 +02:00
vsock_addr.h
vsock: remove include/linux/vm_sockets.h file
2019-11-14 18:12:17 -08:00
vxlan.h
vxlan: Fix nexthop hash size
2023-08-11 11:57:50 +02:00
wext.h
…
wimax.h
net: wimax: fix duplicate words in comments
2020-07-15 20:34:02 -07:00
x25.h
net/x25: add new state X25_STATE_5
2019-12-09 10:28:43 -08:00
x25device.h
…
xdp_priv.h
page_pool: do not release pool until inflight == 0.
2019-11-16 12:39:10 -08:00
xdp_sock_drv.h
xsk: i40e: ice: ixgbe: mlx5: Test for dma_need_sync earlier for better performance
2020-08-31 21:15:04 +02:00
xdp_sock.h
xsk: Fix race in SKB mode transmit with shared cq
2021-01-17 14:17:05 +01:00
xdp.h
xdp: Remove the xdp_attachment_flags_ok() callback
2020-12-09 16:27:42 +01:00
xfrm.h
xfrm: Treat already-verified secpath entries as optional
2023-06-28 10:28:10 +02:00
xsk_buff_pool.h
xsk: Fix unaligned descriptor validation
2023-05-17 11:47:50 +02:00