iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/dma
History
Sean Anderson fcdd5bb4a8 dma: xilinx_dpdma: Fix locking 
[ Upstream commit 244296cc3a155199a8b080d19e645d7d49081a38 ]

There are several places where either chan->lock or chan->vchan.lock was
not held. Add appropriate locking. This fixes lockdep warnings like

[   31.077578] ------------[ cut here ]------------
[   31.077831] WARNING: CPU: 2 PID: 40 at drivers/dma/xilinx/xilinx_dpdma.c:834 xilinx_dpdma_chan_queue_transfer+0x274/0x5e0
[   31.077953] Modules linked in:
[   31.078019] CPU: 2 PID: 40 Comm: kworker/u12:1 Not tainted 6.6.20+ #98
[   31.078102] Hardware name: xlnx,zynqmp (DT)
[   31.078169] Workqueue: events_unbound deferred_probe_work_func
[   31.078272] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[   31.078377] pc : xilinx_dpdma_chan_queue_transfer+0x274/0x5e0
[   31.078473] lr : xilinx_dpdma_chan_queue_transfer+0x270/0x5e0
[   31.078550] sp : ffffffc083bb2e10
[   31.078590] x29: ffffffc083bb2e10 x28: 0000000000000000 x27: ffffff880165a168
[   31.078754] x26: ffffff880164e920 x25: ffffff880164eab8 x24: ffffff880164d480
[   31.078920] x23: ffffff880165a148 x22: ffffff880164e988 x21: 0000000000000000
[   31.079132] x20: ffffffc082aa3000 x19: ffffff880164e880 x18: 0000000000000000
[   31.079295] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000
[   31.079453] x14: 0000000000000000 x13: ffffff8802263dc0 x12: 0000000000000001
[   31.079613] x11: 0001ffc083bb2e34 x10: 0001ff880164e98f x9 : 0001ffc082aa3def
[   31.079824] x8 : 0001ffc082aa3dec x7 : 0000000000000000 x6 : 0000000000000516
[   31.079982] x5 : ffffffc7f8d43000 x4 : ffffff88003c9c40 x3 : ffffffffffffffff
[   31.080147] x2 : ffffffc7f8d43000 x1 : 00000000000000c0 x0 : 0000000000000000
[   31.080307] Call trace:
[   31.080340]  xilinx_dpdma_chan_queue_transfer+0x274/0x5e0
[   31.080518]  xilinx_dpdma_issue_pending+0x11c/0x120
[   31.080595]  zynqmp_disp_layer_update+0x180/0x3ac
[   31.080712]  zynqmp_dpsub_plane_atomic_update+0x11c/0x21c
[   31.080825]  drm_atomic_helper_commit_planes+0x20c/0x684
[   31.080951]  drm_atomic_helper_commit_tail+0x5c/0xb0
[   31.081139]  commit_tail+0x234/0x294
[   31.081246]  drm_atomic_helper_commit+0x1f8/0x210
[   31.081363]  drm_atomic_commit+0x100/0x140
[   31.081477]  drm_client_modeset_commit_atomic+0x318/0x384
[   31.081634]  drm_client_modeset_commit_locked+0x8c/0x24c
[   31.081725]  drm_client_modeset_commit+0x34/0x5c
[   31.081812]  __drm_fb_helper_restore_fbdev_mode_unlocked+0x104/0x168
[   31.081899]  drm_fb_helper_set_par+0x50/0x70
[   31.081971]  fbcon_init+0x538/0xc48
[   31.082047]  visual_init+0x16c/0x23c
[   31.082207]  do_bind_con_driver.isra.0+0x2d0/0x634
[   31.082320]  do_take_over_console+0x24c/0x33c
[   31.082429]  do_fbcon_takeover+0xbc/0x1b0
[   31.082503]  fbcon_fb_registered+0x2d0/0x34c
[   31.082663]  register_framebuffer+0x27c/0x38c
[   31.082767]  __drm_fb_helper_initial_config_and_unlock+0x5c0/0x91c
[   31.082939]  drm_fb_helper_initial_config+0x50/0x74
[   31.083012]  drm_fbdev_dma_client_hotplug+0xb8/0x108
[   31.083115]  drm_client_register+0xa0/0xf4
[   31.083195]  drm_fbdev_dma_setup+0xb0/0x1cc
[   31.083293]  zynqmp_dpsub_drm_init+0x45c/0x4e0
[   31.083431]  zynqmp_dpsub_probe+0x444/0x5e0
[   31.083616]  platform_probe+0x8c/0x13c
[   31.083713]  really_probe+0x258/0x59c
[   31.083793]  __driver_probe_device+0xc4/0x224
[   31.083878]  driver_probe_device+0x70/0x1c0
[   31.083961]  __device_attach_driver+0x108/0x1e0
[   31.084052]  bus_for_each_drv+0x9c/0x100
[   31.084125]  __device_attach+0x100/0x298
[   31.084207]  device_initial_probe+0x14/0x20
[   31.084292]  bus_probe_device+0xd8/0xdc
[   31.084368]  deferred_probe_work_func+0x11c/0x180
[   31.084451]  process_one_work+0x3ac/0x988
[   31.084643]  worker_thread+0x398/0x694
[   31.084752]  kthread+0x1bc/0x1c0
[   31.084848]  ret_from_fork+0x10/0x20
[   31.084932] irq event stamp: 64549
[   31.084970] hardirqs last  enabled at (64548): [<ffffffc081adf35c>] _raw_spin_unlock_irqrestore+0x80/0x90
[   31.085157] hardirqs last disabled at (64549): [<ffffffc081adf010>] _raw_spin_lock_irqsave+0xc0/0xdc
[   31.085277] softirqs last  enabled at (64503): [<ffffffc08001071c>] __do_softirq+0x47c/0x500
[   31.085390] softirqs last disabled at (64498): [<ffffffc080017134>] ____do_softirq+0x10/0x1c
[   31.085501] ---[ end trace 0000000000000000 ]---

Fixes: 7cbb0c63de3f ("dmaengine: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver")
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://lore.kernel.org/r/20240308210034.3634938-2-sean.anderson@linux.dev
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-05-02 16:23:45 +02:00
..
bestcomm
dmaengine: bestcomm: fix system boot lockups
2022-09-23 14:16:56 +02:00
dw
dmaengine: dw: Make it dependent to HAS_IOMEM
2021-04-21 13:00:50 +02:00
dw-axi-dmac
Add exception protection processing for vd in axi_chan_handle_err function
2023-01-24 07:19:56 +01:00
dw-edma
dmaengine: dw-edma: Fix to enable to issue dma request on DMA processing
2023-05-17 11:48:05 +02:00
fsl-dpaa2-qdma
dmaengine: fsl-dpaa2-qdma: Fix the size of dma pools
2024-02-23 08:42:18 +01:00
hsu
dmaengine: hsu: disable spurious interrupt
2021-03-04 11:37:55 +01:00
idxd
dmaengine: idxd: add missing callback function to support DMA_INTERRUPT
2022-06-14 18:32:47 +02:00
ioat
dmaengine: ioat: stop mod_timer from resurrecting deleted timer in __cleanup()
2022-10-26 13:25:39 +02:00
ipu
dmaengine: ipu: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:06 +05:30
mediatek
dmaengine: mediatek: Fix deadlock caused by synchronize_irq()
2023-10-25 11:54:16 +02:00
ppc4xx
dmaengine: ppc4xx: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:07 +05:30
qcom
dmaengine: QCOM_HIDMA_MGMT depends on HAS_IOMEM
2021-06-23 14:42:40 +02:00
sf-pdma
dmaengine: sf-pdma: Add multithread support for a DMA channel
2022-08-21 15:15:57 +02:00
sh
dmaengine: shdma: increase size of 'dev_id'
2024-03-01 13:16:43 +01:00
ti
dmaengine: ti: edma: Add some null pointer checks to the edma_probe
2024-03-01 13:16:44 +01:00
xilinx
dma: xilinx_dpdma: Fix locking
2024-05-02 16:23:45 +02:00
acpi-dma.c
dmaengine: acpi: Avoid comparison GSI with Linux vIRQ
2021-09-26 14:08:57 +02:00
altera-msgdma.c
dmaengine: altera-msgdma: fix kernel-doc style for tasklet
2020-10-08 15:18:37 +05:30
amba-pl08x.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
at_hdmac_regs.h
dmaengine: at_hdmac: Fix at_lli struct definition
2022-11-16 09:57:17 +01:00
at_hdmac.c
dmaengine: at_hdmac: Check return code of dma_async_device_register
2022-11-16 09:57:20 +01:00
at_xdmac.c
dmaengine: at_xdmac: fix potential Oops in at_xdmac_prep_interleaved()
2023-06-09 10:30:04 +02:00
bcm2835-dma.c
dmaengine: bcm2835: Drop local dma_parms
2020-09-11 17:42:12 +05:30
bcm-sba-raid.c
dmaengine: bcm-sba-raid: Replace zero-length array with flexible-array member
2020-02-13 20:15:35 +05:30
coh901318_lli.c
…
coh901318.c
dmaengine: coh901318: convert tasklets to use new tasklet_setup() API
2020-09-18 12:18:11 +05:30
coh901318.h
…
dma-axi-dmac.c
dmaengine: axi-dmac: Drop local dma_parms
2020-09-11 17:42:12 +05:30
dma-jz4780.c
dmaengine: dma-jz4780: Fix race in jz4780_dma_tx_status
2020-10-05 09:58:48 +05:30
dmaengine.c
dmaengine: fix NULL pointer in channel unregistration function
2024-02-23 08:41:52 +01:00
dmaengine.h
dmaengine: dmaengine_desc_callback_valid(): Check for callback_result
2021-11-18 14:04:24 +01:00
dmatest.c
dmaengine: dmatest: Return boolean result directly in filter()
2020-09-22 20:18:41 +05:30
ep93xx_dma.c
dmaengine: ep93xx: convert tasklets to use new tasklet_setup() API
2020-09-18 12:18:11 +05:30
fsl_raid.c
dmaengine: fsl: remove bad channel update
2020-10-05 09:59:17 +05:30
fsl_raid.h
…
fsl-edma-common.c
dmaengine: fsl-edma: fix wrong tcd endianness for big-endian cpu
2020-07-06 14:49:22 +05:30
fsl-edma-common.h
dmaengine: fsl-edma-common: correct DSIZE_32BYTE
2020-07-06 10:24:49 +05:30
fsl-edma.c
dmaengine: fsl-edma: Fix NULL pointer exception in fsl_edma_tx_handler
2020-06-24 13:05:01 +05:30
fsl-qdma.c
dmaengine: fsl-qdma: init irq after reg initialization
2024-03-06 14:37:49 +00:00
fsldma.c
dmaengine: fsldma: Fix a resource leak in an error handling path of the probe function
2021-03-04 11:37:55 +01:00
fsldma.h
fsldma: fix very broken 32-bit ppc ioread64 functionality
2020-08-29 13:50:56 -07:00
hisi_dma.c
dmaengine: hisilicon: Add multi-thread support for a DMA channel
2022-10-26 13:25:34 +02:00
idma64.c
idma64: Don't try to serve interrupts when device is powered off
2024-05-02 16:23:45 +02:00
idma64.h
…
img-mdc-dma.c
…
imx-dma.c
dmaengine: imx-dma: configure the generic DMA type to make it work
2021-08-12 13:22:05 +02:00
imx-sdma.c
dmaengine: imx-sdma: Fix a possible memory leak in sdma_transfer_init
2023-02-06 07:56:15 +01:00
iop-adma.c
Merge branch 'topic/tasklet' into next
2020-10-01 10:18:59 +05:30
iop-adma.h
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
k3dma.c
dmaengine: k3dma: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:06 +05:30
Kconfig
dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA
2024-03-26 18:21:55 -04:00
lpc18xx-dmamux.c
…
Makefile
misc: mic: remove the MIC drivers
2020-10-28 19:12:03 +01:00
mcf-edma.c
dmaengine: mcf-edma: Fix a potential un-allocated memory access
2023-08-16 18:21:02 +02:00
milbeaut-hdmac.c
dmaengine: Replace zero-length array with flexible-array
2020-06-15 23:08:30 -05:00
milbeaut-xdmac.c
dmaengine: milbeaut-xdmac: Fix a resource leak in the error handling path of the probe function
2021-01-17 14:17:02 +01:00
mmp_pdma.c
dmaengine: pxa/mmp: stop referencing config->slave_id
2022-01-27 10:54:07 +01:00
mmp_tdma.c
dmaengine: mmp: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:06 +05:30
moxart-dma.c
dmaengine: Replace zero-length array with flexible-array
2020-06-15 23:08:30 -05:00
mpc512x_dma.c
dmaengine: mpc512x: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:06 +05:30
mv_xor_v2.c
dmaengine: mv_xor_v2: Fix an error code.
2023-05-17 11:48:04 +02:00
mv_xor.c
dmaengine: mv_xor: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:06 +05:30
mv_xor.h
…
mxs-dma.c
dmaengine: mxs: use platform_driver_register
2022-10-30 09:41:18 +01:00
nbpfaxi.c
dmaengine: nbpfaxi: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:06 +05:30
of-dma.c
dmaengine: of-dma: router_xlate to return -EPROBE_DEFER if controller is not yet available
2021-08-26 08:35:36 -04:00
owl-dma.c
dmaengine: owl: fix register access functions
2024-05-02 16:23:45 +02:00
pch_dma.c
dmaengine: pch_dma: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:06 +05:30
pl330.c
dmaengine: pl330: Return DMA_PAUSED when transaction is paused
2023-08-16 18:20:59 +02:00
plx_dma.c
dmaengine: plx_dma: add a missing put_device() on error path
2021-04-21 13:00:51 +02:00
pxa_dma.c
dmaengine: pxa_dma: Remove an erroneous BUG_ON() in pxad_free_desc()
2023-11-20 11:06:53 +01:00
s3c24xx-dma.c
dmaengine: s3c24xx-dma: fix spelling mistake "to" -> "too"
2020-01-23 17:03:25 +05:30
sa11x0-dma.c
dmaengine: sa11x0: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:07 +05:30
sirf-dma.c
dmaengine: sirf-dma: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:07 +05:30
sprd-dma.c
dmaengine: sprd: Cleanup in .remove() after pm_runtime_get_sync() failed
2022-08-25 11:38:17 +02:00
st_fdma.c
dmaengine: st_fdma: fix MODULE_ALIAS
2021-12-22 09:30:53 +01:00
st_fdma.h
…
ste_dma40_ll.c
…
ste_dma40_ll.h
…
ste_dma40.c
dmaengine: ste_dma40: Fix PM disable depth imbalance in d40_probe
2023-11-08 17:30:48 +01:00
stm32-dma.c
dmaengine: stm32-dma: Fix PM usage counter imbalance in stm32 dma ops
2021-08-12 13:22:04 +02:00
stm32-dmamux.c
dmaengine: stm32-dmamux: Fix PM disable depth imbalance in stm32_dmamux_probe
2022-02-23 12:01:07 +01:00
stm32-mdma.c
dmaengine: stm32-mdma: correct desc prep when channel running
2023-11-28 16:54:58 +00:00
sun4i-dma.c
dmaengine: sun4i-dma: Demote obvious misuse of kerneldoc to standard comment blocks
2020-07-15 17:50:47 +05:30
sun6i-dma.c
dmaengine: sun6i: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:07 +05:30
tegra20-apb-dma.c
dmaengine: tegra20: Fix runtime PM imbalance on error
2021-04-28 13:40:01 +02:00
tegra210-adma.c
dmaengine: tegra210-adma: fix global intr clear
2023-01-24 07:20:00 +01:00
timb_dma.c
dmaengine: timb_dma: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:07 +05:30
TODO
…
txx9dmac.c
dmaengine: txx9dmac: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:07 +05:30
txx9dmac.h
…
uniphier-mdmac.c
dmaengine: uniphier-mdmac: replace zero-length array with flexible-array member
2020-02-13 20:15:57 +05:30
uniphier-xdmac.c
dmaengine: uniphier-xdmac: Fix type of address variables
2022-01-27 10:54:29 +01:00
virt-dma.c
dmaengine: virt-dma: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:07 +05:30
virt-dma.h
dmaengine: virt-dma: Add missing locking around list operations
2019-12-26 10:04:18 +05:30
xgene-dma.c
dmaengine: xgene: convert tasklets to use new tasklet_setup() API
2020-09-18 12:19:07 +05:30
zx_dma.c
dmaengine: zx: remove redundant irqsave in hardIRQ
2020-09-18 12:30:50 +05:30