Manish Rangankar
144d76a676
scsi: qedi: Fix crash while reading debugfs attribute ...
[ Upstream commit 28027ec8e32ecbadcd67623edb290dad61e735b5 ]
The qedi_dbg_do_not_recover_cmd_read() function invokes sprintf() directly
on a __user pointer, which results into the crash.
To fix this issue, use a small local stack buffer for sprintf() and then
call simple_read_from_buffer(), which in turns make the copy_to_user()
call.
BUG: unable to handle page fault for address: 00007f4801111000
PGD 8000000864df6067 P4D 8000000864df6067 PUD 864df7067 PMD 846028067 PTE 0
Oops: 0002 [#1 ] PREEMPT SMP PTI
Hardware name: HPE ProLiant DL380 Gen10/ProLiant DL380 Gen10, BIOS U30 06/15/2023
RIP: 0010:memcpy_orig+0xcd/0x130
RSP: 0018:ffffb7a18c3ffc40 EFLAGS: 00010202
RAX: 00007f4801111000 RBX: 00007f4801111000 RCX: 000000000000000f
RDX: 000000000000000f RSI: ffffffffc0bfd7a0 RDI: 00007f4801111000
RBP: ffffffffc0bfd7a0 R08: 725f746f6e5f6f64 R09: 3d7265766f636572
R10: ffffb7a18c3ffd08 R11: 0000000000000000 R12: 00007f4881110fff
R13: 000000007fffffff R14: ffffb7a18c3ffca0 R15: ffffffffc0bfd7af
FS: 00007f480118a740(0000) GS:ffff98e38af00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f4801111000 CR3: 0000000864b8e001 CR4: 00000000007706e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
<TASK>
? __die_body+0x1a/0x60
? page_fault_oops+0x183/0x510
? exc_page_fault+0x69/0x150
? asm_exc_page_fault+0x22/0x30
? memcpy_orig+0xcd/0x130
vsnprintf+0x102/0x4c0
sprintf+0x51/0x80
qedi_dbg_do_not_recover_cmd_read+0x2f/0x50 [qedi 6bcfdeeecdea037da47069eca2ba717c84a77324]
full_proxy_read+0x50/0x80
vfs_read+0xa5/0x2e0
? folio_add_new_anon_rmap+0x44/0xa0
? set_pte_at+0x15/0x30
? do_pte_missing+0x426/0x7f0
ksys_read+0xa5/0xe0
do_syscall_64+0x58/0x80
? __count_memcg_events+0x46/0x90
? count_memcg_event_mm+0x3d/0x60
? handle_mm_fault+0x196/0x2f0
? do_user_addr_fault+0x267/0x890
? exc_page_fault+0x69/0x150
entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f4800f20b4d
Tested-by: Martin Hoyer <mhoyer@redhat.com>
Reviewed-by: John Meneghini <jmeneghi@redhat.com>
Signed-off-by: Manish Rangankar <mrangankar@marvell.com>
Link: https://lore.kernel.org/r/20240415072155.30840-1-mrangankar@marvell.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-07-05 09:12:34 +02:00
2020-12-30 11:53:02 +01:00
2021-07-25 14:36:16 +02:00
2023-09-19 12:20:16 +02:00
2024-02-23 08:42:06 +01:00
2020-10-14 15:15:35 -07:00
2023-12-13 18:27:01 +01:00
2024-06-16 13:32:08 +02:00
2024-05-17 11:48:03 +02:00
2022-04-20 09:23:16 +02:00
2024-03-26 18:22:01 -04:00
2022-04-20 09:23:16 +02:00
2020-10-16 12:21:15 -07:00
2024-02-23 08:42:15 +01:00
2020-03-11 23:07:59 -04:00
2020-10-14 15:15:35 -07:00
2024-02-23 08:42:25 +01:00
2024-01-25 14:37:44 -08:00
2024-01-25 14:37:44 -08:00
2022-12-02 17:39:58 +01:00
2022-04-20 09:23:21 +02:00
2024-02-23 08:42:15 +01:00
2024-02-23 08:42:07 +01:00
2024-06-16 13:32:06 +02:00
2024-05-17 11:48:02 +02:00
2023-11-28 16:54:55 +00:00
2024-07-05 09:12:26 +02:00
2023-09-19 12:20:16 +02:00
2021-09-18 13:40:14 +02:00
2023-10-10 21:53:32 +02:00
2024-06-16 13:32:08 +02:00
2024-07-05 09:12:34 +02:00
2024-06-16 13:32:23 +02:00
2023-09-19 12:20:17 +02:00
2022-08-21 15:15:59 +02:00
2023-08-30 16:23:18 +02:00
2020-10-23 16:19:02 -07:00
2024-06-16 13:32:36 +02:00
2020-03-25 11:50:48 +01:00
2022-10-26 13:25:52 +02:00
2023-07-27 08:43:56 +02:00
2023-08-16 18:21:03 +02:00
2020-09-25 06:20:43 +02:00
2020-06-09 09:39:13 -07:00
2020-06-09 09:39:13 -07:00
2021-11-26 10:39:10 +01:00
2022-04-13 21:00:58 +02:00
2020-03-26 21:10:53 -04:00
2019-11-12 22:21:34 -05:00
2019-11-12 22:21:35 -05:00
2021-09-18 13:40:35 +02:00
2021-06-03 09:00:43 +02:00
2020-02-24 14:54:25 -05:00
2020-04-01 22:03:04 -04:00
2022-06-09 10:21:24 +02:00
2023-06-09 10:30:18 +02:00
2023-06-09 10:30:18 +02:00
2020-08-23 17:36:59 -05:00
2019-12-19 22:08:51 -05:00
2020-09-02 22:49:07 -04:00
2020-07-08 01:12:44 -04:00
2021-07-14 16:56:40 +02:00
2020-08-23 17:36:59 -05:00
2020-03-17 13:36:10 -04:00
2020-10-07 21:48:28 -04:00
2020-06-09 09:39:13 -07:00
2024-04-13 12:59:06 +02:00
2020-09-02 22:49:06 -04:00
2024-06-16 13:32:06 +02:00
2020-09-02 22:49:06 -04:00
2020-08-23 17:36:59 -05:00
2020-10-07 21:48:28 -04:00
2023-03-11 16:40:14 +01:00
2020-07-15 17:26:58 -04:00
2020-07-24 22:32:00 -04:00
2020-06-02 21:23:47 -04:00
2023-04-20 12:10:23 +02:00
2022-10-26 13:25:37 +02:00
2021-05-14 09:50:27 +02:00
2024-03-01 13:16:50 +01:00
2020-06-09 09:39:13 -07:00
2020-10-02 15:27:08 -07:00
2022-04-20 09:23:15 +02:00
2020-06-09 09:39:13 -07:00
2020-10-02 21:52:53 -04:00
2019-11-12 22:21:34 -05:00
2023-05-17 11:47:49 +02:00
2020-08-23 17:36:59 -05:00
2020-06-09 09:39:13 -07:00
2020-10-02 21:42:22 -04:00
2020-03-11 23:07:56 -04:00
2024-04-13 12:59:33 +02:00
2020-01-02 21:57:44 -05:00
2024-04-13 12:59:33 +02:00
2020-01-02 21:57:44 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-09-15 17:34:18 -04:00
2022-06-22 14:13:15 +02:00
2020-03-11 23:07:56 -04:00
2020-08-23 17:36:59 -05:00
2020-09-09 22:37:48 -04:00
2020-01-15 23:09:11 -05:00
2020-10-14 15:15:35 -07:00
2023-08-30 16:23:18 +02:00
2023-01-14 10:15:52 +01:00
2022-01-27 10:54:29 +01:00
2023-04-05 11:23:39 +02:00
2020-07-08 01:16:23 -04:00
2024-02-23 08:42:21 +01:00
2020-08-23 17:36:59 -05:00
2024-02-23 08:42:21 +01:00
2024-01-12 20:56:38 +01:00
2019-12-19 22:08:54 -05:00
2022-01-27 10:54:08 +01:00
2024-02-23 08:42:15 +01:00
2023-08-16 18:21:03 +02:00
2023-02-15 17:22:11 +01:00
2022-11-10 18:14:22 +01:00
2020-03-16 22:08:36 -04:00
2020-09-02 22:49:07 -04:00
2023-09-19 12:20:17 +02:00
2022-12-02 17:39:56 +01:00
2021-01-12 20:18:15 +01:00
2021-04-21 13:00:52 +02:00
2024-01-12 20:56:38 +01:00
2020-03-24 07:57:08 -06:00
2024-04-13 12:59:58 +02:00
2024-04-13 12:59:58 +02:00
2020-10-14 15:15:35 -07:00
2020-09-15 20:28:06 -04:00
2023-04-20 12:10:27 +02:00
2022-08-21 15:15:24 +02:00
2020-09-25 06:20:44 +02:00
2021-05-14 09:50:27 +02:00
2022-01-27 10:54:23 +01:00
2022-01-27 10:54:23 +01:00
2020-02-24 15:01:57 -05:00
2021-04-07 15:00:05 +02:00
2023-06-09 10:30:14 +02:00
2023-09-19 12:20:06 +02:00
2020-08-23 17:36:59 -05:00
2021-05-14 09:50:27 +02:00
2020-10-02 21:52:55 -04:00
2021-10-17 10:43:33 +02:00
2022-01-05 12:40:33 +01:00
2022-06-22 14:13:14 +02:00
2020-08-23 17:36:59 -05:00
2022-03-11 12:11:54 +01:00
2020-01-06 09:45:59 +01:00
2022-04-13 21:01:04 +02:00
2020-06-09 09:39:13 -07:00
144d76a676