iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Chengen Du b81a523d54 net/sched: Fix UAF when resolving a clash 
[ Upstream commit 26488172b0292bed837b95a006a3f3431d1898c3 ]

KASAN reports the following UAF:

 BUG: KASAN: slab-use-after-free in tcf_ct_flow_table_process_conn+0x12b/0x380 [act_ct]
 Read of size 1 at addr ffff888c07603600 by task handler130/6469

 Call Trace:
  <IRQ>
  dump_stack_lvl+0x48/0x70
  print_address_description.constprop.0+0x33/0x3d0
  print_report+0xc0/0x2b0
  kasan_report+0xd0/0x120
  __asan_load1+0x6c/0x80
  tcf_ct_flow_table_process_conn+0x12b/0x380 [act_ct]
  tcf_ct_act+0x886/0x1350 [act_ct]
  tcf_action_exec+0xf8/0x1f0
  fl_classify+0x355/0x360 [cls_flower]
  __tcf_classify+0x1fd/0x330
  tcf_classify+0x21c/0x3c0
  sch_handle_ingress.constprop.0+0x2c5/0x500
  __netif_receive_skb_core.constprop.0+0xb25/0x1510
  __netif_receive_skb_list_core+0x220/0x4c0
  netif_receive_skb_list_internal+0x446/0x620
  napi_complete_done+0x157/0x3d0
  gro_cell_poll+0xcf/0x100
  __napi_poll+0x65/0x310
  net_rx_action+0x30c/0x5c0
  __do_softirq+0x14f/0x491
  __irq_exit_rcu+0x82/0xc0
  irq_exit_rcu+0xe/0x20
  common_interrupt+0xa1/0xb0
  </IRQ>
  <TASK>
  asm_common_interrupt+0x27/0x40

 Allocated by task 6469:
  kasan_save_stack+0x38/0x70
  kasan_set_track+0x25/0x40
  kasan_save_alloc_info+0x1e/0x40
  __kasan_krealloc+0x133/0x190
  krealloc+0xaa/0x130
  nf_ct_ext_add+0xed/0x230 [nf_conntrack]
  tcf_ct_act+0x1095/0x1350 [act_ct]
  tcf_action_exec+0xf8/0x1f0
  fl_classify+0x355/0x360 [cls_flower]
  __tcf_classify+0x1fd/0x330
  tcf_classify+0x21c/0x3c0
  sch_handle_ingress.constprop.0+0x2c5/0x500
  __netif_receive_skb_core.constprop.0+0xb25/0x1510
  __netif_receive_skb_list_core+0x220/0x4c0
  netif_receive_skb_list_internal+0x446/0x620
  napi_complete_done+0x157/0x3d0
  gro_cell_poll+0xcf/0x100
  __napi_poll+0x65/0x310
  net_rx_action+0x30c/0x5c0
  __do_softirq+0x14f/0x491

 Freed by task 6469:
  kasan_save_stack+0x38/0x70
  kasan_set_track+0x25/0x40
  kasan_save_free_info+0x2b/0x60
  ____kasan_slab_free+0x180/0x1f0
  __kasan_slab_free+0x12/0x30
  slab_free_freelist_hook+0xd2/0x1a0
  __kmem_cache_free+0x1a2/0x2f0
  kfree+0x78/0x120
  nf_conntrack_free+0x74/0x130 [nf_conntrack]
  nf_ct_destroy+0xb2/0x140 [nf_conntrack]
  __nf_ct_resolve_clash+0x529/0x5d0 [nf_conntrack]
  nf_ct_resolve_clash+0xf6/0x490 [nf_conntrack]
  __nf_conntrack_confirm+0x2c6/0x770 [nf_conntrack]
  tcf_ct_act+0x12ad/0x1350 [act_ct]
  tcf_action_exec+0xf8/0x1f0
  fl_classify+0x355/0x360 [cls_flower]
  __tcf_classify+0x1fd/0x330
  tcf_classify+0x21c/0x3c0
  sch_handle_ingress.constprop.0+0x2c5/0x500
  __netif_receive_skb_core.constprop.0+0xb25/0x1510
  __netif_receive_skb_list_core+0x220/0x4c0
  netif_receive_skb_list_internal+0x446/0x620
  napi_complete_done+0x157/0x3d0
  gro_cell_poll+0xcf/0x100
  __napi_poll+0x65/0x310
  net_rx_action+0x30c/0x5c0
  __do_softirq+0x14f/0x491

The ct may be dropped if a clash has been resolved but is still passed to
the tcf_ct_flow_table_process_conn function for further usage. This issue
can be fixed by retrieving ct from skb again after confirming conntrack.

Fixes: 0cc254e5aa37 ("net/sched: act_ct: Offload connections with commit action")
Co-developed-by: Gerald Yang <gerald.yang@canonical.com>
Signed-off-by: Gerald Yang <gerald.yang@canonical.com>
Signed-off-by: Chengen Du <chengen.du@canonical.com>
Link: https://patch.msgid.link/20240710053747.13223-1-chengen.du@canonical.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-07-18 13:05:46 +02:00
..
act_api.c
net/sched: act_api: fix possible infinite loop in tcf_idr_check_alloc()
2024-07-05 09:12:38 +02:00
act_bpf.c
flow_offload: fill flags to action structure
2023-02-22 12:55:59 +01:00
act_connmark.c
flow_offload: fill flags to action structure
2023-02-22 12:55:59 +01:00
act_csum.c
…
act_ct.c
net/sched: Fix UAF when resolving a clash
2024-07-18 13:05:46 +02:00
act_ctinfo.c
net/sched: act_ctinfo: use percpu stats
2023-02-22 12:55:59 +01:00
act_gact.c
…
act_gate.c
flow_offload: fill flags to action structure
2023-02-22 12:55:59 +01:00
act_ife.c
flow_offload: fill flags to action structure
2023-02-22 12:55:59 +01:00
act_ipt.c
flow_offload: fill flags to action structure
2023-02-22 12:55:59 +01:00
act_meta_mark.c
…
act_meta_skbprio.c
…
act_meta_skbtcindex.c
…
act_mirred.c
act_mirred: use the backlog for nested calls to mirred ingress
2023-05-30 12:57:56 +01:00
act_mpls.c
flow_offload: fill flags to action structure
2023-02-22 12:55:59 +01:00
act_nat.c
flow_offload: fill flags to action structure
2023-02-22 12:55:59 +01:00
act_pedit.c
net/sched: act_pedit: Add size check for TCA_PEDIT_PARMS_EX
2023-07-27 08:44:09 +02:00
act_police.c
flow_offload: fill flags to action structure
2023-02-22 12:55:59 +01:00
act_sample.c
net/sched: act_sample: fix action bind logic
2023-03-11 16:40:13 +01:00
act_simple.c
flow_offload: fill flags to action structure
2023-02-22 12:55:59 +01:00
act_skbedit.c
flow_offload: fill flags to action structure
2023-02-22 12:55:59 +01:00
act_skbmod.c
net/sched: act_skbmod: prevent kernel-infoleak
2024-04-13 12:59:26 +02:00
act_tunnel_key.c
net/sched: act_tunnel_key: fix OOB write in case of IPv6 ERSPAN tunnels
2020-10-20 21:10:41 -07:00
act_vlan.c
net/sched: act_vlan: Fix modify to allow 0
2021-07-14 16:56:19 +02:00
cls_api.c
net/sched: cls_api: Fix lockup on flushing explicitly created chain
2023-06-21 15:45:40 +02:00
cls_basic.c
…
cls_bpf.c
…
cls_cgroup.c
…
cls_flow.c
…
cls_flower.c
net/sched: flower: Ensure both minimum and maximum ports are specified
2023-07-27 08:44:24 +02:00
cls_fw.c
net/sched: cls_fw: No longer copy tcf_result on update to avoid use-after-free
2023-08-11 11:57:49 +02:00
cls_matchall.c
…
cls_route.c
net/sched: cls_route: No longer copy tcf_result on update to avoid use-after-free
2023-08-11 11:57:49 +02:00
cls_u32.c
net: sched: cls_u32: Fix allocation size in u32_init()
2023-11-08 17:30:48 +01:00
em_canid.c
…
em_cmp.c
…
em_ipset.c
…
em_ipt.c
…
em_meta.c
…
em_nbyte.c
…
em_text.c
net: sched: em_text: fix possible memory leak in em_text_destroy()
2024-01-15 18:48:04 +01:00
em_u32.c
…
ematch.c
net_sched: reject TCF_EM_SIMPLE case for complex ematch module
2023-01-14 10:16:12 +01:00
Kconfig
net/sched: Retire dsmark qdisc
2024-03-01 13:16:42 +01:00
Makefile
net/sched: Retire dsmark qdisc
2024-03-01 13:16:42 +01:00
sch_api.c
net/sched: fix a qdisc modification with ambiguous command request
2023-08-30 16:23:13 +02:00
sch_blackhole.c
…
sch_cake.c
net: sched: cake: fix null pointer access issue when cake_init() fails
2022-10-30 09:41:17 +01:00
sch_cbs.c
…
sch_choke.c
net: sched: delete duplicate cleanup of backlog and qlen
2022-10-30 09:41:17 +01:00
sch_codel.c
…
sch_drr.c
net: sched: delete duplicate cleanup of backlog and qlen
2022-10-30 09:41:17 +01:00
sch_etf.c
net: sched: delete duplicate cleanup of backlog and qlen
2022-10-30 09:41:17 +01:00
sch_ets.c
net: sched: delete duplicate cleanup of backlog and qlen
2022-10-30 09:41:17 +01:00
sch_fifo.c
net_sched: fix NULL deref in fifo_set_limit()
2021-10-13 10:04:26 +02:00
sch_fq_codel.c
net: sched: delete duplicate cleanup of backlog and qlen
2022-10-30 09:41:17 +01:00
sch_fq_pie.c
net/sched: fq_pie: avoid stalls in fq_pie_timer()
2023-09-19 12:20:25 +02:00
sch_fq.c
net/sched: sch_fq: fix integer overflow of "credit"
2023-05-17 11:47:53 +02:00
sch_generic.c
net/sched: fix netdevice reference leaks in attach_default_qdiscs()
2022-09-08 11:11:36 +02:00
sch_gred.c
net: sched: validate stab values
2021-03-30 14:31:57 +02:00
sch_hfsc.c
net/sched: sch_hfsc: upgrade 'rt' to 'sc' when it becomes a inner curve
2023-10-25 11:54:20 +02:00
sch_hhf.c
…
sch_htb.c
net: sched: sch: Fix off by one in htb_activate_prios()
2023-02-22 12:56:00 +01:00
sch_ingress.c
net/sched: Reserve TC_H_INGRESS (TC_H_CLSACT) for ingress (clsact) Qdiscs
2023-06-09 10:30:06 +02:00
sch_mq.c
net: sched: update default qdisc visibility after Tx queue cnt changes
2021-11-18 14:03:53 +01:00
sch_mqprio.c
net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64
2023-08-11 11:57:37 +02:00
sch_multiq.c
net: sched: sch_multiq: fix possible OOB write in multiq_tune()
2024-07-05 09:12:22 +02:00
sch_netem.c
sch_netem: fix issues in netem_change() vs get_dist_table()
2023-08-16 18:21:03 +02:00
sch_pie.c
…
sch_plug.c
net: sched: sch_qfq: Fix UAF in qfq_dequeue()
2023-09-19 12:20:26 +02:00
sch_prio.c
net: sched: delete duplicate cleanup of backlog and qlen
2022-10-30 09:41:17 +01:00
sch_qfq.c
net: sched: sch_qfq: Fix UAF in qfq_dequeue()
2023-09-19 12:20:26 +02:00
sch_red.c
net: sched: Fix use after free in red_enqueue()
2022-11-10 18:14:18 +01:00
sch_sfb.c
net: sched: sfb: fix null pointer access issue when sfb_init() fails
2022-10-30 09:41:17 +01:00
sch_sfq.c
net: sched: validate stab values
2021-03-30 14:31:57 +02:00
sch_skbprio.c
net: sched: delete duplicate cleanup of backlog and qlen
2022-10-30 09:41:17 +01:00
sch_taprio.c
net/sched: taprio: always validate TCA_TAPRIO_ATTR_PRIOMAP
2024-07-05 09:12:22 +02:00
sch_tbf.c
net: sched: delete duplicate cleanup of backlog and qlen
2022-10-30 09:41:17 +01:00
sch_teql.c
net: sched: delete duplicate cleanup of backlog and qlen
2022-10-30 09:41:17 +01:00