iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/pci
History
Geert Uytterhoeven 6d4fabc6c7 PCI: Fix pci_register_io_range() memory leak 
[ Upstream commit f6bda644fa3a7070621c3bf12cd657f69a42f170 ]

Kmemleak reports:

  unreferenced object 0xc328de40 (size 64):
    comm "kworker/1:1", pid 21, jiffies 4294938212 (age 1484.670s)
    hex dump (first 32 bytes):
      00 00 00 00 00 00 00 00 e0 d8 fc eb 00 00 00 00  ................
      00 00 10 fe 00 00 00 00 00 00 00 00 00 00 00 00  ................

  backtrace:
    [<ad758d10>] pci_register_io_range+0x3c/0x80
    [<2c7f139e>] of_pci_range_to_resource+0x48/0xc0
    [<f079ecc8>] devm_of_pci_get_host_bridge_resources.constprop.0+0x2ac/0x3ac
    [<e999753b>] devm_of_pci_bridge_init+0x60/0x1b8
    [<a895b229>] devm_pci_alloc_host_bridge+0x54/0x64
    [<e451ddb0>] rcar_pcie_probe+0x2c/0x644

In case a PCI host driver's probe is deferred, the same I/O range may be
allocated again, and be ignored, causing a memory leak.

Fix this by (a) letting logic_pio_register_range() return -EEXIST if the
passed range already exists, so pci_register_io_range() will free it, and
by (b) making pci_register_io_range() not consider -EEXIST an error
condition.

Link: https://lore.kernel.org/r/20210202100332.829047-1-geert+renesas@glider.be
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-03-17 17:06:25 +01:00
..
controller
PCI: mediatek: Add missing of_node_put() to fix reference leak
2021-03-17 17:06:24 +01:00
endpoint
PCI: Fix kerneldoc warnings
2020-08-05 18:23:14 -05:00
hotplug
pci-v5.10-changes
2020-10-22 12:41:00 -07:00
pcie
PCI/LINK: Remove bandwidth notification
2021-03-17 17:06:24 +01:00
switch
PCI: switchtec: Add missing __iomem tag to fix sparse warnings
2020-07-31 11:23:45 -05:00
access.c
Merge branch 'pci/misc'
2020-08-05 18:24:16 -05:00
ats.c
Merge branch 'pci/doc'
2020-08-05 18:24:22 -05:00
bus.c
PCI: Add device even if driver attach failed
2020-07-07 17:33:41 -05:00
ecam.c
PCI/ACPI: Add Ampere Altra SOC MCFG quirk
2020-09-17 12:27:43 -05:00
host-bridge.c
…
iov.c
PCI/IOV: Mark VFs as not implementing PCI_COMMAND_MEMORY
2020-09-21 14:42:11 -06:00
irq.c
PCI: Remove unused pci_lost_interrupt()
2020-07-29 14:25:18 -05:00
Kconfig
pci-v5.10-changes
2020-10-22 12:41:00 -07:00
Makefile
…
mmap.c
…
msi.c
PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable
2020-09-16 16:52:37 +02:00
of.c
Merge branch 'pci/doc'
2020-08-05 18:24:22 -05:00
p2pdma.c
pci-v5.10-changes
2020-10-22 12:41:00 -07:00
pci-acpi.c
PM: ACPI: PCI: Drop acpi_pm_set_bridge_wakeup()
2020-12-30 11:54:05 +01:00
pci-bridge-emul.c
PCI: pci-bridge-emul: Fix array overruns, improve safety
2021-03-04 11:38:15 +01:00
pci-bridge-emul.h
…
pci-driver.c
pci-v5.10-changes
2020-10-22 12:41:00 -07:00
pci-label.c
PCI: Replace http:// links with https://
2020-06-30 13:05:09 -05:00
pci-mid.c
…
pci-pf-stub.c
PCI/IOV: Simplify pci-pf-stub with module_pci_driver()
2020-09-17 12:40:20 -05:00
pci-stub.c
…
pci-sysfs.c
Merge branch 'pci/misc'
2020-10-21 09:58:36 -05:00
pci.c
PCI: Fix pci_register_io_range() memory leak
2021-03-17 17:06:25 +01:00
pci.h
PCI/PM: Revert "PCI/PM: Apply D2 delay as milliseconds, not microseconds"
2020-09-30 17:01:46 -05:00
probe.c
Merge branch 'remotes/lorenzo/pci/dwc'
2020-10-21 09:58:39 -05:00
proc.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
quirks.c
PCI: Add function 1 DMA alias quirk for Marvell 9215 SATA controller
2021-03-11 14:17:26 +01:00
remove.c
PCI: Fix pci_host_bridge struct device release/free handling
2020-05-14 16:36:35 -05:00
rom.c
…
search.c
…
setup-bus.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
setup-irq.c
…
setup-res.c
PCI: Decline to resize resources if boot config must be preserved
2021-03-04 11:37:18 +01:00
slot.c
PCI: Fix pci_slot_release() NULL pointer dereference
2020-12-30 11:54:28 +01:00
syscall.c
PCI: Align checking of syscall user config accessors
2021-03-04 11:38:12 +01:00
vc.c
PCI: Fix kerneldoc warnings
2020-08-05 18:23:14 -05:00
vpd.c
…
xen-pcifront.c
dma-mapping: split <linux/dma-mapping.h>
2020-10-06 07:07:03 +02:00