iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/kernel/bpf
History
Zqiang ccd5565fee bpf: Fix umd memory leak in copy_process() 
[ Upstream commit f60a85cad677c4f9bb4cadd764f1d106c38c7cf8 ]

The syzbot reported a memleak as follows:

BUG: memory leak
unreferenced object 0xffff888101b41d00 (size 120):
  comm "kworker/u4:0", pid 8, jiffies 4294944270 (age 12.780s)
  backtrace:
    [<ffffffff8125dc56>] alloc_pid+0x66/0x560
    [<ffffffff81226405>] copy_process+0x1465/0x25e0
    [<ffffffff81227943>] kernel_clone+0xf3/0x670
    [<ffffffff812281a1>] kernel_thread+0x61/0x80
    [<ffffffff81253464>] call_usermodehelper_exec_work
    [<ffffffff81253464>] call_usermodehelper_exec_work+0xc4/0x120
    [<ffffffff812591c9>] process_one_work+0x2c9/0x600
    [<ffffffff81259ab9>] worker_thread+0x59/0x5d0
    [<ffffffff812611c8>] kthread+0x178/0x1b0
    [<ffffffff8100227f>] ret_from_fork+0x1f/0x30

unreferenced object 0xffff888110ef5c00 (size 232):
  comm "kworker/u4:0", pid 8414, jiffies 4294944270 (age 12.780s)
  backtrace:
    [<ffffffff8154a0cf>] kmem_cache_zalloc
    [<ffffffff8154a0cf>] __alloc_file+0x1f/0xf0
    [<ffffffff8154a809>] alloc_empty_file+0x69/0x120
    [<ffffffff8154a8f3>] alloc_file+0x33/0x1b0
    [<ffffffff8154ab22>] alloc_file_pseudo+0xb2/0x140
    [<ffffffff81559218>] create_pipe_files+0x138/0x2e0
    [<ffffffff8126c793>] umd_setup+0x33/0x220
    [<ffffffff81253574>] call_usermodehelper_exec_async+0xb4/0x1b0
    [<ffffffff8100227f>] ret_from_fork+0x1f/0x30

After the UMD process exits, the pipe_to_umh/pipe_from_umh and
tgid need to be released.

Fixes: d71fa5c9763c ("bpf: Add kernel module with user mode driver that populates bpffs.")
Reported-by: syzbot+44908bb56d2bfe56b28e@syzkaller.appspotmail.com
Signed-off-by: Zqiang <qiang.zhang@windriver.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20210317030915.2865-1-qiang.zhang@windriver.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-03-30 14:32:03 +02:00
..
preload
bpf: Fix umd memory leak in copy_process()
2021-03-30 14:32:03 +02:00
arraymap.c
bpf: Allow for map-in-map with dynamic inner array map entries
2020-10-11 10:21:04 -07:00
bpf_inode_storage.c
bpf: Change inode_storage's lookup_elem return value from NULL to -EBADF
2021-03-30 14:31:56 +02:00
bpf_iter.c
bpf: Fix an unitialized value in bpf_iter
2021-03-04 11:37:33 +01:00
bpf_local_storage.c
bpf: Use hlist_add_head_rcu when linking to local_storage
2020-09-19 01:12:35 +02:00
bpf_lru_list.c
bpf_lru_list: Read double-checked variable once without lock
2021-03-04 11:37:29 +01:00
bpf_lru_list.h
bpf: Fix a typo "inacitve" -> "inactive"
2020-04-06 21:54:10 +02:00
bpf_lsm.c
bpf: Update verification logic for LSM programs
2020-11-06 13:15:21 -08:00
bpf_struct_ops_types.h
bpf: tcp: Support tcp_congestion_ops in bpf
2020-01-09 08:46:18 -08:00
bpf_struct_ops.c
bpf: Move btf_resolve_size into __btf_resolve_size
2020-08-25 15:37:41 -07:00
btf.c
bpf: Introduce bpf_per_cpu_ptr()
2020-10-02 15:00:49 -07:00
cgroup.c
bpf, cgroup: Fix problematic bounds check
2021-02-10 09:29:12 +01:00
core.c
bpf: Don't rely on GCC __attribute__((optimize)) to disable GCSE
2020-10-29 20:01:46 -07:00
cpumap.c
bpf, cpumap: Remove rcpu pointer from cpu_map_build_skb signature
2020-09-28 23:30:42 +02:00
devmap.c
bpf, devmap: Use GFP_KERNEL for xdp bulk queue allocation
2021-03-04 11:37:33 +01:00
disasm.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295
2019-06-05 17:36:38 +02:00
disasm.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295
2019-06-05 17:36:38 +02:00
dispatcher.c
bpf: Remove bpf_image tree
2020-03-13 12:49:52 -07:00
hashtab.c
bpf: Zero-fill re-used per-cpu map element
2020-11-05 19:55:57 -08:00
helpers.c
bpf: Fix helper bpf_map_peek_elem_proto pointing to wrong callback
2021-01-23 16:03:59 +01:00
inode.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-09-22 16:45:34 -07:00
local_storage.c
bpf/local_storage: Fix build without CONFIG_CGROUP
2020-07-25 20:16:36 -07:00
lpm_trie.c
bpf: Add map_meta_equal map ops
2020-08-28 15:41:30 +02:00
Makefile
bpf: Don't rely on GCC __attribute__((optimize)) to disable GCSE
2020-10-29 20:01:46 -07:00
map_in_map.c
bpf: Relax max_entries check for most of the inner map types
2020-08-28 15:41:30 +02:00
map_in_map.h
bpf: Add map_meta_equal map ops
2020-08-28 15:41:30 +02:00
map_iter.c
bpf: Implement link_query callbacks in map element iterators
2020-08-21 14:01:39 -07:00
net_namespace.c
bpf: Add support for forced LINK_DETACH command
2020-08-01 20:38:28 -07:00
offload.c
bpf, offload: Replace bitwise AND by logical AND in bpf_prog_offload_info_fill
2020-02-17 16:53:49 +01:00
percpu_freelist.c
bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI
2020-10-06 00:04:11 +02:00
percpu_freelist.h
bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI
2020-10-06 00:04:11 +02:00
prog_iter.c
bpf: Refactor bpf_iter_reg to have separate seq_info member
2020-07-25 20:16:32 -07:00
queue_stack_maps.c
bpf: Add map_meta_equal map ops
2020-08-28 15:41:30 +02:00
reuseport_array.c
bpf, net: Rework cookie generator as per-cpu one
2020-09-30 11:50:35 -07:00
ringbuf.c
bpf: Add map_meta_equal map ops
2020-08-28 15:41:30 +02:00
stackmap.c
bpf: Check for integer overflow when using roundup_pow_of_two()
2021-02-17 11:02:25 +01:00
syscall.c
bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach
2021-01-27 11:55:07 +01:00
sysfs_btf.c
bpf: Fix sysfs export of empty BTF section
2020-09-21 21:50:24 +02:00
task_iter.c
bpf: Save correct stopping point in file seq iteration
2021-01-19 18:27:28 +01:00
tnum.c
bpf: Verifier, do explicit ALU32 bounds tracking
2020-03-30 14:59:53 -07:00
trampoline.c
bpf: Move prog->aux->linked_prog and trampoline into bpf_link on attach
2020-09-29 13:09:23 -07:00
verifier.c
bpf: Add sanity check for upper ptr_limit
2021-03-20 10:43:43 +01:00