iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/md
History
Dae R. Jeong 70eb256f8c md: fix a warning caused by a race between concurrent md_ioctl()s 
commit c731b84b51bf7fe83448bea8f56a6d55006b0615 upstream.

Syzkaller reports a warning as belows.
WARNING: CPU: 0 PID: 9647 at drivers/md/md.c:7169
...
Call Trace:
...
RIP: 0010:md_ioctl+0x4017/0x5980 drivers/md/md.c:7169
RSP: 0018:ffff888096027950 EFLAGS: 00010293
RAX: ffff88809322c380 RBX: 0000000000000932 RCX: ffffffff84e266f2
RDX: 0000000000000000 RSI: ffffffff84e299f7 RDI: 0000000000000007
RBP: ffff888096027bc0 R08: ffff88809322c380 R09: ffffed101341a482
R10: ffff888096027940 R11: ffff88809a0d240f R12: 0000000000000932
R13: ffff8880a2c14100 R14: ffff88809a0d2268 R15: ffff88809a0d2408
 __blkdev_driver_ioctl block/ioctl.c:304 [inline]
 blkdev_ioctl+0xece/0x1c10 block/ioctl.c:606
 block_ioctl+0xee/0x130 fs/block_dev.c:1930
 vfs_ioctl fs/ioctl.c:46 [inline]
 file_ioctl fs/ioctl.c:509 [inline]
 do_vfs_ioctl+0xd5f/0x1380 fs/ioctl.c:696
 ksys_ioctl+0xab/0xd0 fs/ioctl.c:713
 __do_sys_ioctl fs/ioctl.c:720 [inline]
 __se_sys_ioctl fs/ioctl.c:718 [inline]
 __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718
 do_syscall_64+0xfd/0x680 arch/x86/entry/common.c:301
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

This is caused by a race between two concurrenct md_ioctl()s closing
the array.
CPU1 (md_ioctl())                   CPU2 (md_ioctl())
------                              ------
set_bit(MD_CLOSING, &mddev->flags);
did_set_md_closing = true;
                                    WARN_ON_ONCE(test_bit(MD_CLOSING,
                                            &mddev->flags));
if(did_set_md_closing)
    clear_bit(MD_CLOSING, &mddev->flags);

Fix the warning by returning immediately if the MD_CLOSING bit is set
in &mddev->flags which indicates that the array is being closed.

Fixes: 065e519e71b2 ("md: MD_CLOSING needs to be cleared after called md_set_readonly or do_md_stop")
Reported-by: syzbot+1e46a0864c1a6e9bd3d8@syzkaller.appspotmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Dae R. Jeong <dae.r.jeong@kaist.ac.kr>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-12-26 16:02:45 +01:00
..
bcache
bcache: remove embedded struct cache_sb from struct cache_set
2020-10-02 14:25:30 -06:00
persistent-data
dm thin metadata: Remove unused local variable when create thin and snap
2020-09-29 16:33:11 -04:00
dm-bio-prison-v1.c
dm bio prison: replace spin_lock_irqsave with spin_lock_irq
2019-11-05 14:53:03 -05:00
dm-bio-prison-v1.h
…
dm-bio-prison-v2.c
dm bio prison v2: use true/false for bool variable
2020-01-07 12:07:08 -05:00
dm-bio-prison-v2.h
…
dm-bio-record.h
dm bio record: save/restore bi_end_io and bi_integrity
2020-03-03 10:02:46 -05:00
dm-bufio.c
dm bufio: do buffer cleanup from a workqueue
2020-07-20 11:17:43 -04:00
dm-builtin.c
…
dm-cache-background-tracker.c
…
dm-cache-background-tracker.h
…
dm-cache-block-types.h
…
dm-cache-metadata.c
dm cache metadata: Avoid returning cmd->bm wild pointer on error
2020-09-02 13:38:24 -04:00
dm-cache-metadata.h
…
dm-cache-policy-internal.h
…
dm-cache-policy-smq.c
…
dm-cache-policy.c
…
dm-cache-policy.h
…
dm-cache-target.c
Revert "dm cache: fix arm link errors with inline"
2020-12-01 15:43:36 -05:00
dm-clone-metadata.c
dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()
2020-03-27 14:42:51 -04:00
dm-clone-metadata.h
dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()
2020-03-27 14:42:51 -04:00
dm-clone-target.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
dm-core.h
dm table: make 'struct dm_table' definition accessible to all of DM core
2020-09-29 16:33:07 -04:00
dm-crypt.c
dm crypt: don't use drivers that have CRYPTO_ALG_ALLOCATES_MEMORY
2020-09-29 16:33:08 -04:00
dm-delay.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
dm-dust.c
dm dust: add interface to list all badblocks
2020-07-20 11:17:41 -04:00
dm-ebs-target.c
dm ebs: Fix incorrect checking for REQ_OP_FLUSH
2020-08-04 16:01:40 -04:00
dm-era-target.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
dm-exception-store.c
…
dm-exception-store.h
- Improve DM snapshot target's scalability by using finer grained
2019-05-16 15:55:48 -07:00
dm-flakey.c
block: rework zone reporting
2019-11-12 19:12:07 -07:00
dm-historical-service-time.c
dm mpath: add Historical Service Time Path Selector
2020-05-15 10:29:36 -04:00
dm-init.c
dm init: Set file local variable static
2020-08-04 15:51:28 -04:00
dm-integrity.c
dm integrity: don't use drivers that have CRYPTO_ALG_ALLOCATES_MEMORY
2020-11-17 10:45:06 -05:00
dm-io.c
treewide: Remove uninitialized_var() usage
2020-07-16 12:35:15 -07:00
dm-ioctl.c
dm: export dm_copy_name_and_uuid
2020-10-01 15:03:40 -04:00
dm-kcopyd.c
dm kcopyd: always complete failed jobs
2019-08-15 15:57:39 -04:00
dm-linear.c
dm: add support for REQ_NOWAIT and enable it for linear target
2020-09-25 08:20:03 -06:00
dm-log-userspace-base.c
…
dm-log-userspace-transfer.c
…
dm-log-userspace-transfer.h
…
dm-log-writes.c
dm: replace zero-length array with flexible-array
2020-05-20 17:09:44 -04:00
dm-log.c
…
dm-mpath.c
dm: use dm_table_get_device_name() where appropriate in targets
2020-09-29 16:33:08 -04:00
dm-mpath.h
…
dm-path-selector.c
…
dm-path-selector.h
dm mpath: pass IO start time to path selector
2020-05-15 10:29:36 -04:00
dm-queue-length.c
dm mpath: pass IO start time to path selector
2020-05-15 10:29:36 -04:00
dm-raid1.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
dm-raid.c
Revert "dm raid: fix discard limits for raid1 and raid10"
2020-12-14 19:33:01 +01:00
dm-region-hash.c
…
dm-round-robin.c
…
dm-rq.c
dm table: make 'struct dm_table' definition accessible to all of DM core
2020-09-29 16:33:07 -04:00
dm-rq.h
dm: remove unused _rq_tio_cache and _rq_cache
2019-03-05 14:48:50 -05:00
dm-service-time.c
dm mpath: pass IO start time to path selector
2020-05-15 10:29:36 -04:00
dm-snap-persistent.c
dm snap persistent: simplify area_io()
2020-09-29 16:33:12 -04:00
dm-snap-transient.c
…
dm-snap.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
dm-stats.c
dm: replace zero-length array with flexible-array
2020-05-20 17:09:44 -04:00
dm-stats.h
…
dm-stripe.c
dm: replace zero-length array with flexible-array
2020-05-20 17:09:44 -04:00
dm-switch.c
dm: replace zero-length array with flexible-array
2020-05-20 17:09:44 -04:00
dm-sysfs.c
…
dm-table.c
dm: fix IO splitting
2020-12-04 14:53:15 -05:00
dm-target.c
dm mpath: fix missing call of path selector type->end_io
2019-04-25 15:38:52 -04:00
dm-thin-metadata.c
dm thin metadata: Remove unused local variable when create thin and snap
2020-09-29 16:33:11 -04:00
dm-thin-metadata.h
dm thin metadata: Add support for a pre-commit callback
2019-12-05 17:05:24 -05:00
dm-thin.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
dm-uevent.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
dm-uevent.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
dm-unstripe.c
…
dm-verity-fec.c
dm verity fec: fix hash block number in verity_fec_decode
2020-04-16 16:16:38 -04:00
dm-verity-fec.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dm-verity-target.c
- DM multipath locking fixes around m->flags tests and improvements to
2020-08-07 13:08:09 -07:00
dm-verity-verify-sig.c
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm-verity-verify-sig.h
dm verity: Fix compilation warning
2020-08-04 15:48:13 -04:00
dm-verity.h
dm verity: add "panic_on_corruption" error handling mode
2020-07-13 11:47:33 -04:00
dm-writecache.c
dm writecache: remove BUG() and fail gracefully instead
2020-12-01 15:43:39 -05:00
dm-zero.c
…
dm-zoned-metadata.c
dm zoned: Fix zone reclaim trigger
2020-07-08 12:21:53 -04:00
dm-zoned-reclaim.c
dm zoned: Fix zone reclaim trigger
2020-07-08 12:21:53 -04:00
dm-zoned-target.c
for-5.9/block-20200802
2020-08-03 11:57:03 -07:00
dm-zoned.h
dm zoned: select reclaim zone based on device index
2020-06-05 14:59:53 -04:00
dm.c
dm: remove invalid sparse __acquires and __releases annotations
2020-12-04 15:25:18 -05:00
dm.h
dm table: make 'struct dm_table' definition accessible to all of DM core
2020-09-29 16:33:07 -04:00
Kconfig
Replace HTTP links with HTTPS ones: LVM
2020-07-05 14:28:27 -06:00
Makefile
md: move the early init autodetect code to drivers/md/
2020-07-16 15:34:47 +02:00
md-autodetect.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
md-bitmap.c
md/bitmap: fix memory leak of temporary bitmap
2020-10-08 22:37:39 -07:00
md-bitmap.h
…
md-cluster.c
md/bitmap: fix memory leak of temporary bitmap
2020-10-08 22:37:39 -07:00
md-cluster.h
…
md-faulty.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
md-linear.c
block: add a new revalidate_disk_size helper
2020-09-02 08:00:07 -06:00
md-linear.h
md/raid1: Replace zero-length array with flexible-array
2020-05-13 12:02:23 -07:00
md-multipath.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
md-multipath.h
…
md.c
md: fix a warning caused by a race between concurrent md_ioctl()s
2020-12-26 16:02:45 +01:00
md.h
Revert "md: change mddev 'chunk_sectors' from int to unsigned"
2020-12-14 19:33:01 +01:00
raid0.c
Revert "md: add md_submit_discard_bio() for submitting discard bio"
2020-12-09 20:46:01 -08:00
raid0.h
md/raid0: avoid RAID0 data corruption due to layout confusion.
2019-09-13 13:10:05 -07:00
raid1-10.c
md: raid1-10: Unify r{1,10}bio_pool_free
2019-06-15 01:37:35 -06:00
raid1.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
raid1.h
md/raid1: Replace zero-length array with flexible-array
2020-05-13 12:02:23 -07:00
raid5-cache.c
raid5-cache: hold spinlock instead of mutex in r5c_journal_mode_show
2020-08-02 23:03:52 -07:00
raid5-log.h
raid5: set write hint for PPL
2019-03-12 10:15:18 -07:00
raid5-ppl.c
md/raid456: convert macro STRIPE_* to RAID5_STRIPE_*
2020-07-21 17:18:12 -07:00
raid5.c
md/raid5: fix oops during stripe resizing
2020-10-08 22:38:10 -07:00
raid5.h
md/raid5: let multiple devices of stripe_head share page
2020-09-24 16:44:44 -07:00
raid10.c
Revert "md/raid10: extend r10bio devs to raid disks"
2020-12-09 20:46:01 -08:00
raid10.h
Revert "md/raid10: improve discard request for far layout"
2020-12-09 20:46:00 -08:00