Eric Dumazet
905b2032fa
mac80211: mesh: fix mesh_pathtbl_init() error path ...
If tbl_mpp can not be allocated, we call mesh_table_free(tbl_path)
while tbl_path rhashtable has not yet been initialized, which causes
panics.
Simply factorize the rhashtable_init() call into mesh_table_alloc()
WARNING: CPU: 1 PID: 8474 at kernel/workqueue.c:3040 __flush_work kernel/workqueue.c:3040 [inline]
WARNING: CPU: 1 PID: 8474 at kernel/workqueue.c:3040 __cancel_work_timer+0x514/0x540 kernel/workqueue.c:3136
Modules linked in:
CPU: 1 PID: 8474 Comm: syz-executor663 Not tainted 5.10.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:__flush_work kernel/workqueue.c:3040 [inline]
RIP: 0010:__cancel_work_timer+0x514/0x540 kernel/workqueue.c:3136
Code: 5d c3 e8 bf ae 29 00 0f 0b e9 f0 fd ff ff e8 b3 ae 29 00 0f 0b 43 80 3c 3e 00 0f 85 31 ff ff ff e9 34 ff ff ff e8 9c ae 29 00 <0f> 0b e9 dc fe ff ff 89 e9 80 e1 07 80 c1 03 38 c1 0f 8c 7d fd ff
RSP: 0018:ffffc9000165f5a0 EFLAGS: 00010293
RAX: ffffffff814b7064 RBX: 0000000000000001 RCX: ffff888021c80000
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: ffff888024039ca0 R08: dffffc0000000000 R09: fffffbfff1dd3e64
R10: fffffbfff1dd3e64 R11: 0000000000000000 R12: 1ffff920002cbebd
R13: ffff888024039c88 R14: 1ffff11004807391 R15: dffffc0000000000
FS: 0000000001347880(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000140 CR3: 000000002cc0a000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
rhashtable_free_and_destroy+0x25/0x9c0 lib/rhashtable.c:1137
mesh_table_free net/mac80211/mesh_pathtbl.c:69 [inline]
mesh_pathtbl_init+0x287/0x2e0 net/mac80211/mesh_pathtbl.c:785
ieee80211_mesh_init_sdata+0x2ee/0x530 net/mac80211/mesh.c:1591
ieee80211_setup_sdata+0x733/0xc40 net/mac80211/iface.c:1569
ieee80211_if_add+0xd5c/0x1cd0 net/mac80211/iface.c:1987
ieee80211_add_iface+0x59/0x130 net/mac80211/cfg.c:125
rdev_add_virtual_intf net/wireless/rdev-ops.h:45 [inline]
nl80211_new_interface+0x563/0xb40 net/wireless/nl80211.c:3855
genl_family_rcv_msg_doit net/netlink/genetlink.c:739 [inline]
genl_family_rcv_msg net/netlink/genetlink.c:783 [inline]
genl_rcv_msg+0xe4e/0x1280 net/netlink/genetlink.c:800
netlink_rcv_skb+0x190/0x3a0 net/netlink/af_netlink.c:2494
genl_rcv+0x24/0x40 net/netlink/genetlink.c:811
netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
netlink_unicast+0x780/0x930 net/netlink/af_netlink.c:1330
netlink_sendmsg+0x9a8/0xd40 net/netlink/af_netlink.c:1919
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg net/socket.c:671 [inline]
____sys_sendmsg+0x519/0x800 net/socket.c:2353
___sys_sendmsg net/socket.c:2407 [inline]
__sys_sendmsg+0x2b1/0x360 net/socket.c:2440
do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Fixes: 60854fd94573 ("mac80211: mesh: convert path table to rhashtable")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Link: https://lore.kernel.org/r/20201204162428.2583119-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2020-12-04 17:34:25 -08:00
2020-08-07 11:33:22 -07:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-02-24 10:36:03 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-08-07 11:33:22 -07:00
2019-06-19 17:09:55 +02:00
2020-08-27 11:23:08 +02:00
2020-05-31 11:27:16 +02:00
2020-09-18 11:36:03 +02:00
2020-10-08 12:26:35 +02:00
2020-09-28 13:53:05 +02:00
2017-11-02 11:10:55 +01:00
2020-02-24 10:35:57 +01:00
2020-02-24 10:35:57 +01:00
2020-07-31 09:24:24 +02:00
2017-11-02 11:10:55 +01:00
2020-03-29 21:25:29 -07:00
2017-11-02 11:10:55 +01:00
2020-09-18 12:02:57 +02:00
2017-11-02 11:10:55 +01:00
2019-07-20 21:40:32 +02:00
2020-09-18 12:16:16 +02:00
2019-06-05 17:37:16 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-05-31 11:27:03 +02:00
2020-07-31 09:24:23 +02:00
2020-09-28 14:09:07 +02:00
2020-10-08 10:40:57 +02:00
2020-12-04 12:45:25 +01:00
2020-06-14 01:57:21 +09:00
2020-09-18 12:02:57 +02:00
2020-02-24 10:35:57 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-08-27 14:12:15 +02:00
2020-10-08 10:40:57 +02:00
2020-09-18 12:13:06 +02:00
2020-12-04 17:34:25 -08:00
2020-09-28 14:36:53 +02:00
2020-09-28 14:36:53 +02:00
2019-06-19 17:09:55 +02:00
2020-08-27 14:12:15 +02:00
2020-05-31 11:26:39 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-10-30 10:22:42 +01:00
2019-06-19 17:09:55 +02:00
2020-09-28 13:18:53 +02:00
2017-11-02 11:10:55 +01:00
2020-10-08 10:40:57 +02:00
2020-04-24 11:30:13 +02:00
2019-10-11 10:31:45 +02:00
2019-10-11 10:31:45 +02:00
2020-05-26 20:17:35 -07:00
2019-10-11 10:31:45 +02:00
2020-11-12 11:25:09 +01:00
2020-11-12 11:24:43 +01:00
2020-09-28 14:01:00 +02:00
2020-10-08 10:40:57 +02:00
2020-09-28 13:53:25 +02:00
2020-05-31 11:26:50 +02:00
2020-11-13 09:48:32 +01:00
2020-10-30 10:06:09 +01:00
2020-11-12 11:23:58 +01:00
2020-07-31 09:24:23 +02:00
2020-01-15 09:52:12 +01:00
2019-07-08 20:57:08 -07:00
2019-03-29 11:20:36 +01:00
2017-11-02 11:10:55 +01:00
2020-09-18 12:16:16 +02:00
2020-10-30 10:03:48 +01:00
2020-12-04 12:35:58 +01:00
2020-09-22 16:45:34 -07:00
2020-02-07 12:40:34 +01:00
2020-02-07 12:40:34 +01:00
2020-07-31 09:24:23 +02:00
2019-06-19 17:09:55 +02:00
2019-07-26 16:14:12 +02:00
2019-06-19 17:09:55 +02:00
905b2032fa