Brian King b42ec774db scsi: ibmvfc: Fix invalid state machine BUG_ON()
[ Upstream commit 15cfef8623a449d40d16541687afd58e78033be3 ]

This fixes an issue hitting the BUG_ON() in ibmvfc_do_work(). When going
through a host action of IBMVFC_HOST_ACTION_RESET, we change the action to
IBMVFC_HOST_ACTION_TGT_DEL, then drop the host lock, and reset the CRQ,
which changes the host state to IBMVFC_NO_CRQ. If, prior to setting the
host state to IBMVFC_NO_CRQ, ibmvfc_init_host() is called, it can then end
up changing the host action to IBMVFC_HOST_ACTION_INIT.  If we then change
the host state to IBMVFC_NO_CRQ, we will then hit the BUG_ON().

Make a couple of changes to avoid this. Leave the host action to be
IBMVFC_HOST_ACTION_RESET or IBMVFC_HOST_ACTION_REENABLE until after we drop
the host lock and reset or reenable the CRQ. Also harden the host state
machine to ensure we cannot leave the reset / reenable state until we've
finished processing the reset or reenable.

Link: https://lore.kernel.org/r/20210413001009.902400-1-tyreld@linux.ibm.com
Fixes: 73ee5d867287 ("[SCSI] ibmvfc: Fix soft lockup on resume")
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
[tyreld: added fixes tag]
Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com>
[mkp: fix comment checkpatch warnings]
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-05-14 09:50:27 +02:00
..
2020-10-14 15:15:35 -07:00
2020-10-23 16:19:02 -07:00
2020-10-14 15:15:35 -07:00
2020-10-23 16:19:02 -07:00
2020-12-02 12:59:04 -05:00
2020-10-14 15:15:35 -07:00
2021-01-06 14:56:51 +01:00
2020-10-16 12:21:15 -07:00
2020-03-11 23:07:59 -04:00
2020-10-14 15:15:35 -07:00
2020-10-23 16:19:02 -07:00
2021-05-14 09:50:27 +02:00
2021-05-11 14:47:31 +02:00
2020-10-23 16:19:02 -07:00
2021-05-11 14:47:27 +02:00
2020-10-23 16:19:02 -07:00
2019-03-02 11:39:54 -08:00
2020-10-23 16:19:02 -07:00
2019-11-12 22:21:35 -05:00
2020-02-24 14:54:25 -05:00
2020-03-11 23:07:59 -04:00
2020-10-07 21:48:28 -04:00
2019-01-08 21:58:35 -05:00
2020-09-02 22:49:06 -04:00
2020-09-02 22:49:06 -04:00
2020-08-23 17:36:59 -05:00
2020-08-06 16:50:07 -07:00
2020-10-13 12:12:44 -07:00
2021-05-14 09:50:27 +02:00
2020-07-24 22:09:55 -04:00
2020-10-14 15:15:35 -07:00
2020-10-23 16:19:02 -07:00
2020-09-15 17:34:18 -04:00
2020-08-23 17:36:59 -05:00
2020-10-14 15:15:35 -07:00
2020-10-14 15:15:35 -07:00
2020-06-19 23:06:43 -04:00
2021-03-04 11:38:22 +01:00
2020-10-14 15:15:35 -07:00
2019-07-11 15:14:01 -07:00
2021-05-14 09:50:27 +02:00
2020-10-23 16:19:02 -07:00
2020-02-24 15:01:57 -05:00
2021-05-14 09:50:27 +02:00
2020-10-14 15:15:35 -07:00
2019-07-11 15:14:01 -07:00