Dongliang Mu
b34cb7ac32
NFC: nci: fix memory leak in nci_allocate_device ...
commit e0652f8bb44d6294eeeac06d703185357f25d50b upstream.
nfcmrvl_disconnect fails to free the hci_dev field in struct nci_dev.
Fix this by freeing hci_dev in nci_free_device.
BUG: memory leak
unreferenced object 0xffff888111ea6800 (size 1024):
comm "kworker/1:0", pid 19, jiffies 4294942308 (age 13.580s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 60 fd 0c 81 88 ff ff .........`......
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<000000004bc25d43>] kmalloc include/linux/slab.h:552 [inline]
[<000000004bc25d43>] kzalloc include/linux/slab.h:682 [inline]
[<000000004bc25d43>] nci_hci_allocate+0x21/0xd0 net/nfc/nci/hci.c:784
[<00000000c59cff92>] nci_allocate_device net/nfc/nci/core.c:1170 [inline]
[<00000000c59cff92>] nci_allocate_device+0x10b/0x160 net/nfc/nci/core.c:1132
[<00000000006e0a8e>] nfcmrvl_nci_register_dev+0x10a/0x1c0 drivers/nfc/nfcmrvl/main.c:153
[<000000004da1b57e>] nfcmrvl_probe+0x223/0x290 drivers/nfc/nfcmrvl/usb.c:345
[<00000000d506aed9>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
[<00000000bc632c92>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
[<00000000f5009125>] driver_probe_device+0x84/0x100 drivers/base/dd.c:740
[<000000000ce658ca>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:846
[<000000007067d05f>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
[<00000000f8e13372>] __device_attach+0x122/0x250 drivers/base/dd.c:914
[<000000009cf68860>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
[<00000000359c965a>] device_add+0x5be/0xc30 drivers/base/core.c:3109
[<00000000086e4bd3>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
[<00000000ca036872>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
[<00000000d40d36f6>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
[<00000000bc632c92>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
Reported-by: syzbot+19bcfc64a8df1318d1c3@syzkaller.appspotmail.com
Fixes: 11f54f228643 ("NFC: nci: Add HCI over NCI protocol support")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-05-28 13:17:43 +02:00
2020-07-15 20:34:11 -07:00
2021-05-14 09:49:55 +02:00
2020-09-29 14:02:53 -07:00
2020-05-19 12:50:14 -07:00
2021-05-14 09:50:40 +02:00
2021-04-14 08:42:05 +02:00
2021-05-28 13:17:43 +02:00
2019-06-05 17:37:07 +02:00
2020-09-20 14:15:12 -07:00
2020-10-15 12:43:21 -07:00
2020-02-28 14:51:30 +01:00
2021-04-14 08:42:05 +02:00
2021-05-14 09:50:44 +02:00
2019-05-30 11:26:41 -07:00
2020-08-20 18:21:28 +01:00
2020-02-28 12:12:53 -08:00
2019-12-11 15:01:23 -08:00
2019-11-06 16:14:48 -08:00
2019-01-23 11:18:00 -08:00
2019-06-19 17:09:55 +02:00
2020-07-21 18:30:47 -07:00
2019-05-24 17:37:53 +02:00
2020-05-01 12:15:37 -07:00
2019-07-04 12:30:48 -07:00
2020-12-08 11:26:08 -08:00
2020-09-25 13:58:01 -07:00
2020-06-20 17:30:59 -07:00
2019-05-21 11:28:45 +02:00
2019-06-19 17:09:55 +02:00
2020-10-30 10:06:09 +01:00
2020-02-29 14:39:08 +01:00
2020-08-20 15:45:15 -04:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2020-07-19 18:16:40 -07:00
2019-05-30 11:29:52 -07:00
2019-05-30 11:29:52 -07:00
2020-10-09 12:06:53 -07:00
2020-02-29 21:52:20 -08:00
2019-05-21 11:52:39 +02:00
2019-05-21 11:52:39 +02:00
2020-10-05 05:56:48 -07:00
2019-12-16 16:09:44 -08:00
2020-05-08 21:33:33 -07:00
2021-03-30 14:32:05 +02:00
2020-05-05 13:23:29 -07:00
2020-02-19 13:52:32 +01:00
2020-04-20 07:34:16 +02:00
2019-06-19 17:09:55 +02:00
2019-12-24 22:37:30 -08:00
2020-07-28 17:42:31 -07:00
2020-07-24 15:23:31 -07:00
2020-08-05 20:13:21 -07:00
2020-09-14 14:54:56 -07:00
2020-07-31 09:24:24 +02:00
2020-07-31 09:24:24 +02:00
2019-12-09 10:36:44 -08:00
2019-11-05 18:20:55 -08:00
2020-10-05 18:40:01 -07:00
2019-03-22 12:09:31 -07:00
2018-12-10 15:53:04 -08:00
2020-06-22 21:12:44 -07:00
2019-10-25 16:24:32 -07:00
2021-03-04 11:38:46 +01:00
2020-07-31 09:27:00 +02:00
2019-05-30 11:26:41 -07:00
2020-05-11 13:18:54 -07:00
2019-04-22 21:50:53 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-03-30 13:45:04 -07:00
2020-05-09 00:48:20 +02:00
2021-03-30 14:31:59 +02:00
2020-12-01 17:16:54 -08:00
2019-08-08 15:55:10 -07:00
2020-11-23 16:32:33 -08:00
2020-08-26 07:33:19 -07:00
2019-09-27 12:05:02 +02:00
2019-02-08 21:50:15 -08:00
2020-06-20 17:47:53 -07:00
2020-07-15 20:34:11 -07:00
2020-05-18 17:35:02 -07:00
2019-06-18 20:48:45 -04:00
2020-05-26 16:06:07 -07:00
2020-11-13 16:58:10 -08:00
2020-08-31 23:06:51 +02:00
2020-10-05 18:40:01 -07:00
2020-11-19 10:49:50 -08:00
2020-08-31 12:26:39 -07:00
2020-11-19 10:49:50 -08:00
2020-02-05 14:28:09 +01:00
2019-06-19 17:09:55 +02:00
2020-06-20 17:22:22 -07:00
2019-10-08 13:23:05 -07:00
2020-03-29 22:30:57 -07:00
2020-10-30 10:06:09 +01:00
2019-05-30 11:26:41 -07:00
2020-03-26 20:17:36 -07:00
2020-03-02 11:16:27 -08:00
2020-02-29 21:52:20 -08:00
2020-02-28 12:08:37 -08:00
2020-05-29 21:20:20 -07:00
2020-09-24 20:17:01 -07:00
2019-12-09 10:36:44 -08:00
2020-08-24 06:40:07 -07:00
2020-11-13 14:24:39 -08:00
2020-09-30 11:50:35 -07:00
2019-05-21 11:28:45 +02:00
2020-10-09 20:22:32 -07:00
2019-11-12 08:18:03 -08:00
2019-04-11 13:59:49 -07:00
2021-03-30 14:31:57 +02:00
2021-05-19 10:13:17 +02:00
2020-03-04 13:25:55 -08:00
2019-05-30 11:26:32 -07:00
2020-07-16 16:48:34 -07:00
2020-10-09 08:08:08 -07:00
2019-05-30 11:26:32 -07:00
2019-09-16 09:18:03 +02:00
2019-05-30 11:26:32 -07:00
2021-04-14 08:42:07 +02:00
2020-07-31 09:24:23 +02:00
2020-08-24 14:35:00 -07:00
2020-03-23 21:57:44 -07:00
2020-06-23 20:27:09 -07:00
2021-03-30 14:32:08 +02:00
2019-04-22 21:47:25 -07:00
2021-02-10 09:29:23 +01:00
2020-07-13 11:03:44 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-06-04 15:39:32 -07:00
2020-09-28 15:19:03 -07:00
2019-10-05 16:29:00 -07:00
2020-02-29 21:52:19 -08:00
2021-04-14 08:42:03 +02:00
2019-06-19 17:09:55 +02:00
2021-02-17 11:02:29 +01:00
2019-05-30 11:26:32 -07:00
2021-03-04 11:37:33 +01:00
2019-05-30 11:26:32 -07:00
2019-10-04 14:07:07 -07:00
2020-11-25 17:31:06 -08:00
2020-06-23 20:10:15 -07:00
2020-06-18 20:46:23 -07:00
2020-09-28 12:50:12 -07:00
2021-02-10 09:29:23 +01:00
2019-11-14 18:12:17 -08:00
2020-09-14 16:49:39 -07:00
2020-07-15 20:34:02 -07:00
2019-12-09 10:28:43 -08:00
2019-11-16 12:39:10 -08:00
2020-08-31 21:15:04 +02:00
2021-01-17 14:17:05 +01:00
2020-12-09 16:27:42 +01:00
2021-04-14 08:42:06 +02:00
2021-01-17 14:17:05 +01:00
b34cb7ac32