iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/btrfs
History
Josef Bacik 7e13db5039 btrfs: do not BUG_ON in link_to_fixup_dir 
[ Upstream commit 91df99a6eb50d5a1bc70fff4a09a0b7ae6aab96d ]

While doing error injection testing I got the following panic

  kernel BUG at fs/btrfs/tree-log.c:1862!
  invalid opcode: 0000 [#1] SMP NOPTI
  CPU: 1 PID: 7836 Comm: mount Not tainted 5.13.0-rc1+ #305
  Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-2.fc32 04/01/2014
  RIP: 0010:link_to_fixup_dir+0xd5/0xe0
  RSP: 0018:ffffb5800180fa30 EFLAGS: 00010216
  RAX: fffffffffffffffb RBX: 00000000fffffffb RCX: ffff8f595287faf0
  RDX: ffffb5800180fa37 RSI: ffff8f5954978800 RDI: 0000000000000000
  RBP: ffff8f5953af9450 R08: 0000000000000019 R09: 0000000000000001
  R10: 000151f408682970 R11: 0000000120021001 R12: ffff8f5954978800
  R13: ffff8f595287faf0 R14: ffff8f5953c77dd0 R15: 0000000000000065
  FS:  00007fc5284c8c40(0000) GS:ffff8f59bbd00000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 00007fc5287f47c0 CR3: 000000011275e002 CR4: 0000000000370ee0
  Call Trace:
   replay_one_buffer+0x409/0x470
   ? btree_read_extent_buffer_pages+0xd0/0x110
   walk_up_log_tree+0x157/0x1e0
   walk_log_tree+0xa6/0x1d0
   btrfs_recover_log_trees+0x1da/0x360
   ? replay_one_extent+0x7b0/0x7b0
   open_ctree+0x1486/0x1720
   btrfs_mount_root.cold+0x12/0xea
   ? __kmalloc_track_caller+0x12f/0x240
   legacy_get_tree+0x24/0x40
   vfs_get_tree+0x22/0xb0
   vfs_kern_mount.part.0+0x71/0xb0
   btrfs_mount+0x10d/0x380
   ? vfs_parse_fs_string+0x4d/0x90
   legacy_get_tree+0x24/0x40
   vfs_get_tree+0x22/0xb0
   path_mount+0x433/0xa10
   __x64_sys_mount+0xe3/0x120
   do_syscall_64+0x3d/0x80
   entry_SYSCALL_64_after_hwframe+0x44/0xae

We can get -EIO or any number of legitimate errors from
btrfs_search_slot(), panicing here is not the appropriate response.  The
error path for this code handles errors properly, simply return the
error.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-06-03 09:00:44 +02:00
..
tests
btrfs: fix missing delalloc new bit for new delalloc ranges
2020-11-13 22:15:59 +01:00
acl.c
btrfs: cleanup btrfs_setxattr_trans and drop transaction parameter
2019-04-29 19:02:44 +02:00
async-thread.c
Btrfs: fix crash during unmount due to race with delayed inode workers
2020-03-23 17:01:51 +01:00
async-thread.h
Btrfs: fix crash during unmount due to race with delayed inode workers
2020-03-23 17:01:51 +01:00
backref.c
btrfs: do not warn if we can't find the reloc root when looking up backref
2021-03-04 11:38:29 +01:00
backref.h
btrfs: add asserts for deleting backref cache nodes
2021-03-04 11:38:29 +01:00
block-group.c
btrfs: fix race between writes to swap files and scrub
2021-03-09 11:11:11 +01:00
block-group.h
btrfs: fix race between writes to swap files and scrub
2021-03-09 11:11:11 +01:00
block-rsv.c
btrfs: print the block rsv type when we fail our reservation
2020-11-05 13:02:05 +01:00
block-rsv.h
btrfs: Remove __ prefix from btrfs_block_rsv_release
2020-03-23 17:01:55 +01:00
btrfs_inode.h
btrfs: fix deadlock when cloning inline extent and low on free metadata space
2021-01-17 14:16:54 +01:00
check-integrity.c
btrfs: check-integrity: remove unnecessary failure messages during memory allocation
2020-07-27 12:55:21 +02:00
check-integrity.h
btrfs: remove btrfsic_submit_bh()
2020-03-23 17:01:39 +01:00
compression.c
btrfs: handle remount to no compress during compression
2021-05-11 14:47:15 +02:00
compression.h
btrfs: compression: move declarations to header
2020-10-07 12:06:55 +02:00
ctree.c
btrfs: fix race when picking most recent mod log operation for an old root
2021-05-11 14:47:33 +02:00
ctree.h
btrfs: fix race between writes to swap files and scrub
2021-03-09 11:11:11 +01:00
delalloc-space.c
btrfs: add btrfs_reserve_data_bytes and use it
2020-10-07 12:06:52 +02:00
delalloc-space.h
btrfs: make btrfs_delalloc_reserve_space take btrfs_inode
2020-07-27 12:55:36 +02:00
delayed-inode.c
btrfs: don't flush from btrfs_delayed_inode_reserve_metadata
2021-03-11 14:17:22 +01:00
delayed-inode.h
btrfs: delayed-inode: Replace zero-length array with flexible-array member
2020-03-23 17:01:53 +01:00
delayed-ref.c
btrfs: account for new extents being deleted in total_bytes_pinned
2021-03-04 11:38:30 +01:00
delayed-ref.h
btrfs: handle space_info::total_bytes_pinned inside the delayed ref itself
2021-03-04 11:38:30 +01:00
dev-replace.c
btrfs: fix deadlock when cloning inline extent and low on free metadata space
2021-01-17 14:16:54 +01:00
dev-replace.h
btrfs: add __pure attribute to functions
2019-11-18 12:46:52 +01:00
dir-item.c
btrfs: remove unused parameter fs_info from btrfs_extend_item
2019-04-29 19:02:50 +02:00
discard.c
btrfs: merge critical sections of discard lock in workfn
2021-01-19 18:27:24 +01:00
discard.h
btrfs: discard: Use the correct style for SPDX License Identifier
2020-04-20 17:43:42 +02:00
disk-io.c
btrfs: print the actual offset in btrfs_root_name
2021-01-27 11:55:06 +01:00
disk-io.h
btrfs: add a helper to read the tree_root commit root for backref lookup
2020-10-26 15:04:57 +01:00
export.c
btrfs: simplify iget helpers
2020-05-25 11:25:37 +02:00
export.h
btrfs: export helpers for subvolume name/id resolution
2020-03-23 17:01:42 +01:00
extent_io.c
btrfs: return whole extents in fiemap
2021-06-03 09:00:43 +02:00
extent_io.h
btrfs: remove struct extent_io_ops
2020-10-07 12:13:25 +02:00
extent_map.c
Btrfs: fix race between using extent maps and merging them
2020-02-12 17:16:46 +01:00
extent_map.h
btrfs: remove extent_map::bdev
2019-11-18 23:43:44 +01:00
extent-io-tree.h
btrfs: remove struct extent_io_ops
2020-10-07 12:13:25 +02:00
extent-tree.c
btrfs: account for new extents being deleted in total_bytes_pinned
2021-03-04 11:38:30 +01:00
file-item.c
btrfs: make btrfs_find_ordered_sum take btrfs_inode
2020-10-07 12:12:19 +02:00
file.c
btrfs: fix race leading to unpersisted data and metadata on fsync
2021-05-19 10:13:11 +02:00
free-space-cache.c
btrfs: fix race between extent freeing/allocation when using bitmaps
2021-03-09 11:11:11 +01:00
free-space-cache.h
btrfs: let btrfs_return_cluster_to_free_space() return void
2020-07-27 12:55:21 +02:00
free-space-tree.c
btrfs: fix possible free space tree corruption with online conversion
2021-02-03 23:28:40 +01:00
free-space-tree.h
btrfs: rename btrfs_block_group_cache
2019-11-18 17:51:51 +01:00
inode-item.c
btrfs: Make btrfs_find_name_in_ext_backref return struct btrfs_inode_extref
2019-09-09 14:59:16 +02:00
inode-map.c
btrfs: make btrfs_delalloc_reserve_space take btrfs_inode
2020-07-27 12:55:36 +02:00
inode-map.h
…
inode.c
btrfs: avoid RCU stalls while running delayed iputs
2021-05-26 12:06:50 +02:00
ioctl.c
btrfs: fix metadata extent leak after failure to create subvolume
2021-05-11 14:47:15 +02:00
Kconfig
btrfs: switch to iomap for direct IO
2020-10-07 12:06:57 +02:00
locking.c
btrfs: add nesting tags to the locking helpers
2020-10-07 12:12:16 +02:00
locking.h
btrfs: introduce BTRFS_NESTING_NEW_ROOT for adding new roots
2020-10-07 12:12:17 +02:00
lzo.c
btrfs: compression: inline free_workspace
2019-11-18 12:46:59 +01:00
Makefile
Btrfs: move all reflink implementation code into its own file
2020-03-23 17:01:54 +01:00
misc.h
btrfs: rename tree_entry to rb_simple_node and export it
2020-05-25 11:25:19 +02:00
ordered-data.c
btrfs: remove inode argument from btrfs_start_ordered_extent
2020-10-07 12:13:22 +02:00
ordered-data.h
btrfs: remove inode argument from btrfs_start_ordered_extent
2020-10-07 12:13:22 +02:00
orphan.c
…
print-tree.c
btrfs: print the actual offset in btrfs_root_name
2021-01-27 11:55:06 +01:00
print-tree.h
btrfs: print the actual offset in btrfs_root_name
2021-01-27 11:55:06 +01:00
props.c
btrfs: simplify iget helpers
2020-05-25 11:25:37 +02:00
props.h
btrfs: delete unused function btrfs_set_prop_trans
2019-04-29 19:02:54 +02:00
qgroup.c
btrfs: fix sleep while in non-sleep context during qgroup removal
2021-03-30 14:31:53 +02:00
qgroup.h
btrfs: export and rename qgroup_reserve_meta
2021-03-11 14:17:22 +01:00
raid56.c
btrfs: fix raid6 qstripe kmap
2021-03-09 11:11:10 +01:00
raid56.h
btrfs: constify map parameter for nr_parity_stripes and nr_data_stripes
2019-07-01 13:34:58 +02:00
rcu-string.h
btrfs: rcu-string: Replace zero-length array with flexible-array member
2020-03-23 17:01:53 +01:00
reada.c
btrfs: fix readahead hang and use-after-free after removing a device
2020-10-26 15:03:59 +01:00
ref-verify.c
btrfs: ref-verify: fix memory leak in btrfs_ref_tree_mod
2020-11-05 13:03:39 +01:00
ref-verify.h
btrfs: ref-verify: Use btrfs_ref to refactor btrfs_ref_tree_mod()
2019-04-29 19:02:49 +02:00
reflink.c
btrfs: release path before starting transaction when cloning inline extent
2021-06-03 09:00:44 +02:00
reflink.h
Btrfs: move all reflink implementation code into its own file
2020-03-23 17:01:54 +01:00
relocation.c
btrfs: convert logic BUG_ON()'s in replace_path to ASSERT()'s
2021-05-11 14:47:22 +02:00
root-tree.c
btrfs: qgroup: fix qgroup meta rsv leak for subvolume operations
2020-10-07 12:12:13 +02:00
scrub.c
btrfs: fix race between writes to swap files and scrub
2021-03-09 11:11:11 +01:00
send.c
btrfs: send: fix invalid clone operations when cloning from the same file and root
2021-01-27 11:54:53 +01:00
send.h
btrfs: send: avoid copying file data
2020-10-07 12:13:17 +02:00
space-info.c
btrfs: shrink delalloc pages instead of full inodes
2021-01-17 14:16:54 +01:00
space-info.h
btrfs: handle space_info::total_bytes_pinned inside the delayed ref itself
2021-03-04 11:38:30 +01:00
struct-funcs.c
btrfs: use unaligned helpers for stack and header set/get helpers
2020-10-07 12:13:23 +02:00
super.c
btrfs: fix transaction leak and crash after RO remount caused by qgroup rescan
2021-01-19 18:27:24 +01:00
sysfs.c
btrfs: do not create raid sysfs entries under any locks
2020-10-07 12:13:19 +02:00
sysfs.h
btrfs: split and refactor btrfs_sysfs_remove_devices_dir
2020-10-07 12:12:21 +02:00
transaction.c
btrfs: fix race between transaction aborts and fsyncs leading to use-after-free
2021-05-11 14:47:15 +02:00
transaction.h
btrfs: dio iomap DSYNC workaround
2020-10-07 12:06:57 +02:00
tree-checker.c
btrfs: tree-checker: check if chunk item end overflows
2021-01-19 18:27:22 +01:00
tree-checker.h
btrfs: get fs_info from eb in btrfs_check_chunk_valid
2019-04-29 19:02:39 +02:00
tree-defrag.c
btrfs: remove unused btrfs_root::defrag_trans_start
2020-07-27 12:55:28 +02:00
tree-log.c
btrfs: do not BUG_ON in link_to_fixup_dir
2021-06-03 09:00:44 +02:00
tree-log.h
btrfs: make fast fsyncs wait only for writeback
2020-10-07 12:06:56 +02:00
ulist.c
…
ulist.h
…
uuid-tree.c
btrfs: simplify root lookup by id
2020-05-25 11:25:36 +02:00
volumes.c
btrfs: fix lockdep warning due to seqcount_mutex on 32bit arch
2021-02-03 23:28:40 +01:00
volumes.h
btrfs: fix lockdep warning due to seqcount_mutex on 32bit arch
2021-02-03 23:28:40 +01:00
xattr.c
btrfs: fix warning when creating a directory with smack enabled
2021-03-09 11:11:12 +01:00
xattr.h
btrfs: cleanup btrfs_setxattr_trans and drop transaction parameter
2019-04-29 19:02:44 +02:00
zlib.c
btrfs: use larger zlib buffer for s390 hardware compression
2020-01-31 10:30:40 -08:00
zstd.c
btrfs: compression: inline free_workspace
2019-11-18 12:46:59 +01:00