linux

iv/linux

History

Jason Ekstrand 0d514185ae dma-buf/sync_file: Don't leak fences on merge failure

commit ffe000217c5068c5da07ccb1c0f8cce7ad767435 upstream.

Each add_fence() call does a dma_fence_get() on the relevant fence.  In
the error path, we weren't calling dma_fence_put() so all those fences
got leaked.  Also, in the krealloc_array failure case, we weren't
freeing the fences array.  Instead, ensure that i and fences are always
zero-initialized and dma_fence_put() all the fences and kfree(fences) on
every error path.

Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Christian König <christian.koenig@amd.com>
Fixes: a02b9dc90d84 ("dma-buf/sync_file: refactor fence storage in struct sync_file")
Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Cc: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210624174732.1754546-1-jason@jlekstrand.net
Signed-off-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2021-07-25 14:36:20 +02:00

heaps

dma-mapping updates for 5.10

2020-10-15 14:43:29 -07:00

dma-buf.c

dmabuf: fix use-after-free of dmabuf's file->f_inode

2021-01-12 20:18:24 +01:00

dma-fence-array.c

dma-fence: Propagate errors to dma-fence-array container

2019-08-12 08:25:52 +01:00

dma-fence-chain.c

dma-buf: fence-chain: Document missing dma_fence_chain_init() parameter in kerneldoc