Zheyu Ma
bcc61adefd
video: fbdev: riva: Error out if 'pixclock' equals zero ...
[ Upstream commit f92763cb0feba247e0939ed137b495601fd072a5 ]
The userspace program could pass any values to the driver through
ioctl() interface. If the driver doesn't check the value of 'pixclock',
it may cause divide error.
Fix this by checking whether 'pixclock' is zero first.
The following log reveals it:
[ 33.396850] divide error: 0000 [#1 ] PREEMPT SMP KASAN PTI
[ 33.396864] CPU: 5 PID: 11754 Comm: i740 Not tainted 5.14.0-rc2-00513-gac532c9bbcfb-dirty #222
[ 33.396883] RIP: 0010:riva_load_video_mode+0x417/0xf70
[ 33.396969] Call Trace:
[ 33.396973] ? debug_smp_processor_id+0x1c/0x20
[ 33.396984] ? tick_nohz_tick_stopped+0x1a/0x90
[ 33.396996] ? rivafb_copyarea+0x3c0/0x3c0
[ 33.397003] ? wake_up_klogd.part.0+0x99/0xd0
[ 33.397014] ? vprintk_emit+0x110/0x4b0
[ 33.397024] ? vprintk_default+0x26/0x30
[ 33.397033] ? vprintk+0x9c/0x1f0
[ 33.397041] ? printk+0xba/0xed
[ 33.397054] ? record_print_text.cold+0x16/0x16
[ 33.397063] ? __kasan_check_read+0x11/0x20
[ 33.397074] ? profile_tick+0xc0/0x100
[ 33.397084] ? __sanitizer_cov_trace_const_cmp4+0x24/0x80
[ 33.397094] ? riva_set_rop_solid+0x2a0/0x2a0
[ 33.397102] rivafb_set_par+0xbe/0x610
[ 33.397111] ? riva_set_rop_solid+0x2a0/0x2a0
[ 33.397119] fb_set_var+0x5bf/0xeb0
[ 33.397127] ? fb_blank+0x1a0/0x1a0
[ 33.397134] ? lock_acquire+0x1ef/0x530
[ 33.397143] ? lock_release+0x810/0x810
[ 33.397151] ? lock_is_held_type+0x100/0x140
[ 33.397159] ? ___might_sleep+0x1ee/0x2d0
[ 33.397170] ? __mutex_lock+0x620/0x1190
[ 33.397180] ? trace_hardirqs_on+0x6a/0x1c0
[ 33.397190] do_fb_ioctl+0x31e/0x700
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1627293835-17441-4-git-send-email-zheyuma97@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-09-18 13:40:22 +02:00
2020-09-18 14:45:44 +02:00
2021-09-15 09:50:48 +02:00
2020-09-08 13:33:10 +02:00
2020-05-06 19:29:10 +02:00
2020-01-30 08:04:01 -08:00
2021-09-18 13:40:22 +02:00
2020-07-16 12:35:15 -07:00
2020-04-08 12:09:15 +02:00
2020-08-23 17:36:59 -05:00
2020-09-14 18:11:40 +02:00
2020-08-23 17:36:59 -05:00
2020-09-08 13:33:05 +02:00
2021-09-18 13:40:22 +02:00
2020-09-08 13:33:15 +02:00
2020-09-14 18:11:40 +02:00
2020-01-06 09:45:59 +01:00
2020-09-14 18:11:40 +02:00
2020-01-03 14:27:43 +01:00
2020-08-23 17:36:59 -05:00
2019-06-19 17:09:55 +02:00
2020-09-30 16:37:39 +02:00
2020-07-10 16:17:20 +02:00
2020-08-23 17:36:59 -05:00
2020-09-08 13:33:20 +02:00
2021-09-18 13:40:22 +02:00
2019-04-01 17:46:55 +02:00
2019-04-01 17:46:55 +02:00
2019-04-01 17:46:55 +02:00
2019-04-01 17:46:55 +02:00
2020-06-09 09:39:13 -07:00
2020-12-30 11:53:13 +01:00
2019-12-05 10:57:53 +02:00
2019-06-03 16:00:08 +02:00
2019-12-05 10:57:53 +02:00
2019-12-05 10:57:53 +02:00
2019-12-05 10:57:53 +02:00
2020-03-09 11:12:19 +01:00
2020-01-30 08:04:01 -08:00
2019-12-05 10:57:53 +02:00
2019-12-05 10:57:53 +02:00
2020-01-15 17:31:50 +01:00
2019-12-05 10:57:53 +02:00
2020-08-23 17:36:59 -05:00
2019-12-05 10:57:53 +02:00
2019-12-05 10:57:53 +02:00
2020-08-30 10:56:12 -07:00
2019-05-30 11:26:32 -07:00
2020-09-08 13:33:16 +02:00
2019-06-19 17:09:55 +02:00
2020-07-10 16:17:28 +02:00
2019-12-05 10:57:53 +02:00
2020-08-20 06:26:22 +02:00
2020-07-20 11:47:29 +02:00
2019-12-05 10:57:53 +02:00
2019-12-05 10:57:53 +02:00
2020-08-23 17:36:59 -05:00
2020-02-19 10:58:22 -08:00
2019-12-05 10:57:53 +02:00
2019-12-05 10:57:53 +02:00
2020-07-20 11:47:29 +02:00
2020-08-23 17:36:59 -05:00
2019-12-05 10:57:53 +02:00
2021-05-26 12:06:57 +02:00
2020-06-09 09:39:13 -07:00
2020-06-17 10:57:41 -07:00
2021-04-07 15:00:11 +02:00
2020-09-08 13:33:17 +02:00
2021-05-26 12:06:54 +02:00
2021-07-14 16:56:15 +02:00
2021-03-04 11:37:36 +01:00
2019-12-05 10:57:53 +02:00
2020-07-20 11:47:29 +02:00
2020-10-15 10:46:16 -07:00
2019-12-05 10:57:53 +02:00
2020-07-20 11:47:29 +02:00
2020-04-12 22:09:35 +02:00
2020-07-10 16:17:24 +02:00
2020-01-03 14:27:49 +01:00
2020-08-23 17:36:59 -05:00
2019-12-05 10:57:53 +02:00
2019-12-05 10:57:53 +02:00
2020-08-23 17:36:59 -05:00
2020-07-16 12:35:15 -07:00
2020-01-30 08:04:01 -08:00
2020-01-30 08:04:01 -08:00
2020-01-30 08:04:01 -08:00
2020-08-04 07:37:23 +02:00
2020-08-05 19:47:22 +02:00
2020-03-18 12:27:03 +01:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2019-08-26 10:02:02 +02:00
2020-06-09 09:39:13 -07:00
2020-04-17 15:50:12 +02:00
2020-08-20 17:48:12 +02:00
2020-08-20 17:48:12 +02:00
2020-08-23 17:36:59 -05:00
2020-09-08 13:33:19 +02:00
2020-08-23 17:36:59 -05:00
2020-04-17 15:50:11 +02:00
2020-01-30 08:04:01 -08:00
2020-08-23 17:36:59 -05:00
2019-06-12 20:28:11 +02:00
2019-12-05 10:57:53 +02:00
2019-12-05 10:57:53 +02:00
2020-08-23 17:36:59 -05:00
2019-04-01 17:46:59 +02:00
2020-09-08 13:33:02 +02:00
2019-12-05 10:57:53 +02:00
2020-09-08 13:33:03 +02:00
2020-09-08 13:33:24 +02:00
2020-10-15 08:12:59 +02:00
2020-08-23 17:36:59 -05:00
2019-12-05 10:57:53 +02:00
2019-12-05 10:57:53 +02:00
2019-12-05 10:57:53 +02:00
2019-12-05 10:57:53 +02:00
2020-08-23 17:36:59 -05:00
2020-09-08 13:33:25 +02:00
2019-12-05 10:57:53 +02:00
2020-01-30 08:04:01 -08:00
2021-03-07 12:34:04 +01:00
2020-06-21 09:58:55 +02:00
2020-05-06 21:04:45 +02:00
2019-05-30 11:26:32 -07:00
2020-04-17 15:50:14 +02:00
2019-12-05 10:57:53 +02:00
2020-09-14 18:11:40 +02:00
2020-04-17 15:50:08 +02:00
2019-06-05 17:36:37 +02:00
2020-09-08 13:33:18 +02:00
2020-05-06 20:22:25 +02:00
2019-06-19 17:09:55 +02:00
2019-06-05 17:36:37 +02:00
2020-03-02 16:32:04 +01:00
2019-06-05 17:36:37 +02:00
2020-08-23 17:36:59 -05:00
2019-12-05 10:57:53 +02:00
bcc61adefd