iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/cpufreq
History
James Morse 3945c48136 cpufreq: schedutil: Destroy mutex before kobject_put() frees the memory 
[ Upstream commit cdef1196608892b9a46caa5f2b64095a7f0be60c ]

Since commit e5c6b312ce3c ("cpufreq: schedutil: Use kobject release()
method to free sugov_tunables") kobject_put() has kfree()d the
attr_set before gov_attr_set_put() returns.

kobject_put() isn't the last user of attr_set in gov_attr_set_put(),
the subsequent mutex_destroy() triggers a use-after-free:
| BUG: KASAN: use-after-free in mutex_is_locked+0x20/0x60
| Read of size 8 at addr ffff000800ca4250 by task cpuhp/2/20
|
| CPU: 2 PID: 20 Comm: cpuhp/2 Not tainted 5.15.0-rc1 #12369
| Hardware name: ARM LTD ARM Juno Development Platform/ARM Juno Development
| Platform, BIOS EDK II Jul 30 2018
| Call trace:
|  dump_backtrace+0x0/0x380
|  show_stack+0x1c/0x30
|  dump_stack_lvl+0x8c/0xb8
|  print_address_description.constprop.0+0x74/0x2b8
|  kasan_report+0x1f4/0x210
|  kasan_check_range+0xfc/0x1a4
|  __kasan_check_read+0x38/0x60
|  mutex_is_locked+0x20/0x60
|  mutex_destroy+0x80/0x100
|  gov_attr_set_put+0xfc/0x150
|  sugov_exit+0x78/0x190
|  cpufreq_offline.isra.0+0x2c0/0x660
|  cpuhp_cpufreq_offline+0x14/0x24
|  cpuhp_invoke_callback+0x430/0x6d0
|  cpuhp_thread_fun+0x1b0/0x624
|  smpboot_thread_fn+0x5e0/0xa6c
|  kthread+0x3a0/0x450
|  ret_from_fork+0x10/0x20

Swap the order of the calls.

Fixes: e5c6b312ce3c ("cpufreq: schedutil: Use kobject release() method to free sugov_tunables")
Cc: 4.7+ <stable@vger.kernel.org> # 4.7+
Signed-off-by: James Morse <james.morse@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-10-06 15:55:46 +02:00
..
acpi-cpufreq.c
cpufreq: ACPI: Set cpuinfo.max_freq directly if max boost is known
2021-03-04 11:38:22 +01:00
amd_freq_sensitivity.c
cpufreq: amd_freq_sensitivity: Mark sometimes used ID structs as __maybe_unused
2020-07-15 15:17:06 +02:00
armada-8k-cpufreq.c
cpufreq: ap806: Add missing MODULE_DEVICE_TABLE
2020-12-30 11:53:37 +01:00
armada-37xx-cpufreq.c
cpufreq: armada-37xx: forbid cpufreq for 1.2 GHz variant
2021-08-26 08:35:41 -04:00
bmips-cpufreq.c
cpufreq: Make cpufreq_generic_init() return void
2019-07-16 10:20:11 +02:00
brcmstb-avs-cpufreq.c
cpufreq: brcmstb-avs-cpufreq: Fix resource leaks in ->remove()
2021-03-04 11:37:24 +01:00
cppc_cpufreq.c
cpufreq: CPPC: Reuse caps variable in few routines
2020-07-30 10:57:47 +05:30
cpufreq_conservative.c
cpufreq: Register governors at core_initcall
2020-07-02 13:03:30 +02:00
cpufreq_governor_attr_set.c
cpufreq: schedutil: Destroy mutex before kobject_put() frees the memory
2021-10-06 15:55:46 +02:00
cpufreq_governor.c
cpufreq: cpufreq_governor: Demote store_sampling_rate() header to standard comment block
2020-07-15 15:17:06 +02:00
cpufreq_governor.h
cpufreq: Introduce governor flags
2020-11-10 18:31:17 +01:00
cpufreq_ondemand.c
cpufreq: Register governors at core_initcall
2020-07-02 13:03:30 +02:00
cpufreq_ondemand.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
cpufreq_performance.c
cpufreq: Introduce CPUFREQ_GOV_STRICT_TARGET
2020-11-10 18:31:17 +01:00
cpufreq_powersave.c
cpufreq: Introduce CPUFREQ_GOV_STRICT_TARGET
2020-11-10 18:31:17 +01:00
cpufreq_stats.c
cpufreq: stats: Fix string format specifier mismatch
2020-10-12 12:32:10 +02:00
cpufreq_userspace.c
cpufreq: Register governors at core_initcall
2020-07-02 13:03:30 +02:00
cpufreq-dt-platdev.c
cpufreq: blocklist Qualcomm sm8150 in cpufreq-dt-platdev
2021-09-03 10:09:26 +02:00
cpufreq-dt.c
Merge branch 'cpufreq/arm/linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm
2020-10-06 12:26:45 +02:00
cpufreq-dt.h
cpufreq: dt: Allow platform specific intermediate callbacks
2020-03-12 15:43:52 +05:30
cpufreq-nforce2.c
cpufreq: Avoid creating excessively large stack frames
2020-01-27 10:33:33 +01:00
cpufreq.c
cpufreq: Make cpufreq_online() call driver->offline() on errors
2021-07-14 16:56:13 +02:00
davinci-cpufreq.c
cpufreq: Replace HTTP links with HTTPS ones
2020-07-13 17:54:37 +02:00
e_powersaver.c
cpufreq: e_powersaver: remove unreachable break
2020-10-27 18:42:54 +01:00
elanfreq.c
cpufreq: Convert to new X86 CPU match macros
2020-03-24 21:31:27 +01:00
freq_table.c
cpufreq: ACPI: Set cpuinfo.max_freq directly if max boost is known
2021-03-04 11:38:22 +01:00
gx-suspmod.c
cpufreq: Avoid creating excessively large stack frames
2020-01-27 10:33:33 +01:00
highbank-cpufreq.c
cpufreq: highbank: Add missing MODULE_DEVICE_TABLE
2020-12-30 11:53:38 +01:00
ia64-acpi-cpufreq.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
imx6q-cpufreq.c
cpufreq: imx6q: Unconditionally call dev_pm_opp_of_remove_table()
2020-09-10 16:36:09 +05:30
imx-cpufreq-dt.c
cpufreq: imx-cpufreq-dt: support i.MX7ULP
2020-04-28 14:26:20 +05:30
intel_pstate.c
cpufreq: intel_pstate: Override parameters if HWP forced by BIOS
2021-09-30 10:11:06 +02:00
Kconfig
cpufreq: Avoid configuring old governors as default with intel_pstate
2020-10-27 18:45:34 +01:00
Kconfig.arm
cpufreq: imx: fix NVMEM_IMX_OCOTP dependency
2020-12-30 11:53:39 +01:00
Kconfig.powerpc
cpufreq: Fix Kconfig indentation
2019-11-29 11:52:02 +01:00
Kconfig.x86
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
kirkwood-cpufreq.c
cpufreq: kirkwood: convert to devm_platform_ioremap_resource
2020-01-07 13:29:58 +05:30
longhaul.c
cpufreq: e_powersaver: remove unreachable break
2020-10-27 18:42:54 +01:00
longhaul.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 166
2019-05-30 11:26:39 -07:00
longrun.c
cpufreq: Convert to new X86 CPU match macros
2020-03-24 21:31:27 +01:00
loongson1-cpufreq.c
cpufreq: loongson1: Add missing MODULE_ALIAS
2020-12-30 11:53:38 +01:00
loongson2_cpufreq.c
mips: loongsoon2ef: remove private clk api
2020-04-16 17:34:23 +02:00
Makefile
Merge branch 'cpufreq/arm/linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm
2020-08-04 12:44:53 +02:00
maple-cpufreq.c
Merge branch 'pm-cpufreq'
2019-07-18 09:49:30 +02:00
mediatek-cpufreq.c
cpufreq: mediatek: Add missing MODULE_DEVICE_TABLE
2020-12-30 11:53:38 +01:00
mvebu-cpufreq.c
cpufreq: mvebu: Remove OPPs using dev_pm_opp_remove()
2018-09-19 14:56:44 -07:00
omap-cpufreq.c
OPP: refactor dev_pm_opp_of_register_em() and update related drivers
2020-06-24 17:16:42 +02:00
p4-clockmod.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
pasemi-cpufreq.c
cpufreq: pasemi: Include header file for {check,restore}_astate prototypes
2020-07-15 15:17:06 +02:00
pcc-cpufreq.c
cpufreq: pcc-cpufreq: Mark sometimes used ID structs as __maybe_unused
2020-07-15 15:17:06 +02:00
pmac32-cpufreq.c
Merge branch 'pm-cpufreq'
2019-07-18 09:49:30 +02:00
pmac64-cpufreq.c
Merge branch 'pm-cpufreq'
2019-07-18 09:49:30 +02:00
powernow-k6.c
cpufreq: Convert to new X86 CPU match macros
2020-03-24 21:31:27 +01:00
powernow-k7.c
cpufreq: Convert to new X86 CPU match macros
2020-03-24 21:31:27 +01:00
powernow-k7.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 166
2019-05-30 11:26:39 -07:00
powernow-k8.c
cpufreq: powernow-k8: pass policy rather than use cpufreq_cpu_get()
2021-01-17 14:17:00 +01:00
powernow-k8.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 347
2019-06-05 17:37:08 +02:00
powernv-cpufreq.c
cpufreq: powernv: Fix init_chip_info initialization in numa=off
2021-09-18 13:40:36 +02:00
ppc_cbe_cpufreq_pervasive.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 153
2019-05-30 11:26:32 -07:00
ppc_cbe_cpufreq_pmi.c
cpufreq: Use per-policy frequency QoS
2019-10-21 02:05:21 +02:00
ppc_cbe_cpufreq.c
cpufreq: powerpc_cbe: Switch to QoS requests for freq limits
2019-08-26 10:02:01 +02:00
ppc_cbe_cpufreq.h
cpufreq: powerpc_cbe: Switch to QoS requests for freq limits
2019-08-26 10:02:01 +02:00
pxa2xx-cpufreq.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
pxa3xx-cpufreq.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
qcom-cpufreq-hw.c
cpufreq: qcom-hw: Fix return value check in qcom_cpufreq_hw_cpu_init()
2021-03-17 17:06:33 +01:00
qcom-cpufreq-nvmem.c
cpufreq: qcom: Add missing MODULE_DEVICE_TABLE
2020-12-30 11:53:38 +01:00
qoriq-cpufreq.c
cpufreq: qoriq: convert to a platform driver
2020-05-07 10:47:27 +05:30
raspberrypi-cpufreq.c
cpufreq: add driver for Raspberry Pi
2019-06-13 08:58:22 +05:30
s3c24xx-cpufreq-debugfs.c
ARM: s3c: remove cpufreq header dependencies
2020-08-20 17:52:05 +02:00
s3c24xx-cpufreq.c
cpufreq: s3c24xx: move low-level clk reg access into platform code
2020-08-20 17:53:22 +02:00
s3c64xx-cpufreq.c
cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init
2019-10-23 08:53:23 +05:30
s3c2410-cpufreq.c
cpufreq: s3c24xx: move low-level clk reg access into platform code
2020-08-20 17:53:22 +02:00
s3c2412-cpufreq.c
cpufreq: s3c24xx: move low-level clk reg access into platform code
2020-08-20 17:53:22 +02:00
s3c2416-cpufreq.c
cpufreq: s3c: fix unbalances of cpufreq policy refcount
2020-01-07 13:31:01 +05:30
s3c2440-cpufreq.c
cpufreq: s3c24xx: move low-level clk reg access into platform code
2020-08-20 17:53:22 +02:00
s5pv210-cpufreq.c
cpufreq: s5pv210: Use dev_err instead of pr_err in probe
2020-09-16 14:12:18 +05:30
sa1100-cpufreq.c
cpufreq: Make cpufreq_generic_init() return void
2019-07-16 10:20:11 +02:00
sa1110-cpufreq.c
Merge branch 'pm-cpufreq'
2019-07-18 09:49:30 +02:00
sc520_freq.c
cpufreq: Convert to new X86 CPU match macros
2020-03-24 21:31:27 +01:00
scmi-cpufreq.c
cpufreq: scmi: Fix build for !CONFIG_COMMON_CLK
2020-11-23 10:15:56 +05:30
scpi-cpufreq.c
cpufreq: scpi: Add missing MODULE_ALIAS
2020-12-30 11:53:38 +01:00
sfi-cpufreq.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235
2019-06-19 17:09:07 +02:00
sh-cpufreq.c
cpufreq: Avoid creating excessively large stack frames
2020-01-27 10:33:33 +01:00
sparc-us2e-cpufreq.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
sparc-us3-cpufreq.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
spear-cpufreq.c
cpufreq: Make cpufreq_generic_init() return void
2019-07-16 10:20:11 +02:00
speedstep-centrino.c
cpufreq: Convert to new X86 CPU match macros
2020-03-24 21:31:27 +01:00
speedstep-ich.c
cpufreq: Convert to new X86 CPU match macros
2020-03-24 21:31:27 +01:00
speedstep-lib.c
cpufreq: speedstep: remove unneeded semicolon
2020-10-28 18:04:07 +01:00
speedstep-lib.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 166
2019-05-30 11:26:39 -07:00
speedstep-smi.c
cpufreq: Convert to new X86 CPU match macros
2020-03-24 21:31:27 +01:00
sti-cpufreq.c
cpufreq: st: Add missing MODULE_DEVICE_TABLE
2020-12-30 11:53:38 +01:00
sun50i-cpufreq-nvmem.c
cpufreq: sun50i: Add missing MODULE_DEVICE_TABLE
2020-12-30 11:53:38 +01:00
tango-cpufreq.c
…
tegra20-cpufreq.c
cpufreq: tegra20: Use generic cpufreq-dt driver (Tegra30 supported now)
2020-05-06 18:59:38 +02:00
tegra124-cpufreq.c
cpufreq: tegra124: Add suspend and resume support
2019-10-29 13:25:29 +01:00
tegra186-cpufreq.c
cpufreq: tegra186: Fix get frequency callback
2020-11-17 10:04:21 +05:30
tegra194-cpufreq.c
cpufreq: replace cpu_logical_map() with read_cpuid_mpir()
2020-08-21 20:17:01 +02:00
ti-cpufreq.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
vexpress-spc-cpufreq.c
cpufreq: vexpress-spc: Add missing MODULE_ALIAS
2020-12-30 11:53:38 +01:00