John Meneghini
00849de10f
scsi: bnx2fc: Flush destroy_work queue before calling bnx2fc_interface_put() ...
commit 847f9ea4c5186fdb7b84297e3eeed9e340e83fce upstream.
The bnx2fc_destroy() functions are removing the interface before calling
destroy_work. This results multiple WARNings from sysfs_remove_group() as
the controller rport device attributes are removed too early.
Replace the fcoe_port's destroy_work queue. It's not needed.
The problem is easily reproducible with the following steps.
Example:
$ dmesg -w &
$ systemctl enable --now fcoe
$ fipvlan -s -c ens2f1
$ fcoeadm -d ens2f1.802
[ 583.464488] host2: libfc: Link down on port (7500a1)
[ 583.472651] bnx2fc: 7500a1 - rport not created Yet!!
[ 583.490468] ------------[ cut here ]------------
[ 583.538725] sysfs group 'power' not found for kobject 'rport-2:0-0'
[ 583.568814] WARNING: CPU: 3 PID: 192 at fs/sysfs/group.c:279 sysfs_remove_group+0x6f/0x80
[ 583.607130] Modules linked in: dm_service_time 8021q garp mrp stp llc bnx2fc cnic uio rpcsec_gss_krb5 auth_rpcgss nfsv4 ...
[ 583.942994] CPU: 3 PID: 192 Comm: kworker/3:2 Kdump: loaded Not tainted 5.14.0-39.el9.x86_64 #1
[ 583.984105] Hardware name: HP ProLiant DL120 G7, BIOS J01 07/01/2013
[ 584.016535] Workqueue: fc_wq_2 fc_rport_final_delete [scsi_transport_fc]
[ 584.050691] RIP: 0010:sysfs_remove_group+0x6f/0x80
[ 584.074725] Code: ff 5b 48 89 ef 5d 41 5c e9 ee c0 ff ff 48 89 ef e8 f6 b8 ff ff eb d1 49 8b 14 24 48 8b 33 48 c7 c7 ...
[ 584.162586] RSP: 0018:ffffb567c15afdc0 EFLAGS: 00010282
[ 584.188225] RAX: 0000000000000000 RBX: ffffffff8eec4220 RCX: 0000000000000000
[ 584.221053] RDX: ffff8c1586ce84c0 RSI: ffff8c1586cd7cc0 RDI: ffff8c1586cd7cc0
[ 584.255089] RBP: 0000000000000000 R08: 0000000000000000 R09: ffffb567c15afc00
[ 584.287954] R10: ffffb567c15afbf8 R11: ffffffff8fbe7f28 R12: ffff8c1486326400
[ 584.322356] R13: ffff8c1486326480 R14: ffff8c1483a4a000 R15: 0000000000000004
[ 584.355379] FS: 0000000000000000(0000) GS:ffff8c1586cc0000(0000) knlGS:0000000000000000
[ 584.394419] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 584.421123] CR2: 00007fe95a6f7840 CR3: 0000000107674002 CR4: 00000000000606e0
[ 584.454888] Call Trace:
[ 584.466108] device_del+0xb2/0x3e0
[ 584.481701] device_unregister+0x13/0x60
[ 584.501306] bsg_unregister_queue+0x5b/0x80
[ 584.522029] bsg_remove_queue+0x1c/0x40
[ 584.541884] fc_rport_final_delete+0xf3/0x1d0 [scsi_transport_fc]
[ 584.573823] process_one_work+0x1e3/0x3b0
[ 584.592396] worker_thread+0x50/0x3b0
[ 584.609256] ? rescuer_thread+0x370/0x370
[ 584.628877] kthread+0x149/0x170
[ 584.643673] ? set_kthread_struct+0x40/0x40
[ 584.662909] ret_from_fork+0x22/0x30
[ 584.680002] ---[ end trace 53575ecefa942ece ]---
Link: https://lore.kernel.org/r/20220115040044.1013475-1-jmeneghi@redhat.com
Fixes: 0cbf32e1681d ("[SCSI] bnx2fc: Avoid calling bnx2fc_if_destroy with unnecessary locks")
Tested-by: Guangwu Zhang <guazhang@redhat.com>
Co-developed-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: John Meneghini <jmeneghi@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-02-01 17:25:43 +01:00
2020-12-30 11:53:02 +01:00
2021-07-25 14:36:16 +02:00
2021-07-25 14:36:16 +02:00
2021-07-20 16:05:39 +02:00
2020-10-14 15:15:35 -07:00
2021-07-20 16:05:58 +02:00
2020-10-23 16:19:02 -07:00
2022-02-01 17:25:43 +01:00
2021-07-20 16:05:41 +02:00
2021-11-18 14:04:18 +01:00
2021-07-20 16:05:41 +02:00
2020-10-16 12:21:15 -07:00
2021-08-26 08:35:37 -04:00
2020-03-11 23:07:59 -04:00
2020-10-14 15:15:35 -07:00
2020-10-23 16:19:02 -07:00
2021-02-07 15:37:14 +01:00
2021-07-25 14:36:16 +02:00
2021-05-14 09:50:27 +02:00
2020-08-23 17:36:59 -05:00
2021-07-25 14:36:16 +02:00
2021-07-25 14:36:16 +02:00
2021-07-25 14:36:16 +02:00
2022-01-27 10:54:22 +01:00
2021-08-26 08:35:36 -04:00
2021-12-01 09:19:04 +01:00
2021-07-25 14:36:16 +02:00
2021-09-18 13:40:14 +02:00
2022-01-27 10:54:04 +01:00
2021-09-18 13:40:14 +02:00
2021-09-18 13:40:14 +02:00
2021-12-14 11:32:38 +01:00
2020-10-23 16:19:02 -07:00
2021-09-18 13:40:14 +02:00
2020-10-07 23:50:03 -04:00
2020-10-23 16:19:02 -07:00
2022-01-27 10:54:06 +01:00
2020-03-25 11:50:48 +01:00
2019-02-25 21:37:25 -05:00
2019-03-02 11:39:54 -08:00
2019-10-23 17:23:44 +02:00
2020-10-23 16:19:02 -07:00
2020-09-25 06:20:43 +02:00
2019-01-08 07:58:37 -05:00
2020-06-09 09:39:13 -07:00
2020-06-09 09:39:13 -07:00
2019-05-21 10:50:45 +02:00
2021-11-26 10:39:10 +01:00
2020-07-08 01:12:53 -04:00
2019-05-21 10:50:45 +02:00
2020-03-26 21:10:53 -04:00
2019-05-21 10:50:45 +02:00
2019-11-12 22:21:34 -05:00
2019-11-12 22:21:35 -05:00
2021-09-18 13:40:35 +02:00
2021-06-03 09:00:43 +02:00
2019-05-21 10:50:45 +02:00
2020-02-24 14:54:25 -05:00
2020-04-01 22:03:04 -04:00
2021-11-18 14:04:15 +01:00
2019-05-24 17:36:45 +02:00
2020-09-01 22:15:47 -04:00
2020-03-11 23:07:59 -04:00
2020-08-23 17:36:59 -05:00
2019-12-19 22:08:51 -05:00
2020-09-02 22:49:07 -04:00
2019-06-18 19:46:18 -04:00
2019-07-30 12:17:28 -04:00
2020-07-08 01:12:44 -04:00
2021-07-14 16:56:40 +02:00
2020-08-23 17:36:59 -05:00
2019-01-08 21:58:35 -05:00
2020-03-17 13:36:10 -04:00
2019-01-08 21:57:42 -05:00
2020-10-07 21:48:28 -04:00
2019-01-08 21:58:35 -05:00
2020-06-09 09:39:13 -07:00
2021-10-27 09:56:56 +02:00
2020-09-02 22:49:06 -04:00
2020-10-29 21:55:21 -04:00
2020-09-02 22:49:06 -04:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2020-08-23 17:36:59 -05:00
2020-10-07 21:48:28 -04:00
2020-08-06 16:50:07 -07:00
2020-07-15 17:26:58 -04:00
2020-07-24 22:32:00 -04:00
2020-06-02 21:23:47 -04:00
2020-10-13 12:12:44 -07:00
2019-05-30 11:26:37 -07:00
2021-05-14 09:50:27 +02:00
2020-07-24 22:09:55 -04:00
2020-06-09 09:39:13 -07:00
2020-10-02 15:27:08 -07:00
2022-01-11 15:25:02 +01:00
2020-06-09 09:39:13 -07:00
2020-10-02 21:52:53 -04:00
2019-11-12 22:21:34 -05:00
2019-07-17 22:39:27 +09:00
2020-10-14 15:15:35 -07:00
2020-08-23 17:36:59 -05:00
2019-05-21 10:50:45 +02:00
2020-06-09 09:39:13 -07:00
2020-10-02 21:42:22 -04:00
2020-03-11 23:07:56 -04:00
2020-10-23 16:19:02 -07:00
2020-01-02 21:57:44 -05:00
2021-03-25 09:04:09 +01:00
2020-01-02 21:57:44 -05:00
2020-08-23 17:36:59 -05:00
2019-05-24 17:36:45 +02:00
2020-08-23 17:36:59 -05:00
2019-06-20 15:37:02 -04:00
2020-09-15 17:34:18 -04:00
2019-05-24 17:39:02 +02:00
2020-09-09 22:40:41 -04:00
2020-03-11 23:07:56 -04:00
2020-08-23 17:36:59 -05:00
2019-05-30 11:26:38 -07:00
2020-09-09 22:37:48 -04:00
2020-01-15 23:09:11 -05:00
2019-03-19 17:11:37 -04:00
2020-10-14 15:15:35 -07:00
2019-02-13 22:07:03 -05:00
2019-06-05 17:37:17 +02:00
2019-05-24 17:36:45 +02:00
2021-12-22 09:30:59 +01:00
2022-01-27 10:54:29 +01:00
2019-05-21 06:16:21 -04:00
2021-06-18 10:00:05 +02:00
2020-07-08 01:16:23 -04:00
2020-10-14 15:15:35 -07:00
2020-08-23 17:36:59 -05:00
2021-11-18 14:03:37 +01:00
2020-07-24 22:09:57 -04:00
2019-12-19 22:08:54 -05:00
2019-05-30 11:26:35 -07:00
2022-01-27 10:54:08 +01:00
2020-10-02 18:53:06 -04:00
2020-02-04 03:05:26 +00:00
2021-08-26 08:35:37 -04:00
2019-05-30 11:29:53 -07:00
2021-12-01 09:19:05 +01:00
2020-03-16 22:08:36 -04:00
2020-09-02 22:49:07 -04:00
2021-12-08 09:03:19 +01:00
2021-07-20 16:05:40 +02:00
2021-01-12 20:18:15 +01:00
2021-04-21 13:00:52 +02:00
2021-11-06 14:10:08 +01:00
2020-03-24 07:57:08 -06:00
2019-06-05 17:37:14 +02:00
2021-09-30 10:11:01 +02:00
2021-10-09 14:40:56 +02:00
2020-10-14 15:15:35 -07:00
2020-09-15 20:28:06 -04:00
2021-10-17 10:43:33 +02:00
2020-10-03 00:02:13 -04:00
2020-09-25 06:20:44 +02:00
2019-05-24 17:36:45 +02:00
2021-05-14 09:50:27 +02:00
2022-01-27 10:54:23 +01:00
2022-01-27 10:54:23 +01:00
2020-02-24 15:01:57 -05:00
2021-04-07 15:00:05 +02:00
2020-03-11 23:07:56 -04:00
2021-07-20 16:05:43 +02:00
2020-08-23 17:36:59 -05:00
2021-05-14 09:50:27 +02:00
2020-10-02 21:52:55 -04:00
2021-10-17 10:43:33 +02:00
2022-01-05 12:40:33 +01:00
2020-08-23 17:36:59 -05:00
2019-05-24 17:39:02 +02:00
2019-07-11 15:14:01 -07:00
2020-08-23 17:36:59 -05:00
2020-01-06 09:45:59 +01:00
2019-05-21 10:50:45 +02:00
2020-06-09 09:39:13 -07:00
00849de10f