Florian Westphal
2662c5b1f0
netfilter: tproxy: fix deadlock due to missing BH disable ...
[ Upstream commit 4a02426787bf024dafdb79b362285ee325de3f5e ]
The xtables packet traverser performs an unconditional local_bh_disable(),
but the nf_tables evaluation loop does not.
Functions that are called from either xtables or nftables must assume
that they can be called in process context.
inet_twsk_deschedule_put() assumes that no softirq interrupt can occur.
If tproxy is used from nf_tables its possible that we'll deadlock
trying to aquire a lock already held in process context.
Add a small helper that takes care of this and use it.
Link: https://lore.kernel.org/netfilter-devel/401bd6ed-314a-a196-1cdc-e13c720cc8f2@balasys.hu/
Fixes: 4ed8eb6570a4 ("netfilter: nf_tables: Add native tproxy support")
Reported-and-tested-by: Major Dávid <major.david@balasys.hu>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-03-17 08:48:55 +01:00
2022-08-17 14:24:07 +02:00
2022-08-03 12:03:40 +02:00
2021-07-01 13:19:48 -07:00
2021-01-28 20:36:21 -08:00
2023-03-17 08:48:55 +01:00
2022-07-29 17:25:11 +02:00
2021-11-25 09:48:40 +01:00
2019-06-05 17:37:07 +02:00
2023-03-11 13:57:28 +01:00
2023-03-11 13:57:29 +01:00
2020-02-28 14:51:30 +01:00
2021-08-02 10:24:38 +01:00
2022-08-03 12:03:47 +02:00
2019-05-30 11:26:41 -07:00
2021-04-23 10:17:26 +01:00
2021-08-16 18:43:39 -07:00
2022-03-23 09:16:41 +01:00
2022-04-13 20:59:05 +02:00
2022-04-20 09:34:22 +02:00
2021-08-03 13:05:25 +01:00
2020-07-21 18:30:47 -07:00
2022-09-28 11:11:48 +02:00
2021-12-14 10:57:09 +01:00
2021-08-03 11:50:22 +01:00
2022-09-28 11:11:48 +02:00
2021-03-26 17:43:55 +01:00
2022-08-31 17:16:43 +02:00
2019-05-21 11:28:45 +02:00
2019-06-19 17:09:55 +02:00
2021-10-25 15:20:22 +02:00
2020-02-29 14:39:08 +01:00
2022-03-02 11:47:58 +01:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2021-08-05 11:46:42 +01:00
2019-05-30 11:29:52 -07:00
2019-05-30 11:29:52 -07:00
2021-08-14 13:59:10 +01:00
2021-07-30 15:33:24 +02:00
2019-05-21 11:52:39 +02:00
2019-05-21 11:52:39 +02:00
2022-03-16 14:23:47 +01:00
2019-12-16 16:09:44 -08:00
2021-12-08 09:04:46 +01:00
2022-02-16 12:56:30 +01:00
2020-05-08 21:33:33 -07:00
2022-12-31 13:14:42 +01:00
2020-05-05 13:23:29 -07:00
2022-04-27 14:38:52 +02:00
2020-04-20 07:34:16 +02:00
2019-06-19 17:09:55 +02:00
2019-12-24 22:37:30 -08:00
2021-12-08 09:04:43 +01:00
2022-04-20 09:34:09 +02:00
2022-06-14 18:36:17 +02:00
2021-09-02 11:44:19 +01:00
2021-01-21 13:33:45 +01:00
2021-01-21 13:33:45 +01:00
2019-12-09 10:36:44 -08:00
2019-11-05 18:20:55 -08:00
2021-02-12 16:31:46 -08:00
2019-03-22 12:09:31 -07:00
2021-01-29 20:39:14 -08:00
2021-03-18 19:51:12 -07:00
2020-06-22 21:12:44 -07:00
2019-10-25 16:24:32 -07:00
2021-06-28 14:29:45 -07:00
2021-08-13 09:58:25 +02:00
2022-10-26 12:35:54 +02:00
2022-06-09 10:22:31 +02:00
2019-04-22 21:50:53 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2022-08-17 14:23:36 +02:00
2021-01-27 18:18:15 -08:00
2022-08-03 12:03:45 +02:00
2020-12-14 18:38:58 -08:00
2022-01-27 11:05:35 +01:00
2022-08-17 14:23:36 +02:00
2022-08-17 14:23:36 +02:00
2019-09-27 12:05:02 +02:00
2021-07-21 08:14:33 -07:00
2020-06-20 17:47:53 -07:00
2022-02-23 12:03:10 +01:00
2021-08-05 15:08:47 -07:00
2022-05-09 09:14:36 +02:00
2021-12-08 09:04:49 +01:00
2022-05-09 09:14:36 +02:00
2021-02-04 18:37:57 -08:00
2022-11-26 09:24:49 +01:00
2022-01-27 11:05:35 +01:00
2021-12-01 09:04:49 +01:00
2022-11-26 09:24:49 +01:00
2019-06-19 17:09:55 +02:00
2020-06-20 17:22:22 -07:00
2021-03-23 14:14:50 -07:00
2019-10-08 13:23:05 -07:00
2021-07-27 13:05:56 +01:00
2021-11-18 19:17:10 +01:00
2021-08-30 01:51:36 +02:00
2021-09-27 12:02:54 +02:00
2019-05-30 11:26:41 -07:00
2021-06-24 12:41:12 -07:00
2021-10-18 13:47:09 +01:00
2021-08-25 11:23:14 +01:00
2020-03-02 11:16:27 -08:00
2021-03-26 15:14:56 -07:00
2020-02-28 12:08:37 -08:00
2020-05-29 21:20:20 -07:00
2023-01-12 11:58:52 +01:00
2022-12-31 13:14:42 +01:00
2022-03-08 19:12:33 +01:00
2021-11-18 19:17:16 +01:00
2022-04-13 20:59:03 +02:00
2019-05-21 11:28:45 +02:00
2021-07-27 11:43:50 +01:00
2019-11-12 08:18:03 -08:00
2019-04-11 13:59:49 -07:00
2021-09-24 14:07:10 +01:00
2021-12-01 09:04:46 +01:00
2021-08-09 15:49:00 -07:00
2020-03-04 13:25:55 -08:00
2019-05-30 11:26:32 -07:00
2021-08-30 16:33:59 -07:00
2022-01-27 11:04:02 +01:00
2022-11-10 18:15:38 +01:00
2021-08-09 15:34:21 -07:00
2022-07-21 21:24:27 +02:00
2021-03-25 17:40:43 -07:00
2020-07-31 09:24:23 +02:00
2020-08-24 14:35:00 -07:00
2022-07-29 17:25:09 +02:00
2020-06-23 20:27:09 -07:00
2021-08-04 10:01:26 +01:00
2019-04-22 21:47:25 -07:00
2023-02-01 08:27:09 +01:00
2020-07-13 11:03:44 -07:00
2022-05-18 10:26:53 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2022-01-27 11:05:05 +01:00
2021-04-28 14:06:45 -07:00
2020-09-28 15:19:03 -07:00
2019-10-05 16:29:00 -07:00
2022-12-31 13:14:07 +01:00
2023-03-10 09:39:15 +01:00
2021-08-03 13:05:26 +01:00
2021-11-18 19:17:11 +01:00
2021-08-04 12:35:07 +01:00
2019-05-30 11:26:32 -07:00
2022-12-31 13:14:14 +01:00
2019-05-30 11:26:32 -07:00
2019-10-04 14:07:07 -07:00
2022-07-21 21:24:31 +02:00
2020-06-23 20:10:15 -07:00
2020-06-18 20:46:23 -07:00
2022-09-15 11:30:05 +02:00
2022-11-10 18:15:38 +01:00
2019-11-14 18:12:17 -08:00
2020-09-14 16:49:39 -07:00
2019-12-09 10:28:43 -08:00
2019-11-16 12:39:10 -08:00
2022-06-14 18:36:18 +02:00
2021-06-24 19:41:15 +02:00
2021-07-07 19:51:12 -07:00
2022-09-23 14:15:51 +02:00
2022-10-12 09:53:26 +02:00
2662c5b1f0