iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/md
History
Song Liu 3400aa7eda md/raid1: fix missing bitmap update w/o WriteMostly devices 
commit 46669e8616c649c71c4cfcd712fd3d107e771380 upstream.

commit [1] causes missing bitmap updates when there isn't any WriteMostly
devices.

Detailed steps to reproduce by Norbert (which somehow didn't make to lore):

   # setup md10 (raid1) with two drives (1 GByte sparse files)
   dd if=/dev/zero of=disk1 bs=1024k seek=1024 count=0
   dd if=/dev/zero of=disk2 bs=1024k seek=1024 count=0

   losetup /dev/loop11 disk1
   losetup /dev/loop12 disk2

   mdadm --create /dev/md10 --level=1 --raid-devices=2 /dev/loop11 /dev/loop12

   # add bitmap (aka write-intent log)
   mdadm /dev/md10 --grow --bitmap=internal

   echo check > /sys/block/md10/md/sync_action

   root:# cat /sys/block/md10/md/mismatch_cnt
   0
   root:#

   # remove member drive disk2 (loop12)
   mdadm /dev/md10 -f loop12 ; mdadm /dev/md10 -r loop12

   # modify degraded md device
   dd if=/dev/urandom of=/dev/md10 bs=512 count=1

   # no blocks recorded as out of sync on the remaining member disk1/loop11
   root:# mdadm -X /dev/loop11 | grep Bitmap
             Bitmap : 16 bits (chunks), 0 dirty (0.0%)
   root:#

   # re-add disk2, nothing synced because of empty bitmap
   mdadm /dev/md10 --re-add /dev/loop12

   # check integrity again
   echo check > /sys/block/md10/md/sync_action

   # disk1 and disk2 are no longer in sync, reads return differend data
   root:# cat /sys/block/md10/md/mismatch_cnt
   128
   root:#

   # clean up
   mdadm -S /dev/md10
   losetup -d /dev/loop11
   losetup -d /dev/loop12
   rm disk1 disk2

Fix this by moving the WriteMostly check to the if condition for
alloc_behind_master_bio().

[1] commit fd3b6975e9c1 ("md/raid1: only allocate write behind bio for WriteMostly device")
Fixes: fd3b6975e9c1 ("md/raid1: only allocate write behind bio for WriteMostly device")
Cc: stable@vger.kernel.org # v5.12+
Cc: Guoqing Jiang <guoqing.jiang@linux.dev>
Cc: Jens Axboe <axboe@kernel.dk>
Reported-by: Norbert Warmuth <nwarmuth@t-online.de>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Song Liu <song@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-01-11 15:35:15 +01:00
..
bcache
bcache: Revert "bcache: use bvec_virt"
2021-11-18 19:17:17 +01:00
persistent-data
dm btree remove: fix use after free in rebalance_children()
2021-12-22 09:32:36 +01:00
dm-bio-prison-v1.c
…
dm-bio-prison-v1.h
…
dm-bio-prison-v2.c
…
dm-bio-prison-v2.h
…
dm-bio-record.h
block: store a block_device pointer in struct bio
2021-01-24 18:17:20 -07:00
dm-bufio.c
dm bufio: subtract the number of initial sectors in dm_bufio_get_device_size
2021-03-04 14:53:54 -05:00
dm-builtin.c
…
dm-cache-background-tracker.c
…
dm-cache-background-tracker.h
…
dm-cache-block-types.h
…
dm-cache-metadata.c
dm: use bdev_read_only to check if a device is read-only
2021-01-24 18:15:57 -07:00
dm-cache-metadata.h
…
dm-cache-policy-internal.h
…
dm-cache-policy-smq.c
…
dm-cache-policy.c
…
dm-cache-policy.h
…
dm-cache-target.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-clone-metadata.c
dm clone metadata: remove unused function
2021-04-19 13:20:31 -04:00
dm-clone-metadata.h
dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()
2020-03-27 14:42:51 -04:00
dm-clone-target.c
dm clone: make array 'descs' static
2021-10-12 13:54:10 -04:00
dm-core.h
dm ima: measure data on table load
2021-08-10 13:32:40 -04:00
dm-crypt.c
dm crypt: use in_hardirq() instead of deprecated in_irq()
2021-08-20 16:25:07 -04:00
dm-delay.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-dust.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-ebs-target.c
- Add DM infrastructure for IMA-based remote attestion. These changes
2021-08-31 14:55:09 -07:00
dm-era-target.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-exception-store.c
…
dm-exception-store.h
…
dm-flakey.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-ima.c
integrity-v5.15
2021-09-02 12:51:41 -07:00
dm-ima.h
dm ima: add version info to dm related events in ima log
2021-08-20 15:59:47 -04:00
dm-init.c
dm init: Set file local variable static
2020-08-04 15:51:28 -04:00
dm-integrity.c
- Add DM infrastructure for IMA-based remote attestion. These changes
2021-08-31 14:55:09 -07:00
dm-io-tracker.h
dm writecache: make writeback pause configurable
2021-06-28 16:30:13 -04:00
dm-io.c
block: Add bio_max_segs
2021-02-26 15:49:51 -07:00
dm-ioctl.c
dm ima: measure data on device rename
2021-08-10 13:34:23 -04:00
dm-kcopyd.c
dm writecache: have ssd writeback wait if the kcopyd workqueue is busy
2021-06-15 15:42:03 -04:00
dm-linear.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-log-userspace-base.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-log-userspace-transfer.c
…
dm-log-userspace-transfer.h
…
dm-log-writes.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-log.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-mpath.c
dm ima: update dm target attributes for ima measurements
2021-08-20 16:07:36 -04:00
dm-mpath.h
…
dm-path-selector.c
…
dm-path-selector.h
dm mpath: pass IO start time to path selector
2020-05-15 10:29:36 -04:00
dm-ps-historical-service-time.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-ps-io-affinity.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-ps-queue-length.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-ps-round-robin.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-ps-service-time.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-raid1.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-raid.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-region-hash.c
…
dm-rq.c
dm rq: don't queue request to blk-mq during DM suspend
2021-10-12 13:54:10 -04:00
dm-rq.h
…
dm-snap-persistent.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-snap-transient.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-snap.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-stats.c
dm: replace zero-length array with flexible-array
2020-05-20 17:09:44 -04:00
dm-stats.h
…
dm-stripe.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-switch.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-sysfs.c
…
dm-table.c
libnvdimm for v5.15
2021-09-09 11:39:57 -07:00
dm-target.c
…
dm-thin-metadata.c
dm space maps: improve performance with inc/dec on ranges of blocks
2021-06-04 12:07:22 -04:00
dm-thin-metadata.h
…
dm-thin.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-uevent.c
…
dm-uevent.h
…
dm-unstripe.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-verity-fec.c
dm verity fec: fix misaligned RS roots IO
2021-04-14 14:28:29 -04:00
dm-verity-fec.h
dm verity fec: fix misaligned RS roots IO
2021-04-14 14:28:29 -04:00
dm-verity-target.c
dm verity: skip redundant verity_handle_err() on I/O errors
2021-10-12 13:54:09 -04:00
dm-verity-verify-sig.c
dm verity: fix require_signatures module_param permissions
2021-05-25 16:14:05 -04:00
dm-verity-verify-sig.h
dm verity: Fix compilation warning
2020-08-04 15:48:13 -04:00
dm-verity.h
dm verity: add "panic_on_corruption" error handling mode
2020-07-13 11:47:33 -04:00
dm-writecache.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-zero.c
dm: add support for REQ_NOWAIT to various targets
2020-12-04 18:04:35 -05:00
dm-zone.c
dm zone: fix dm_revalidate_zones() memory allocation
2021-06-25 15:25:23 -04:00
dm-zoned-metadata.c
dm zoned: check zone capacity
2021-06-04 12:07:28 -04:00
dm-zoned-reclaim.c
dm kcopyd: avoid useless atomic operations
2021-06-04 12:07:24 -04:00
dm-zoned-target.c
dm: update target status functions to support IMA measurement
2021-08-10 13:34:23 -04:00
dm-zoned.h
dm zoned: select reclaim zone based on device index
2020-06-05 14:59:53 -04:00
dm.c
dm: fix mempool NULL pointer race when completing IO
2021-10-12 13:54:10 -04:00
dm.h
dm: introduce zone append emulation
2021-06-04 12:07:37 -04:00
Kconfig
dm: make EBS depend on !HIGHMEM
2021-08-16 10:50:32 -06:00
Makefile
dm ima: measure data on table load
2021-08-10 13:32:40 -04:00
md-autodetect.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
md-bitmap.c
md: Constify attribute_group structs
2021-06-14 22:32:07 -07:00
md-bitmap.h
…
md-cluster.c
for-5.11/drivers-2020-12-14
2020-12-16 13:09:32 -08:00
md-cluster.h
…
md-faulty.c
md: mark some personalities as deprecated
2021-06-14 22:32:07 -07:00
md-linear.c
md: mark some personalities as deprecated
2021-06-14 22:32:07 -07:00
md-linear.h
md/raid1: Replace zero-length array with flexible-array
2020-05-13 12:02:23 -07:00
md-multipath.c
md: mark some personalities as deprecated
2021-06-14 22:32:07 -07:00
md-multipath.h
…
md.c
md: fix update super 1.0 on rdev size change
2021-12-14 10:57:14 +01:00
md.h
block: remove GENHD_FL_UP
2021-08-12 10:29:36 -06:00
raid0.c
md: add io accounting for raid0 and raid5
2021-06-14 22:32:06 -07:00
raid0.h
…
raid1-10.c
…
raid1.c
md/raid1: fix missing bitmap update w/o WriteMostly devices
2022-01-11 15:35:15 +01:00
raid1.h
md/raid1: enable io accounting
2021-06-14 22:32:07 -07:00
raid5-cache.c
block: rename BIO_MAX_PAGES to BIO_MAX_VECS
2021-03-11 07:47:48 -07:00
raid5-log.h
…
raid5-ppl.c
block: rename BIO_MAX_PAGES to BIO_MAX_VECS
2021-03-11 07:47:48 -07:00
raid5.c
md/raid5: Replace deprecated CPU-hotplug functions.
2021-08-28 01:46:17 +02:00
raid5.h
md/raid5: let multiple devices of stripe_head share page
2020-09-24 16:44:44 -07:00
raid10.c
for-5.15/drivers-2021-08-30
2021-08-30 19:01:46 -07:00
raid10.h
md/raid10: enable io accounting
2021-06-14 22:32:07 -07:00