Dan Carpenter 6ad7f52d8c ceph: fix type promotion bug on 32bit systems
commit 07bb00ef00ace88dd6f695fadbba76565756e55c upstream.

In this code "ret" is type long and "src_objlen" is unsigned int.  The
problem is that on 32bit systems, when we do the comparison signed longs
are type promoted to unsigned int.  So negative error codes from
do_splice_direct() are treated as success instead of failure.

Cc: stable@vger.kernel.org
Fixes: 1b0c3b9f91f0 ("ceph: re-org copy_file_range and fix some error paths")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-10-19 23:05:36 +02:00
..
2021-06-29 00:15:51 +02:00
2020-06-01 13:22:51 +02:00
2021-06-29 00:15:51 +02:00
2021-06-29 00:15:52 +02:00
2021-09-02 22:49:16 +02:00
2023-08-11 15:13:56 +02:00