iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/ata
History
Niklas Cassel 5dde5f8b79 ata: libata-core: Fix double free on error 
commit ab9e0c529eb7cafebdd31fe1644524e80a48b05d upstream.

If e.g. the ata_port_alloc() call in ata_host_alloc() fails, we will jump
to the err_out label, which will call devres_release_group().
devres_release_group() will trigger a call to ata_host_release().
ata_host_release() calls kfree(host), so executing the kfree(host) in
ata_host_alloc() will lead to a double free:

kernel BUG at mm/slub.c:553!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
CPU: 11 PID: 599 Comm: (udev-worker) Not tainted 6.10.0-rc5 #47
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-2.fc40 04/01/2014
RIP: 0010:kfree+0x2cf/0x2f0
Code: 5d 41 5e 41 5f 5d e9 80 d6 ff ff 4d 89 f1 41 b8 01 00 00 00 48 89 d9 48 89 da
RSP: 0018:ffffc90000f377f0 EFLAGS: 00010246
RAX: ffff888112b1f2c0 RBX: ffff888112b1f2c0 RCX: ffff888112b1f320
RDX: 000000000000400b RSI: ffffffffc02c9de5 RDI: ffff888112b1f2c0
RBP: ffffc90000f37830 R08: 0000000000000000 R09: 0000000000000000
R10: ffffc90000f37610 R11: 617461203a736b6e R12: ffffea00044ac780
R13: ffff888100046400 R14: ffffffffc02c9de5 R15: 0000000000000006
FS:  00007f2f1cabe980(0000) GS:ffff88813b380000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2f1c3acf75 CR3: 0000000111724000 CR4: 0000000000750ef0
PKRU: 55555554
Call Trace:
 <TASK>
 ? __die_body.cold+0x19/0x27
 ? die+0x2e/0x50
 ? do_trap+0xca/0x110
 ? do_error_trap+0x6a/0x90
 ? kfree+0x2cf/0x2f0
 ? exc_invalid_op+0x50/0x70
 ? kfree+0x2cf/0x2f0
 ? asm_exc_invalid_op+0x1a/0x20
 ? ata_host_alloc+0xf5/0x120 [libata]
 ? ata_host_alloc+0xf5/0x120 [libata]
 ? kfree+0x2cf/0x2f0
 ata_host_alloc+0xf5/0x120 [libata]
 ata_host_alloc_pinfo+0x14/0xa0 [libata]
 ahci_init_one+0x6c9/0xd20 [ahci]

Ensure that we will not call kfree(host) twice, by performing the kfree()
only if the devres_open_group() call failed.

Fixes: dafd6c496381 ("libata: ensure host is free'd on error exit paths")
Cc: stable@vger.kernel.org
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20240629124210.181537-9-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-07-05 09:14:49 +02:00
..
acard-ahci.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
ahci_brcm.c
ata: libata: Rename link flag ATA_LFLAG_NO_DB_DELAY
2023-10-06 13:18:11 +02:00
ahci_ceva.c
ata: ahci_ceva: fix error handling for Xilinx GT PHY support
2024-03-01 13:21:58 +01:00
ahci_da850.c
ata: libahci_platform: Convert to using devm bulk clocks API
2024-03-01 13:21:58 +01:00
ahci_dm816.c
ata: libahci_platform: Convert to using devm bulk clocks API
2024-03-01 13:21:58 +01:00
ahci_imx.c
ata: ahci-imx: Fix MODULE_ALIAS
2022-10-29 10:12:54 +02:00
ahci_mtk.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
ahci_mvebu.c
ata: ahci: mvebu: Make SATA PHY optional for Armada 3720
2020-10-09 12:47:56 -06:00
ahci_octeon.c
…
ahci_platform.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
ahci_qoriq.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
ahci_seattle.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235
2019-06-19 17:09:07 +02:00
ahci_st.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
ahci_sunxi.c
ata: ahci_sunxi: Disable DIPM
2021-06-14 08:26:54 -06:00
ahci_tegra.c
ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present
2021-04-11 20:35:08 -06:00
ahci_xgene.c
ata: ahci: Drop pointless VPRINTK() calls and convert the remaining ones
2023-10-06 13:18:01 +02:00
ahci.c
ata: ahci: Clean up sysfs file on error
2024-07-05 09:14:49 +02:00
ahci.h
ata: libahci_platform: Introduce reset assertion/deassertion methods
2024-03-01 13:21:58 +01:00
ata_generic.c
ata: ata_generic: Fix misspelling of 'ata_generic_init_one()'
2021-03-30 20:21:26 -06:00
ata_piix.c
ata_piix: remove open-coded dmi_match(DMI_OEM_STRING)
2019-11-06 20:34:25 -07:00
Kconfig
ARM: SoC changes for 5.14
2021-07-10 09:22:44 -07:00
libahci_platform.c
ata: libahci_platform: Introduce reset assertion/deassertion methods
2024-03-01 13:21:58 +01:00
libahci.c
ata: libahci: clear pending interrupt status
2023-10-06 13:18:01 +02:00
libata-acpi.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
libata-core.c
ata: libata-core: Fix double free on error
2024-07-05 09:14:49 +02:00
libata-eh.c
ata: libata-eh: Fix compilation warning in ata_eh_link_report()
2023-10-25 11:59:00 +02:00
libata-pata-timings.c
ata: separate PATA timings code from libata-core.c
2020-03-26 10:28:19 -06:00
libata-pmp.c
ata: libata-pmp: Fix misspelling of 'val'
2021-03-12 07:28:30 -07:00
libata-sata.c
ata: libata: Rename link flag ATA_LFLAG_NO_DB_DELAY
2023-10-06 13:18:11 +02:00
libata-scsi.c
ata: libata-scsi: ignore reserved bits for REPORT SUPPORTED OPERATION CODES
2023-10-06 13:18:22 +02:00
libata-sff.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
libata-trace.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
libata-transport.c
ata: libata-core: Do not register PM operations for SAS ports
2023-10-06 13:18:24 +02:00
libata-transport.h
…
libata-zpodd.c
libata: zpodd: Fix small read overflow in zpodd_get_mech_type()
2019-07-29 16:00:14 -06:00
libata.h
ata: libata-core: Do not register PM operations for SAS ports
2023-10-06 13:18:24 +02:00
Makefile
ata: start separating SATA specific code from libata-core.c
2020-03-26 10:28:19 -06:00
pata_acpi.c
ata: pata_acpi: Fix some incorrect function param descriptions
2021-03-30 20:21:26 -06:00
pata_ali.c
ata: pata_ali: Supply description for 'ali_20_filter()'s 'mask' param
2021-03-12 07:28:30 -07:00
pata_amd.c
ata: pata_amd: Fix incorrectly named function in the header
2021-03-12 07:28:30 -07:00
pata_arasan_cf.c
ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer()
2023-09-19 12:22:28 +02:00
pata_artop.c
ata: pata_artop: Repair possible copy/paste issue in 'artop_6210_qc_defer()'s header
2021-03-12 07:28:30 -07:00
pata_atiixp.c
ata: pata_atiixp: Avoid overwriting initialised field in 'atiixp_sht'
2021-06-16 06:50:25 -06:00
pata_atp867x.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
pata_bk3710.c
…
pata_buddha.c
ata/pata_buddha: Probe via modalias instead of initcall
2019-08-23 06:58:50 -06:00
pata_cmd64x.c
pata_cmd64x: Use fallthrough pseudo-keyword
2020-10-02 17:51:30 -06:00
pata_cmd640.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_cs5520.c
ata: pata_cs5520: Avoid overwriting initialised field in 'cs5520_sht'
2021-06-16 06:50:25 -06:00
pata_cs5530.c
ata: pata_cs5530: Avoid overwriting initialised field in 'cs5530_sht'
2021-06-16 06:50:25 -06:00
pata_cs5535.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_cs5536.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_cypress.c
pata_cypress: add a module option to disable BM-DMA
2021-06-16 08:52:38 -06:00
pata_efar.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_ep93xx.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
pata_falcon.c
ata: pata_falcon: fix IO base selection for Q40
2023-09-19 12:23:01 +02:00
pata_ftide010.c
ata: pata_ftide010: Add missing MODULE_DESCRIPTION
2023-09-19 12:23:01 +02:00
pata_gayle.c
…
pata_hpt3x2n.c
ata: pata_hpt3x2n: Fix possible doc-rotted function name
2021-03-12 07:28:31 -07:00
pata_hpt3x3.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_hpt37x.c
ata: pata_hpt37x: fix PCI clock detection
2022-03-08 19:12:33 +01:00
pata_hpt366.c
ata: pata_hpt366: Provide missing description for 'hpt366_filter()'s 'mask' param
2021-03-12 07:28:30 -07:00
pata_icside.c
ata: Avoid comma separated statements
2021-01-31 08:05:46 -07:00
pata_imx.c
…
pata_isapnp.c
ata: pata_isapnp: Add missing error check for devm_ioport_map()
2023-12-03 07:31:21 +01:00
pata_it821x.c
ata: pata_it821x: Fix possible doc-rotted function names
2021-03-30 20:21:25 -06:00
pata_it8213.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_ixp4xx_cf.c
ata: libata: move ata_{port,link,dev}_dbg to standard pr_XXX() macros
2022-12-31 13:14:06 +01:00
pata_jmicron.c
ata: pata_jmicron: Fix incorrectly documented function parameter
2021-03-12 07:28:31 -07:00
pata_legacy.c
ata: pata_legacy: make legacy_exit() work again
2024-06-16 13:39:55 +02:00
pata_macio.c
ata: pata_macio: Avoid overwriting initialised field in 'pata_macio_sht'
2021-06-16 06:50:26 -06:00
pata_marvell.c
ata: pata_marvell: Check the 'bmdma_addr' beforing reading
2022-04-27 14:38:58 +02:00
pata_mpc52xx.c
…
pata_mpiix.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_netcell.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_ninja32.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_ns87410.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
pata_ns87415.c
ata: pata_ns87415: mark ns87560_tf_read static
2023-08-03 10:22:39 +02:00
pata_octeon_cf.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
pata_of_platform.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
pata_oldpiix.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_opti.c
ata: pata_opti: Fix spelling issue of 'val' in 'opti_write_reg()'
2021-03-30 20:21:26 -06:00
pata_optidma.c
ata: pata_optidma: Fix a function misnaming, a formatting issue and a missing description
2021-03-12 07:28:31 -07:00
pata_palmld.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
pata_pcmcia.c
pata_pcmia: add SanDisk High (>8G) CF card to supported list
2020-01-29 20:54:51 -07:00
pata_pdc202xx_old.c
ata: pata_pdc202xx_old: Fix some incorrectly named functions
2021-03-30 20:21:25 -06:00
pata_pdc2027x.c
ata: pata_pdc2027x: Fix some incorrect function names and parameter docs
2021-03-12 07:28:31 -07:00
pata_piccolo.c
ata: pata_piccolo: 'ata_tosh_init()' is misnamed in its header
2021-03-30 20:21:25 -06:00
pata_platform.c
pata_platform: Document `pio_mask' module parameter
2021-04-06 09:27:30 -06:00
pata_pxa.c
ata: make qc_prep return ata_completion_errors
2019-11-01 08:50:51 -06:00
pata_radisys.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_rb532_cf.c
ata: rb532_cf: remove redundant codes
2021-06-24 18:49:01 -06:00
pata_rdc.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
pata_rz1000.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_samsung_cf.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
pata_sc1200.c
ata: pata_sc1200: sc1200_sht'Avoid overwriting initialised field in '
2021-06-16 06:50:25 -06:00
pata_sch.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 300
2019-06-05 17:37:00 +02:00
pata_serverworks.c
ata: pata_serverworks: Avoid overwriting initialised field in 'serverworks_osb4_sht
2021-06-16 06:50:26 -06:00
pata_sil680.c
ata: pata_sil680: Add some missing function parameter docs
2021-03-30 20:21:25 -06:00
pata_sis.c
ata: pata_sis: Remove superfluous param description and supply another
2021-03-30 20:21:25 -06:00
pata_sl82c105.c
ata: pata_sl82c105: Fix potential doc-rot
2021-03-30 20:21:25 -06:00
pata_triflex.c
ata: pata_triflex: Repair some misnamed functions and fix some param descriptions
2021-03-30 20:21:25 -06:00
pata_via.c
ata: pata_via: Fix a kernel-doc formatting issue
2021-03-30 20:21:25 -06:00
pdc_adma.c
ata: make qc_prep return ata_completion_errors
2019-11-01 08:50:51 -06:00
sata_dwc_460ex.c
ata: sata_dwc_460ex: Fix crash due to OOB write
2022-04-13 20:59:23 +02:00
sata_fsl.c
sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
2021-12-08 09:04:42 +01:00
sata_gemini.c
ata: sata_gemini: Check clk_enable() result
2024-05-17 11:50:53 +02:00
sata_gemini.h
…
sata_highbank.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
sata_inic162x.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
sata_mv.c
ata: sata_mv: Fix PCI device ID table declaration compilation warning
2024-04-10 16:19:41 +02:00
sata_nv.c
ata: sata_nv: Do not over-write initialise fields in 'nv_adma_sht' and 'nv_swncq_sht'
2021-06-16 06:50:25 -06:00
sata_promise.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
sata_promise.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_qstor.c
ata: make qc_prep return ata_completion_errors
2019-11-01 08:50:51 -06:00
sata_rcar.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
sata_sil24.c
ata: sata_sil24: Do not over-write initialise fields in 'sil24_sht'
2021-06-16 06:50:25 -06:00
sata_sil.c
ata: make qc_prep return ata_completion_errors
2019-11-01 08:50:51 -06:00
sata_sis.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_svw.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
sata_sx4.c
ata: sata_sx4: fix pdc20621_get_from_dimm() on 64-bit
2024-04-10 16:19:41 +02:00
sata_uli.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_via.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
sata_vsc.c
ata: add/use ata_taskfile::{error|status} fields
2022-12-31 13:14:06 +01:00
sis.h
…