Marc Zyngier 83f331d1de gpio: tegra186: Fix chip_data type confusion
commit d1e972ace42390de739cde87d96043dcbe502286 upstream.

The tegra186 GPIO driver makes the assumption that the pointer
returned by irq_data_get_irq_chip_data() is a pointer to a
tegra_gpio structure. Unfortunately, it is actually a pointer
to the inner gpio_chip structure, as mandated by the gpiolib
infrastructure. Nice try.

The saving grace is that the gpio_chip is the first member of
tegra_gpio, so the bug has gone undetected since... forever.

Fix it by performing a container_of() on the pointer. This results
in no additional code, and makes it possible to understand how
the whole thing works.

Fixes: 5b2b135a87fc ("gpio: Add Tegra186 support")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Link: https://lore.kernel.org/r/20220211093904.1112679-1-maz@kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-03-02 11:48:10 +01:00
..
2020-07-20 15:34:59 +02:00
2021-04-14 10:19:22 +01:00
2021-09-07 12:27:27 -07:00
2020-01-15 11:24:19 +01:00
2021-05-05 16:07:41 +02:00
2019-09-03 16:04:19 +02:00
2021-09-07 12:27:27 -07:00
2021-09-07 12:27:27 -07:00
2019-11-07 09:27:48 +01:00
2021-08-29 21:19:50 +02:00
2021-12-29 12:28:43 +01:00
2019-12-09 10:40:18 +01:00