Maciej Fijalkowski
f7019562f1
xsk: Fix possible crash when multiple sockets are created ...
commit ba3beec2ec1d3b4fd8672ca6e781dac4b3267f6e upstream.
Fix a crash that happens if an Rx only socket is created first, then a
second socket is created that is Tx only and bound to the same umem as
the first socket and also the same netdev and queue_id together with the
XDP_SHARED_UMEM flag. In this specific case, the tx_descs array page
pool was not created by the first socket as it was an Rx only socket.
When the second socket is bound it needs this tx_descs array of this
shared page pool as it has a Tx component, but unfortunately it was
never allocated, leading to a crash. Note that this array is only used
for zero-copy drivers using the batched Tx APIs, currently only ice and
i40e.
[ 5511.150360] BUG: kernel NULL pointer dereference, address: 0000000000000008
[ 5511.158419] #PF: supervisor write access in kernel mode
[ 5511.164472] #PF: error_code(0x0002) - not-present page
[ 5511.170416] PGD 0 P4D 0
[ 5511.173347] Oops: 0002 [#1 ] PREEMPT SMP PTI
[ 5511.178186] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G E 5.18.0-rc1+ #97
[ 5511.187245] Hardware name: Intel Corp. GRANTLEY/GRANTLEY, BIOS GRRFCRB1.86B.0276.D07.1605190235 05/19/2016
[ 5511.198418] RIP: 0010:xsk_tx_peek_release_desc_batch+0x198/0x310
[ 5511.205375] Code: c0 83 c6 01 84 c2 74 6d 8d 46 ff 23 07 44 89 e1 48 83 c0 14 48 c1 e1 04 48 c1 e0 04 48 03 47 10 4c 01 c1 48 8b 50 08 48 8b 00 <48> 89 51 08 48 89 01 41 80 bd d7 00 00 00 00 75 82 48 8b 19 49 8b
[ 5511.227091] RSP: 0018:ffffc90000003dd0 EFLAGS: 00010246
[ 5511.233135] RAX: 0000000000000000 RBX: ffff88810c8da600 RCX: 0000000000000000
[ 5511.241384] RDX: 000000000000003c RSI: 0000000000000001 RDI: ffff888115f555c0
[ 5511.249634] RBP: ffffc90000003e08 R08: 0000000000000000 R09: ffff889092296b48
[ 5511.257886] R10: 0000ffffffffffff R11: ffff889092296800 R12: 0000000000000000
[ 5511.266138] R13: ffff88810c8db500 R14: 0000000000000040 R15: 0000000000000100
[ 5511.274387] FS: 0000000000000000(0000) GS:ffff88903f800000(0000) knlGS:0000000000000000
[ 5511.283746] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 5511.290389] CR2: 0000000000000008 CR3: 00000001046e2001 CR4: 00000000003706f0
[ 5511.298640] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 5511.306892] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 5511.315142] Call Trace:
[ 5511.317972] <IRQ>
[ 5511.320301] ice_xmit_zc+0x68/0x2f0 [ice]
[ 5511.324977] ? ktime_get+0x38/0xa0
[ 5511.328913] ice_napi_poll+0x7a/0x6a0 [ice]
[ 5511.333784] __napi_poll+0x2c/0x160
[ 5511.337821] net_rx_action+0xdd/0x200
[ 5511.342058] __do_softirq+0xe6/0x2dd
[ 5511.346198] irq_exit_rcu+0xb5/0x100
[ 5511.350339] common_interrupt+0xa4/0xc0
[ 5511.354777] </IRQ>
[ 5511.357201] <TASK>
[ 5511.359625] asm_common_interrupt+0x1e/0x40
[ 5511.364466] RIP: 0010:cpuidle_enter_state+0xd2/0x360
[ 5511.370211] Code: 49 89 c5 0f 1f 44 00 00 31 ff e8 e9 00 7b ff 45 84 ff 74 12 9c 58 f6 c4 02 0f 85 72 02 00 00 31 ff e8 02 0c 80 ff fb 45 85 f6 <0f> 88 11 01 00 00 49 63 c6 4c 2b 2c 24 48 8d 14 40 48 8d 14 90 49
[ 5511.391921] RSP: 0018:ffffffff82a03e60 EFLAGS: 00000202
[ 5511.397962] RAX: ffff88903f800000 RBX: 0000000000000001 RCX: 000000000000001f
[ 5511.406214] RDX: 0000000000000000 RSI: ffffffff823400b9 RDI: ffffffff8234c046
[ 5511.424646] RBP: ffff88810a384800 R08: 000005032a28c046 R09: 0000000000000008
[ 5511.443233] R10: 000000000000000b R11: 0000000000000006 R12: ffffffff82bcf700
[ 5511.461922] R13: 000005032a28c046 R14: 0000000000000001 R15: 0000000000000000
[ 5511.480300] cpuidle_enter+0x29/0x40
[ 5511.494329] do_idle+0x1c7/0x250
[ 5511.507610] cpu_startup_entry+0x19/0x20
[ 5511.521394] start_kernel+0x649/0x66e
[ 5511.534626] secondary_startup_64_no_verify+0xc3/0xcb
[ 5511.549230] </TASK>
Detect such case during bind() and allocate this memory region via newly
introduced xp_alloc_tx_descs(). Also, use kvcalloc instead of kcalloc as
for other buffer pool allocations, so that it matches the kvfree() from
xp_destroy().
Fixes: d1bc532e99be ("i40e: xsk: Move tmp desc array from driver to pool")
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
Link: https://lore.kernel.org/bpf/20220425153745.481322-1-maciej.fijalkowski@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-06-14 18:36:28 +02:00
2020-11-19 17:21:34 +01:00
2022-05-15 20:18:52 +02:00
2021-07-01 13:19:48 -07:00
2021-01-28 20:36:21 -08:00
2022-06-14 18:36:17 +02:00
2022-05-25 09:57:30 +02:00
2021-11-25 09:48:40 +01:00
2019-06-05 17:37:07 +02:00
2022-01-11 15:35:14 +01:00
2022-05-18 10:26:50 +02:00
2020-02-28 14:51:30 +01:00
2021-08-02 10:24:38 +01:00
2022-02-23 12:03:10 +01:00
2019-05-30 11:26:41 -07:00
2021-04-23 10:17:26 +01:00
2021-08-16 18:43:39 -07:00
2022-03-23 09:16:41 +01:00
2022-04-13 20:59:05 +02:00
2022-04-20 09:34:22 +02:00
2021-08-03 13:05:25 +01:00
2020-07-21 18:30:47 -07:00
2022-02-23 12:03:12 +01:00
2021-12-14 10:57:09 +01:00
2021-08-03 11:50:22 +01:00
2021-08-11 14:57:31 -07:00
2021-03-26 17:43:55 +01:00
2021-07-01 11:23:50 -07:00
2019-05-21 11:28:45 +02:00
2019-06-19 17:09:55 +02:00
2021-10-25 15:20:22 +02:00
2020-02-29 14:39:08 +01:00
2022-03-02 11:47:58 +01:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2021-08-05 11:46:42 +01:00
2019-05-30 11:29:52 -07:00
2019-05-30 11:29:52 -07:00
2021-08-14 13:59:10 +01:00
2021-07-30 15:33:24 +02:00
2019-05-21 11:52:39 +02:00
2019-05-21 11:52:39 +02:00
2022-03-16 14:23:47 +01:00
2019-12-16 16:09:44 -08:00
2021-12-08 09:04:46 +01:00
2022-02-16 12:56:30 +01:00
2020-05-08 21:33:33 -07:00
2021-07-29 12:18:11 +01:00
2020-05-05 13:23:29 -07:00
2022-04-27 14:38:52 +02:00
2020-04-20 07:34:16 +02:00
2019-06-19 17:09:55 +02:00
2019-12-24 22:37:30 -08:00
2021-12-08 09:04:43 +01:00
2022-04-20 09:34:09 +02:00
2022-06-14 18:36:17 +02:00
2021-09-02 11:44:19 +01:00
2021-01-21 13:33:45 +01:00
2021-01-21 13:33:45 +01:00
2019-12-09 10:36:44 -08:00
2019-11-05 18:20:55 -08:00
2021-02-12 16:31:46 -08:00
2019-03-22 12:09:31 -07:00
2021-01-29 20:39:14 -08:00
2021-03-18 19:51:12 -07:00
2020-06-22 21:12:44 -07:00
2019-10-25 16:24:32 -07:00
2021-06-28 14:29:45 -07:00
2021-08-13 09:58:25 +02:00
2019-05-30 11:26:41 -07:00
2022-06-09 10:22:31 +02:00
2019-04-22 21:50:53 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-03-30 13:45:04 -07:00
2021-01-27 18:18:15 -08:00
2021-11-18 19:16:33 +01:00
2020-12-14 18:38:58 -08:00
2022-01-27 11:05:35 +01:00
2022-05-18 10:26:53 +02:00
2021-12-29 12:28:42 +01:00
2019-09-27 12:05:02 +02:00
2021-07-21 08:14:33 -07:00
2020-06-20 17:47:53 -07:00
2022-02-23 12:03:10 +01:00
2021-08-05 15:08:47 -07:00
2022-05-09 09:14:36 +02:00
2021-12-08 09:04:49 +01:00
2022-05-09 09:14:36 +02:00
2021-02-04 18:37:57 -08:00
2022-05-25 09:57:30 +02:00
2022-01-27 11:05:35 +01:00
2021-12-01 09:04:49 +01:00
2022-02-23 12:03:10 +01:00
2019-06-19 17:09:55 +02:00
2020-06-20 17:22:22 -07:00
2021-03-23 14:14:50 -07:00
2019-10-08 13:23:05 -07:00
2021-07-27 13:05:56 +01:00
2021-11-18 19:17:10 +01:00
2021-08-30 01:51:36 +02:00
2021-09-27 12:02:54 +02:00
2019-05-30 11:26:41 -07:00
2021-06-24 12:41:12 -07:00
2021-10-18 13:47:09 +01:00
2021-08-25 11:23:14 +01:00
2020-03-02 11:16:27 -08:00
2021-03-26 15:14:56 -07:00
2020-02-28 12:08:37 -08:00
2020-05-29 21:20:20 -07:00
2021-10-28 08:19:06 -07:00
2019-12-09 10:36:44 -08:00
2022-03-08 19:12:33 +01:00
2021-11-18 19:17:16 +01:00
2022-04-13 20:59:03 +02:00
2019-05-21 11:28:45 +02:00
2021-07-27 11:43:50 +01:00
2019-11-12 08:18:03 -08:00
2019-04-11 13:59:49 -07:00
2021-09-24 14:07:10 +01:00
2021-12-01 09:04:46 +01:00
2021-08-09 15:49:00 -07:00
2020-03-04 13:25:55 -08:00
2019-05-30 11:26:32 -07:00
2021-08-30 16:33:59 -07:00
2022-01-27 11:04:02 +01:00
2021-05-17 15:29:35 -07:00
2021-08-09 15:34:21 -07:00
2019-05-30 11:26:32 -07:00
2021-03-25 17:40:43 -07:00
2020-07-31 09:24:23 +02:00
2020-08-24 14:35:00 -07:00
2022-02-01 17:27:14 +01:00
2020-06-23 20:27:09 -07:00
2021-08-04 10:01:26 +01:00
2019-04-22 21:47:25 -07:00
2022-06-14 18:36:12 +02:00
2020-07-13 11:03:44 -07:00
2022-05-18 10:26:53 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2022-01-27 11:05:05 +01:00
2021-04-28 14:06:45 -07:00
2020-09-28 15:19:03 -07:00
2019-10-05 16:29:00 -07:00
2021-06-15 18:01:05 +02:00
2022-03-02 11:48:01 +01:00
2021-08-03 13:05:26 +01:00
2021-11-18 19:17:11 +01:00
2021-08-04 12:35:07 +01:00
2019-05-30 11:26:32 -07:00
2022-06-14 18:36:11 +02:00
2019-05-30 11:26:32 -07:00
2019-10-04 14:07:07 -07:00
2021-10-28 14:41:20 +01:00
2020-06-23 20:10:15 -07:00
2020-06-18 20:46:23 -07:00
2021-02-04 18:37:14 -08:00
2021-10-26 13:09:22 +01:00
2019-11-14 18:12:17 -08:00
2020-09-14 16:49:39 -07:00
2019-12-09 10:28:43 -08:00
2019-11-16 12:39:10 -08:00
2022-06-14 18:36:18 +02:00
2021-06-24 19:41:15 +02:00
2021-07-07 19:51:12 -07:00
2022-05-25 09:57:30 +02:00
2022-06-14 18:36:28 +02:00
f7019562f1