linux

iv/linux

History

Florian Westphal c9f95c6783 mptcp: do not shrink snd_nxt when recovering

[ Upstream commit 0d199e4363b482badcedba764e2aceab53a4a10a ]

When recovering after a link failure, snd_nxt should not be set to a
lower value.  Else, update of snd_nxt is broken because:

  msk->snd_nxt += ret; (where ret is number of bytes sent)

assumes that snd_nxt always moves forward.
After reduction, its possible that snd_nxt update gets out of sync:
dfrag we just sent might have had a data sequence number even past
recovery_snd_nxt.

This change factors the common msk state update to a helper
and updates snd_nxt based on the current dfrag data sequence number.

The conditional is required for the recovery phase where we may
re-transmit old dfrags that are before current snd_nxt.

After this change, snd_nxt only moves forward and covers all in-sequence
data that was transmitted.

recovery_snd_nxt is retained to detect when recovery has completed.

Fixes: 1e1d9d6f119c5 ("mptcp: handle pending data on closed subflow")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2021-11-18 19:16:25 +01:00

crypto_test.c

mptcp: move crypto test to KUNIT

2020-06-26 16:21:39 -07:00

crypto.c

kunit: mptcp: adhere to KUNIT formatting standard

2021-04-16 17:10:40 -07:00

ctrl.c

mptcp: faster active backup recovery

2021-08-14 11:37:25 +01:00

diag.c

mptcp: allow dumping subflow context to userspace