J. Bruce Fields 6dfc954efb lockd: fix failure to cleanup client locks ...

commit d19a7af73b5ecaac8168712d18be72b9db166768 upstream.

In my testing, we're sometimes hitting the request->fl_flags & FL_EXISTS
case in posix_lock_inode, presumably just by random luck since we're not
actually initializing fl_flags here.

This probably didn't matter before commit 7f024fcd5c97 ("Keep read and
write fds with each nlm_file") since we wouldn't previously unlock
unless we knew there were locks.

But now it causes lockd to give up on removing more locks.

We could just initialize fl_flags, but really it seems dubious to be
calling vfs_lock_file with random values in some of the fields.

Fixes: 7f024fcd5c97 ("Keep read and write fds with each nlm_file")
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
[ cel: fixed checkpatch.pl nit ]
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2022-02-05 12:38:57 +01:00

..

clnt4xdr.c

NFS: Remove print_overflow_msg()

2019-02-13 11:53:45 -05:00

clntlock.c

treewide: Add SPDX license identifier for missed files

2019-05-21 10:50:45 +02:00

clntproc.c

lockd: Make two symbols static

2019-07-03 17:52:09 -04:00

clntxdr.c

NFS: Remove print_overflow_msg()

2019-02-13 11:53:45 -05:00

host.c

fs/lockd: convert comma to semicolon

2020-12-16 07:57:37 -05:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

mon.c

Replace HTTP links with HTTPS ones: NFS, SUNRPC, and LOCKD clients

2020-09-21 10:21:10 -04:00

netns.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

procfs.c

proc: convert everything to "struct proc_ops"

2020-02-04 03:05:26 +00:00

procfs.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

svc4proc.c

Keep read and write fds with each nlm_file

2021-08-23 18:05:31 -04:00

svc.c

NFS Client Updates for Linux 5.15

2021-09-04 10:25:26 -07:00

svclock.c

lockd: don't attempt blocking locks on nfs reexports

2021-08-26 15:32:18 -04:00

svcproc.c

Keep read and write fds with each nlm_file

2021-08-23 18:05:31 -04:00

svcshare.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

svcsubs.c

lockd: fix failure to cleanup client locks

2022-02-05 12:38:57 +01:00

svcxdr.h

NLM: Fix svcxdr_encode_owner()

2021-09-17 10:35:10 -04:00

xdr4.c

lockd: Update the NLMv4 SHARE results encoder to use struct xdr_stream

2021-07-06 20:14:44 -04:00

xdr.c

lockd: Update the NLMv1 SHARE results encoder to use struct xdr_stream

2021-07-06 20:14:43 -04:00