Thomas Zimmermann
31f351eb53
drm/aperture: Run fbdev removal before internal helpers ...
commit bf43e4521ff3223a613f3a496991a22a4d78e04b upstream.
Always run fbdev removal first to remove simpledrm via
sysfb_disable(). This clears the internal state. The later call
to drm_aperture_detach_drivers() then does nothing. Otherwise,
with drm_aperture_detach_drivers() running first, the call to
sysfb_disable() uses inconsistent state.
Example backtrace show below:
[ 11.663422] ==================================================================
[ 11.663426] BUG: KASAN: use-after-free in device_del+0x79/0x5f0
[ 11.663435] Read of size 8 at addr ffff888108185050 by task systemd-udevd/311
[ 11.663440] CPU: 0 PID: 311 Comm: systemd-udevd Tainted: G E 5
.19.0-rc2-1-default+ #1689
[ 11.663445] Hardware name: HP ProLiant DL120 G7, BIOS J01 04/21/2011
[ 11.663447] Call Trace:
[ 11.663449] <TASK>
[ 11.663451] ? device_del+0x79/0x5f0
[ 11.663456] dump_stack_lvl+0x5b/0x73
[ 11.663462] print_address_description.constprop.0+0x1f/0x1b0
[ 11.663468] ? device_del+0x79/0x5f0
[ 11.663471] ? device_del+0x79/0x5f0
[ 11.663475] print_report.cold+0x3c/0x21c
[ 11.663481] ? lock_acquired+0x87/0x1e0
[ 11.663484] ? lock_acquired+0x87/0x1e0
[ 11.663489] ? device_del+0x79/0x5f0
[ 11.663492] kasan_report+0xbf/0xf0
[ 11.663498] ? device_del+0x79/0x5f0
[ 11.663503] device_del+0x79/0x5f0
[ 11.663509] ? device_remove_attrs+0x170/0x170
[ 11.663514] ? lock_is_held_type+0xe8/0x140
[ 11.663523] platform_device_del.part.0+0x19/0xe0
[ 11.663530] platform_device_unregister+0x1c/0x30
[ 11.663535] sysfb_disable+0x2d/0x70
[ 11.663540] remove_conflicting_framebuffers+0x1c/0xf0
[ 11.663546] remove_conflicting_pci_framebuffers+0x130/0x1a0
[ 11.663554] drm_aperture_remove_conflicting_pci_framebuffers+0x86/0xb0
[ 11.663561] ? mgag200_pci_remove+0x30/0x30 [mgag200]
[ 11.663578] mgag200_pci_probe+0x2d/0x140 [mgag200]
Reported-by: Zack Rusin <zackr@vmware.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Zack Rusin <zackr@vmware.com>
Fixes: ee7a69aa38d8 ("fbdev: Disable sysfb device registration when removing conflicting FBs")
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Changcheng Deng <deng.changcheng@zte.com.cn>
Link: https://patchwork.freedesktop.org/patch/msgid/20220617121027.30273-1-tzimmermann@suse.de
(cherry picked from commit fb84efa28a48e30b87fa1122e8aab8016c7347cd)
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-07-21 21:24:44 +02:00
2022-02-16 12:56:37 +01:00
2022-07-21 21:24:32 +02:00
2022-06-22 14:21:56 +02:00
2022-03-23 09:16:41 +01:00
2022-03-08 19:12:47 +01:00
2022-07-12 16:35:09 +02:00
2022-07-12 16:35:11 +02:00
2022-07-12 16:35:08 +02:00
2022-07-12 16:35:03 +02:00
2022-06-29 09:03:31 +02:00
2022-07-12 16:34:58 +02:00
2022-07-07 17:53:32 +02:00
2022-06-22 14:22:03 +02:00
2022-07-21 21:24:34 +02:00
2022-06-09 10:22:33 +02:00
2022-06-09 10:23:11 +02:00
2022-07-12 16:34:58 +02:00
2022-04-08 14:23:31 +02:00
2022-07-07 17:53:27 +02:00
2022-07-12 16:35:19 +02:00
2022-07-12 16:34:51 +02:00
2022-06-09 10:22:47 +02:00
2022-06-14 18:36:22 +02:00
2022-05-12 12:30:05 +02:00
2022-07-21 21:24:35 +02:00
2022-07-07 17:53:32 +02:00
2022-06-29 09:03:26 +02:00
2022-07-21 21:24:44 +02:00
2022-04-08 14:22:50 +02:00
2022-06-09 10:22:56 +02:00
2022-06-22 14:22:00 +02:00
2022-07-07 17:53:35 +02:00
2022-06-14 18:36:06 +02:00
2022-07-12 16:35:16 +02:00
2022-03-08 19:12:37 +01:00
2022-07-12 16:35:01 +02:00
2022-07-07 17:53:26 +02:00
2022-07-12 16:34:51 +02:00
2022-06-09 10:23:31 +02:00
2022-07-12 16:35:09 +02:00
2022-07-21 21:24:40 +02:00
2022-03-16 14:23:36 +01:00
2022-06-09 10:23:12 +02:00
2022-06-09 10:23:12 +02:00
2022-07-07 17:53:24 +02:00
2022-07-12 16:34:57 +02:00
2022-07-12 16:34:52 +02:00
2022-06-09 10:23:12 +02:00
2022-07-12 16:35:17 +02:00
2022-06-29 09:03:19 +02:00
2022-07-15 10:13:00 +02:00
2022-07-21 21:24:40 +02:00
2022-07-21 21:24:35 +02:00
2022-03-08 19:12:44 +01:00
2022-07-07 17:53:24 +02:00
2022-07-21 21:24:41 +02:00
2022-03-02 11:48:06 +01:00
2022-06-09 10:22:50 +02:00
2022-06-09 10:23:13 +02:00
2022-04-13 20:59:14 +02:00
2022-07-12 16:34:52 +02:00
2022-06-14 18:36:02 +02:00
2022-04-27 14:39:00 +02:00
2022-06-14 18:36:06 +02:00
2022-07-21 21:24:36 +02:00
2022-07-21 21:24:34 +02:00
2022-06-14 18:36:21 +02:00
2022-04-08 14:23:44 +02:00
2022-04-13 20:59:01 +02:00
2022-06-14 18:36:04 +02:00
2022-06-09 10:23:00 +02:00
2022-06-14 18:36:03 +02:00
2022-04-27 14:38:55 +02:00
2022-06-14 18:36:05 +02:00
2022-06-14 18:36:07 +02:00
2022-06-09 10:23:21 +02:00
2022-07-21 21:24:34 +02:00
2022-05-18 10:26:55 +02:00
2022-07-21 21:24:40 +02:00
2022-06-14 18:36:21 +02:00
2022-07-21 21:24:16 +02:00
2022-06-22 14:21:59 +02:00
2022-06-09 10:22:47 +02:00
2022-03-02 11:47:51 +01:00
2022-06-09 10:23:26 +02:00
2022-06-14 18:36:20 +02:00
2022-07-21 21:24:43 +02:00
2022-07-21 21:24:42 +02:00
2022-07-21 21:24:33 +02:00
2022-04-20 09:34:13 +02:00
2022-06-14 18:36:24 +02:00
2022-07-21 21:24:35 +02:00
2022-04-08 14:23:50 +02:00
2022-07-21 21:24:33 +02:00
2022-04-13 20:59:11 +02:00
2022-06-14 18:36:22 +02:00
2022-07-21 21:24:23 +02:00
31f351eb53