Saurabh Sengar
cd2a50d0a0
scsi: storvsc: Remove WQ_MEM_RECLAIM from storvsc_error_wq ...
commit d957e7ffb2c72410bcc1a514153a46719255a5da upstream.
storvsc_error_wq workqueue should not be marked as WQ_MEM_RECLAIM as it
doesn't need to make forward progress under memory pressure. Marking this
workqueue as WQ_MEM_RECLAIM may cause deadlock while flushing a
non-WQ_MEM_RECLAIM workqueue. In the current state it causes the following
warning:
[ 14.506347] ------------[ cut here ]------------
[ 14.506354] workqueue: WQ_MEM_RECLAIM storvsc_error_wq_0:storvsc_remove_lun is flushing !WQ_MEM_RECLAIM events_freezable_power_:disk_events_workfn
[ 14.506360] WARNING: CPU: 0 PID: 8 at <-snip->kernel/workqueue.c:2623 check_flush_dependency+0xb5/0x130
[ 14.506390] CPU: 0 PID: 8 Comm: kworker/u4:0 Not tainted 5.4.0-1086-azure #91~18.04.1-Ubuntu
[ 14.506391] Hardware name: Microsoft Corporation Virtual Machine/Virtual Machine, BIOS Hyper-V UEFI Release v4.1 05/09/2022
[ 14.506393] Workqueue: storvsc_error_wq_0 storvsc_remove_lun
[ 14.506395] RIP: 0010:check_flush_dependency+0xb5/0x130
<-snip->
[ 14.506408] Call Trace:
[ 14.506412] __flush_work+0xf1/0x1c0
[ 14.506414] __cancel_work_timer+0x12f/0x1b0
[ 14.506417] ? kernfs_put+0xf0/0x190
[ 14.506418] cancel_delayed_work_sync+0x13/0x20
[ 14.506420] disk_block_events+0x78/0x80
[ 14.506421] del_gendisk+0x3d/0x2f0
[ 14.506423] sr_remove+0x28/0x70
[ 14.506427] device_release_driver_internal+0xef/0x1c0
[ 14.506428] device_release_driver+0x12/0x20
[ 14.506429] bus_remove_device+0xe1/0x150
[ 14.506431] device_del+0x167/0x380
[ 14.506432] __scsi_remove_device+0x11d/0x150
[ 14.506433] scsi_remove_device+0x26/0x40
[ 14.506434] storvsc_remove_lun+0x40/0x60
[ 14.506436] process_one_work+0x209/0x400
[ 14.506437] worker_thread+0x34/0x400
[ 14.506439] kthread+0x121/0x140
[ 14.506440] ? process_one_work+0x400/0x400
[ 14.506441] ? kthread_park+0x90/0x90
[ 14.506443] ret_from_fork+0x35/0x40
[ 14.506445] ---[ end trace 2d9633159fdc6ee7 ]---
Link: https://lore.kernel.org/r/1659628534-17539-1-git-send-email-ssengar@linux.microsoft.com
Fixes: 436ad9413353 ("scsi: storvsc: Allow only one remove lun work item to be issued per lun")
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-08-31 17:16:51 +02:00
2021-08-11 22:25:38 -04:00
2021-07-11 10:59:53 -07:00
2021-07-11 10:59:53 -07:00
2021-06-18 23:26:33 -04:00
2021-10-04 21:54:18 -04:00
2022-08-17 14:23:45 +02:00
2022-04-13 20:59:02 +02:00
2022-02-08 18:34:11 +01:00
2022-08-17 14:23:45 +02:00
2021-11-18 19:16:52 +01:00
2022-08-17 14:23:45 +02:00
2021-09-07 19:13:42 -07:00
2022-05-25 09:57:34 +02:00
2020-03-11 23:07:59 -04:00
2022-02-01 17:27:07 +01:00
2021-06-02 01:37:04 -04:00
2022-06-09 10:23:07 +02:00
2022-04-08 14:23:33 +02:00
2022-08-17 14:23:06 +02:00
2022-06-29 09:03:19 +02:00
2022-04-20 09:34:15 +02:00
2021-08-11 22:25:43 -04:00
2022-04-13 20:59:08 +02:00
2022-04-08 14:22:54 +02:00
2022-08-25 11:40:35 +02:00
2022-07-29 17:25:12 +02:00
2022-04-13 20:59:05 +02:00
2022-08-03 12:03:47 +02:00
2022-04-20 09:34:17 +02:00
2021-08-09 23:30:25 -04:00
2022-04-20 09:34:11 +02:00
2022-02-16 12:56:13 +01:00
2022-08-17 14:23:45 +02:00
2022-08-31 17:16:35 +02:00
2021-08-11 22:25:41 -04:00
2022-08-17 14:23:51 +02:00
2021-08-24 22:56:32 -04:00
2021-08-11 22:25:42 -04:00
2022-08-31 17:16:51 +02:00
2020-03-25 11:50:48 +01:00
2021-05-31 23:59:18 -04:00
2021-05-15 18:01:34 -04:00
2021-03-18 22:18:09 -04:00
2021-01-22 21:14:08 -05:00
2021-05-31 23:59:18 -04:00
2021-01-22 21:14:07 -05:00
2021-08-11 22:25:38 -04:00
2021-05-07 00:26:34 -07:00
2021-03-29 23:33:06 -04:00
2020-06-09 09:39:13 -07:00
2020-06-09 09:39:13 -07:00
2021-11-25 09:48:27 +01:00
2022-04-13 20:59:07 +02:00
2021-08-11 22:25:38 -04:00
2021-01-13 00:14:07 -05:00
2021-06-18 23:27:04 -04:00
2020-11-23 22:12:09 -05:00
2021-03-15 22:29:00 -04:00
2021-01-22 21:14:08 -05:00
2021-08-01 13:27:46 -04:00
2021-05-14 22:19:04 -04:00
2021-07-28 22:24:25 -04:00
2021-06-02 23:09:39 -04:00
2022-06-09 10:23:22 +02:00
2021-01-22 21:14:10 -05:00
2021-08-11 22:25:38 -04:00
2020-03-11 23:07:59 -04:00
2021-05-31 22:48:21 -04:00
2019-12-19 22:08:51 -05:00
2021-01-26 07:42:27 +01:00
2021-05-31 22:48:24 -04:00
2020-07-08 01:12:44 -04:00
2021-06-02 01:37:04 -04:00
2021-01-26 07:42:27 +01:00
2020-06-09 09:39:13 -07:00
2021-11-18 19:15:51 +01:00
2021-04-01 22:52:40 -04:00
2021-08-11 22:25:39 -04:00
2020-09-02 22:49:06 -04:00
2021-05-31 22:48:21 -04:00
2021-06-18 23:01:03 -04:00
2021-03-18 23:35:55 -04:00
2021-01-22 21:14:10 -05:00
2022-06-22 14:21:57 +02:00
2021-06-29 16:46:08 -04:00
2021-08-11 22:25:39 -04:00
2021-05-07 00:26:34 -07:00
2020-06-02 21:23:47 -04:00
2022-08-17 14:23:45 +02:00
2021-04-13 00:20:48 -04:00
2021-07-28 22:24:27 -04:00
2021-08-30 10:18:25 +02:00
2022-04-27 14:38:56 +02:00
2022-08-17 14:23:45 +02:00
2021-03-24 22:16:12 -04:00
2020-10-02 21:52:53 -04:00
2020-12-07 20:24:09 -05:00
2021-08-23 23:07:05 -04:00
2022-06-09 10:22:34 +02:00
2021-05-31 22:48:23 -04:00
2020-06-09 09:39:13 -07:00
2021-08-11 22:25:40 -04:00
2020-03-11 23:07:56 -04:00
2022-06-14 18:36:22 +02:00
2020-01-02 21:57:44 -05:00
2022-02-16 12:56:14 +01:00
2020-01-02 21:57:44 -05:00
2021-09-13 22:15:47 -04:00
2021-01-22 21:14:12 -05:00
2021-08-11 22:25:38 -04:00
2020-12-07 20:24:09 -05:00
2021-05-31 22:48:23 -04:00
2022-06-22 14:21:57 +02:00
2021-05-21 16:59:33 -04:00
2021-06-18 23:01:03 -04:00
2021-05-31 22:48:21 -04:00
2021-08-23 23:06:56 -04:00
2020-01-15 23:09:11 -05:00
2021-05-31 22:48:23 -04:00
2021-08-11 22:25:41 -04:00
2021-08-01 13:21:40 -04:00
2021-07-28 22:24:27 -04:00
2022-06-29 09:03:21 +02:00
2022-01-27 11:05:22 +01:00
2021-07-21 23:49:02 -04:00
2021-03-24 23:03:43 -04:00
2022-04-08 14:22:54 +02:00
2022-08-03 12:03:47 +02:00
2021-11-25 09:48:26 +01:00
2021-08-11 22:25:37 -04:00
2019-12-19 22:08:54 -05:00
2022-01-27 11:04:15 +01:00
2021-07-30 22:22:36 -04:00
2020-02-04 03:05:26 +00:00
2022-04-13 20:59:15 +02:00
2021-12-01 09:04:50 +01:00
2020-03-16 22:08:36 -04:00
2022-04-08 14:22:54 +02:00
2022-08-17 14:23:44 +02:00
2021-05-31 22:48:20 -04:00
2021-08-11 22:25:37 -04:00
2021-04-05 23:14:53 -04:00
2022-01-27 11:04:10 +01:00
2021-05-06 19:24:11 -07:00
2021-09-21 23:52:55 -04:00
2022-06-14 18:36:13 +02:00
2020-10-14 15:15:35 -07:00
2020-09-15 20:28:06 -04:00
2021-09-28 22:42:06 -04:00
2022-08-17 14:22:55 +02:00
2020-09-25 06:20:44 +02:00
2021-03-18 22:52:29 -04:00
2021-05-07 00:26:34 -07:00
2022-04-27 14:38:58 +02:00
2022-01-27 11:05:03 +01:00
2022-04-13 20:59:15 +02:00
2020-02-24 15:01:57 -05:00
2022-03-16 14:23:46 +01:00
2021-08-23 12:54:30 -06:00
2021-08-11 22:25:41 -04:00
2022-08-31 17:16:51 +02:00
2021-08-11 22:25:41 -04:00
2021-04-13 00:20:48 -04:00
2020-10-02 21:52:55 -04:00
2021-09-28 22:47:28 -04:00
2022-01-05 12:42:39 +01:00
2022-06-22 14:21:57 +02:00
2021-05-31 22:48:23 -04:00
2021-08-16 13:33:24 -04:00
2022-03-11 12:22:36 +01:00
2021-08-30 10:18:25 +02:00
2022-04-13 20:59:15 +02:00
2020-06-09 09:39:13 -07:00
cd2a50d0a0