linux

iv/linux

History

Dongliang Mu 433c33c554 phy: qualcomm: call clk_disable_unprepare in the error handling

[ Upstream commit c3966ced8eb8dc53b6c8d7f97d32cc8a2107d83e ]

Smatch reports the following error:

drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
warn: 'uphy->cal_clk' from clk_prepare_enable() not released on lines:
58.
drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
warn: 'uphy->cal_sleep_clk' from clk_prepare_enable() not released on
lines: 58.
drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
warn: 'uphy->phy_clk' from clk_prepare_enable() not released on lines:
58.

Fix this by calling proper clk_disable_unprepare calls.

Fixes: 0b56e9a7e835 ("phy: Group vendor specific phy drivers")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20220914051334.69282-1-dzm91@hust.edu.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2022-10-26 12:35:14 +02:00

Kconfig

phy: qualcomm: Fix 28 nm Hi-Speed USB PHY OF dependency

2020-11-16 13:20:38 +05:30

Makefile

phy: qualcomm: add qcom ipq806x dwc usb phy driver

2020-07-20 11:54:03 +05:30

phy-ath79-usb.c

phy: ath79-usb: Fix the main reset name to match the DT binding

2019-01-16 18:00:57 +05:30

phy-qcom-apq8064-sata.c

phy: qualcomm: convert to devm_platform_ioremap_resource(_byname)