Ashish Kalra
c50ec15725
ACPI: APEI: Fix integer overflow in ghes_estatus_pool_init() ...
[ Upstream commit 43d2748394c3feb86c0c771466f5847e274fc043 ]
Change num_ghes from int to unsigned int, preventing an overflow
and causing subsequent vmalloc() to fail.
The overflow happens in ghes_estatus_pool_init() when calculating
len during execution of the statement below as both multiplication
operands here are signed int:
len += (num_ghes * GHES_ESOURCE_PREALLOC_MAX_SIZE);
The following call trace is observed because of this bug:
[ 9.317108] swapper/0: vmalloc error: size 18446744071562596352, exceeds total pages, mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0-1
[ 9.317131] Call Trace:
[ 9.317134] <TASK>
[ 9.317137] dump_stack_lvl+0x49/0x5f
[ 9.317145] dump_stack+0x10/0x12
[ 9.317146] warn_alloc.cold+0x7b/0xdf
[ 9.317150] ? __device_attach+0x16a/0x1b0
[ 9.317155] __vmalloc_node_range+0x702/0x740
[ 9.317160] ? device_add+0x17f/0x920
[ 9.317164] ? dev_set_name+0x53/0x70
[ 9.317166] ? platform_device_add+0xf9/0x240
[ 9.317168] __vmalloc_node+0x49/0x50
[ 9.317170] ? ghes_estatus_pool_init+0x43/0xa0
[ 9.317176] vmalloc+0x21/0x30
[ 9.317177] ghes_estatus_pool_init+0x43/0xa0
[ 9.317179] acpi_hest_init+0x129/0x19c
[ 9.317185] acpi_init+0x434/0x4a4
[ 9.317188] ? acpi_sleep_proc_init+0x2a/0x2a
[ 9.317190] do_one_initcall+0x48/0x200
[ 9.317195] kernel_init_freeable+0x221/0x284
[ 9.317200] ? rest_init+0xe0/0xe0
[ 9.317204] kernel_init+0x1a/0x130
[ 9.317205] ret_from_fork+0x22/0x30
[ 9.317208] </TASK>
Signed-off-by: Ashish Kalra <ashish.kalra@amd.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-11-10 18:15:34 +01:00
2022-04-08 14:23:56 +02:00
2022-11-10 18:15:34 +01:00
2022-02-16 12:56:19 +01:00
2021-08-04 18:08:50 +02:00
2021-09-27 11:40:43 -07:00
2021-07-16 19:09:20 +02:00
2021-11-18 19:17:06 +01:00
2022-10-26 12:35:31 +02:00
2021-11-18 19:16:19 +01:00
2021-06-30 20:01:10 +02:00
2021-05-13 17:08:42 +02:00
2021-06-07 15:36:45 +02:00
2021-07-16 19:20:28 +02:00
2020-11-17 18:12:34 +01:00
2022-10-29 10:12:55 +02:00
2022-10-26 12:35:30 +02:00
2021-05-24 16:27:34 +02:00
2022-08-17 14:23:03 +02:00
2021-09-08 11:50:23 -07:00
2021-08-04 20:25:54 +02:00
2020-12-15 19:30:49 +01:00
2021-08-04 20:25:54 +02:00
2021-01-22 16:17:19 +01:00
2022-10-26 12:35:30 +02:00
2020-11-17 18:06:29 +01:00
2022-03-28 09:58:44 +02:00
2021-06-23 19:27:50 +02:00
2021-06-07 15:36:45 +02:00
2022-08-17 14:23:11 +02:00
2021-08-25 19:57:01 +02:00
2022-08-17 14:24:25 +02:00
2021-04-28 19:17:54 +02:00
2020-09-25 18:25:51 +02:00
2021-06-30 12:21:16 -07:00
2021-06-17 14:32:05 +02:00
2021-04-08 16:27:03 +02:00
2022-08-17 14:23:03 +02:00
2021-06-29 15:51:25 +02:00
2020-11-09 19:25:20 +01:00
2021-05-21 19:02:35 +02:00
2021-05-21 19:02:35 +02:00
2021-11-21 13:44:14 +01:00
2021-03-08 16:51:48 +01:00
2022-01-27 11:03:23 +01:00
2021-04-23 18:00:52 +01:00
2021-08-30 19:30:37 +02:00
2021-07-02 13:22:47 -07:00
2021-06-29 15:51:25 +02:00
2021-09-23 20:39:36 +02:00
2021-03-08 16:51:08 +01:00
2021-03-08 19:10:30 +01:00
2022-08-25 11:40:36 +02:00
2022-08-17 14:23:11 +02:00
2020-09-25 18:25:51 +02:00
2021-08-16 18:32:02 +02:00
2021-11-18 19:17:09 +01:00
2021-06-07 15:55:02 +02:00
2021-09-08 20:56:57 +02:00
2020-09-25 18:25:51 +02:00
2020-09-25 18:25:51 +02:00
2021-03-08 16:51:19 +01:00
2022-08-17 14:23:06 +02:00
2021-03-08 16:51:19 +01:00
2021-06-07 15:36:46 +02:00
2022-08-31 17:16:48 +02:00
2021-06-29 15:50:37 +02:00
2022-08-25 11:40:10 +02:00
2021-06-07 15:36:46 +02:00
2022-09-20 12:39:42 +02:00
2021-06-07 15:36:46 +02:00
2021-06-29 15:51:25 +02:00
2020-11-09 19:08:06 +01:00
2022-01-27 11:03:48 +01:00
2022-08-17 14:23:03 +02:00
2021-05-10 14:02:17 +02:00
2021-08-16 18:38:08 +02:00
2022-05-30 09:28:58 +02:00
2021-10-21 18:30:49 -10:00
2022-09-05 10:30:03 +02:00
2020-11-17 18:12:34 +01:00
2021-07-19 16:22:01 +02:00
2022-10-29 10:12:58 +02:00
2022-08-17 14:23:11 +02:00
2020-11-09 19:08:06 +01:00
c50ec15725