linux

iv/linux

History

Jason A. Donenfeld c60801e4e2 wireguard: netlink: avoid variable-sized memcpy on sockaddr

[ Upstream commit 26c013108c12b94bc023bf19198a4300596c98b1 ]

Doing a variable-sized memcpy is slower, and the compiler isn't smart
enough to turn this into a constant-size assignment.

Further, Kees' latest fortified memcpy will actually bark, because the
destination pointer is type sockaddr, not explicitly sockaddr_in or
sockaddr_in6, so it thinks there's an overflow:

    memcpy: detected field-spanning write (size 28) of single field
    "&endpoint.addr" at drivers/net/wireguard/netlink.c:446 (size 16)

Fix this by just assigning by using explicit casts for each checked
case.

Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reported-by: syzbot+a448cda4dba2dac50de5@syzkaller.appspotmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2022-09-28 11:11:51 +02:00

selftest

wireguard: ratelimiter: disable timings test by default

2022-09-28 11:11:50 +02:00

allowedips.c

wireguard: allowedips: don't corrupt stack when detecting overflow

2022-08-17 14:23:37 +02:00

allowedips.h

wireguard: allowedips: free empty intermediate nodes when removing single node

2021-06-04 14:25:14 -07:00

cookie.c

…