linux

iv/linux

History

Jeff Layton 7a369dc87b fscache: don't leak cookie access refs if invalidation is in progress or failed

commit fb24771faf72a2fd62b3b6287af3c610c3ec9cf1 upstream.

It's possible for a request to invalidate a fscache_cookie will come in
while we're already processing an invalidation. If that happens we
currently take an extra access reference that will leak. Only call
__fscache_begin_cookie_access if the FSCACHE_COOKIE_DO_INVALIDATE bit
was previously clear.

Also, ensure that we attempt to clear the bit when the cookie is
"FAILED" and put the reference to avoid an access leak.

Fixes: 85e4ea1049c7 ("fscache: Fix invalidation/lookup race")
Suggested-by: David Howells <dhowells@redhat.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2022-08-25 11:45:25 +02:00

cache.c

fscache: Use wrapper fscache_set_cache_state() directly when relinquishing

2022-04-08 23:54:37 +01:00

cookie.c

fscache: don't leak cookie access refs if invalidation is in progress or failed

2022-08-25 11:45:25 +02:00

internal.h

fscache: Move fscache_cookies_seq_ops specific code under CONFIG_PROC_FS

2022-04-08 23:54:37 +01:00

io.c

fscache: Remove the cookie parameter from fscache_clear_page_bits()