linux

iv/linux

History

Miklos Szeredi ea64c14beb ovl: warn if trusted xattr creation fails

[ Upstream commit b10b85fe5149ee8b39fbbf86095b303632dde2cd ]

When mounting overlayfs in an unprivileged user namespace, trusted xattr
creation will fail.  This will lead to failures in some file operations,
e.g. in the following situation:

  mkdir lower upper work merged
  mkdir lower/directory
  mount -toverlay -olowerdir=lower,upperdir=upper,workdir=work none merged
  rmdir merged/directory
  mkdir merged/directory

The last mkdir will fail:

  mkdir: cannot create directory 'merged/directory': Input/output error

The cause for these failures is currently extremely non-obvious and hard to
debug.  Hence, warn the user and suggest using the userxattr mount option,
if it is not already supplied and xattr creation fails during the
self-check.

Reported-by: Alois Wohlschlager <alois1@gmx-topmail.de>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2022-08-25 11:45:52 +02:00

copy_up.c

ovl: use ovl_path_getxattr() wrapper

2022-04-28 16:31:11 +02:00

dir.c

ovl: use ovl_copy_{real,upper}attr() wrappers

2022-04-28 16:31:12 +02:00

export.c

ovl: drop WARN_ON() dentry is NULL in ovl_encode_fh()

2022-08-17 15:13:48 +02:00

file.c

overlayfs update for 5.19