Yang Jihong
d81bd6671f
ftrace: Fix NULL pointer dereference in is_ftrace_trampoline when ftrace is dead ...
commit c3b0f72e805f0801f05fa2aa52011c4bfc694c44 upstream.
ftrace_startup does not remove ops from ftrace_ops_list when
ftrace_startup_enable fails:
register_ftrace_function
ftrace_startup
__register_ftrace_function
...
add_ftrace_ops(&ftrace_ops_list, ops)
...
...
ftrace_startup_enable // if ftrace failed to modify, ftrace_disabled is set to 1
...
return 0 // ops is in the ftrace_ops_list.
When ftrace_disabled = 1, unregister_ftrace_function simply returns without doing anything:
unregister_ftrace_function
ftrace_shutdown
if (unlikely(ftrace_disabled))
return -ENODEV; // return here, __unregister_ftrace_function is not executed,
// as a result, ops is still in the ftrace_ops_list
__unregister_ftrace_function
...
If ops is dynamically allocated, it will be free later, in this case,
is_ftrace_trampoline accesses NULL pointer:
is_ftrace_trampoline
ftrace_ops_trampoline
do_for_each_ftrace_op(op, ftrace_ops_list) // OOPS! op may be NULL!
Syzkaller reports as follows:
[ 1203.506103] BUG: kernel NULL pointer dereference, address: 000000000000010b
[ 1203.508039] #PF: supervisor read access in kernel mode
[ 1203.508798] #PF: error_code(0x0000) - not-present page
[ 1203.509558] PGD 800000011660b067 P4D 800000011660b067 PUD 130fb8067 PMD 0
[ 1203.510560] Oops: 0000 [#1 ] SMP KASAN PTI
[ 1203.511189] CPU: 6 PID: 29532 Comm: syz-executor.2 Tainted: G B W 5.10.0 #8
[ 1203.512324] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
[ 1203.513895] RIP: 0010:is_ftrace_trampoline+0x26/0xb0
[ 1203.514644] Code: ff eb d3 90 41 55 41 54 49 89 fc 55 53 e8 f2 00 fd ff 48 8b 1d 3b 35 5d 03 e8 e6 00 fd ff 48 8d bb 90 00 00 00 e8 2a 81 26 00 <48> 8b ab 90 00 00 00 48 85 ed 74 1d e8 c9 00 fd ff 48 8d bb 98 00
[ 1203.518838] RSP: 0018:ffffc900012cf960 EFLAGS: 00010246
[ 1203.520092] RAX: 0000000000000000 RBX: 000000000000007b RCX: ffffffff8a331866
[ 1203.521469] RDX: 0000000000000000 RSI: 0000000000000008 RDI: 000000000000010b
[ 1203.522583] RBP: 0000000000000000 R08: 0000000000000000 R09: ffffffff8df18b07
[ 1203.523550] R10: fffffbfff1be3160 R11: 0000000000000001 R12: 0000000000478399
[ 1203.524596] R13: 0000000000000000 R14: ffff888145088000 R15: 0000000000000008
[ 1203.525634] FS: 00007f429f5f4700(0000) GS:ffff8881daf00000(0000) knlGS:0000000000000000
[ 1203.526801] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1203.527626] CR2: 000000000000010b CR3: 0000000170e1e001 CR4: 00000000003706e0
[ 1203.528611] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 1203.529605] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Therefore, when ftrace_startup_enable fails, we need to rollback registration
process and remove ops from ftrace_ops_list.
Link: https://lkml.kernel.org/r/20220818032659.56209-1-yangjihong1@huawei.com
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-09-05 10:31:28 +02:00
2022-08-31 17:18:21 +02:00
2022-08-31 17:17:59 +02:00
2022-07-27 18:09:11 +02:00
2022-05-26 17:13:43 -07:00
2022-08-17 15:15:52 +02:00
2022-06-08 09:16:31 -07:00
2022-07-13 11:29:12 +02:00
2022-05-25 16:18:27 -07:00
2022-08-17 15:14:19 +02:00
2022-05-25 11:32:53 -07:00
2022-06-02 08:55:01 -07:00
2022-08-17 15:14:10 +02:00
2022-07-11 10:19:09 -07:00
2022-08-17 15:14:06 +02:00
2022-07-15 10:52:11 +02:00
2022-08-17 15:14:33 +02:00
2022-08-17 15:16:02 +02:00
2022-08-17 15:16:09 +02:00
2022-09-05 10:31:28 +02:00
2022-04-06 13:43:44 -07:00
2022-02-03 11:20:34 -08:00
2022-08-31 17:17:59 +02:00
2022-04-25 14:37:28 +02:00
2022-04-25 14:37:12 +02:00
2022-01-25 13:22:51 -05:00
2022-02-22 13:51:40 -05:00
2022-01-11 13:08:21 -08:00
2022-08-31 17:18:14 +02:00
2022-03-09 10:32:06 -08:00
2022-06-13 09:18:46 -07:00
2022-05-23 17:51:12 -07:00
2022-05-27 11:22:03 -07:00
2022-03-15 10:32:44 +01:00
2022-06-01 15:55:25 -07:00
2022-07-11 09:52:59 -07:00
2022-02-16 23:25:12 +11:00
2022-06-03 16:03:05 -07:00
2022-05-08 03:16:59 +09:00
2022-06-23 19:11:28 +02:00
2022-04-15 14:49:55 -07:00
2022-05-10 14:42:06 -07:00
2022-03-31 10:36:55 +02:00
2022-05-25 13:05:42 -07:00
2022-05-27 11:22:03 -07:00
2022-08-21 15:20:08 +02:00
2022-08-31 17:18:00 +02:00
2022-03-23 19:00:33 -07:00
2022-06-16 19:11:30 -07:00
2022-04-21 11:40:59 -07:00
2022-06-06 08:06:00 +02:00
2022-05-19 19:30:30 +02:00
2022-01-31 11:21:46 +11:00
2022-06-23 19:11:28 +02:00
2021-12-28 11:26:18 +01:00
2022-04-29 14:38:00 -07:00
2022-06-06 08:06:00 +02:00
2022-08-17 15:15:46 +02:00
2022-07-09 11:06:19 -07:00
2022-06-23 19:11:28 +02:00
2022-05-12 20:38:37 -07:00
2022-03-23 19:00:35 -07:00
2022-02-02 13:11:34 +01:00
2022-04-11 17:07:29 -07:00
2022-03-24 19:06:48 -07:00
2022-05-03 14:11:58 -07:00
2022-07-07 09:53:43 -07:00
2022-08-17 15:16:09 +02:00
2022-04-12 14:13:01 +02:00
2022-05-01 10:03:43 +02:00
2022-05-08 01:33:09 -07:00
2022-02-25 09:36:06 +01:00
2022-04-05 09:59:38 +02:00
2022-04-05 09:59:38 +02:00
2022-05-24 11:11:13 -07:00
2022-08-31 17:18:00 +02:00
2022-04-22 18:50:54 +01:00
2022-07-15 09:52:35 -07:00
2022-04-30 08:39:32 -06:00
2022-04-29 14:38:03 -07:00
2022-02-01 17:24:39 -08:00
2022-04-29 14:38:03 -07:00
2022-02-17 09:11:57 -06:00
2022-05-06 14:49:44 -05:00
2022-02-25 10:40:14 -06:00
2022-05-19 23:25:47 -04:00
2022-07-28 10:06:49 -07:00
2022-06-23 18:41:40 +02:00
2022-08-25 11:45:51 +02:00
2022-07-29 07:49:02 -10:00
d81bd6671f