iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/mmc/host
History
Frank Li 6b22c402df mmc: sdhci-esdhc-imx: fix kernel panic when remove module 
commit a56f44138a2c57047f1ea94ea121af31c595132b upstream.

In sdhci_esdhc_imx_remove() the SDHCI_INT_STATUS in read. Under some
circumstances, this may be done while the device is runtime suspended,
triggering the below splat.

Fix the problem by adding a pm_runtime_get_sync(), before reading the
register, which will turn on clocks etc making the device accessible again.

[ 1811.323148] mmc1: card aaaa removed
[ 1811.347483] Internal error: synchronous external abort: 96000210 [#1] PREEMPT SMP
[ 1811.354988] Modules linked in: sdhci_esdhc_imx(-) sdhci_pltfm sdhci cqhci mmc_block mmc_core [last unloaded: mmc_core]
[ 1811.365726] CPU: 0 PID: 3464 Comm: rmmod Not tainted 5.10.1-sd-99871-g53835a2e8186 #5
[ 1811.373559] Hardware name: Freescale i.MX8DXL EVK (DT)
[ 1811.378705] pstate: 60000005 (nZCv daif -PAN -UAO -TCO BTYPE=--)
[ 1811.384723] pc : sdhci_esdhc_imx_remove+0x28/0x15c [sdhci_esdhc_imx]
[ 1811.391090] lr : platform_drv_remove+0x2c/0x50
[ 1811.395536] sp : ffff800012c7bcb0
[ 1811.398855] x29: ffff800012c7bcb0 x28: ffff00002c72b900
[ 1811.404181] x27: 0000000000000000 x26: 0000000000000000
[ 1811.409497] x25: 0000000000000000 x24: 0000000000000000
[ 1811.414814] x23: ffff0000042b3890 x22: ffff800009127120
[ 1811.420131] x21: ffff00002c4c9580 x20: ffff0000042d0810
[ 1811.425456] x19: ffff0000042d0800 x18: 0000000000000020
[ 1811.430773] x17: 0000000000000000 x16: 0000000000000000
[ 1811.436089] x15: 0000000000000004 x14: ffff000004019c10
[ 1811.441406] x13: 0000000000000000 x12: 0000000000000020
[ 1811.446723] x11: 0101010101010101 x10: 7f7f7f7f7f7f7f7f
[ 1811.452040] x9 : fefefeff6364626d x8 : 7f7f7f7f7f7f7f7f
[ 1811.457356] x7 : 78725e6473607372 x6 : 0000000080808080
[ 1811.462673] x5 : 0000000000000000 x4 : 0000000000000000
[ 1811.467990] x3 : ffff800011ac1cb0 x2 : 0000000000000000
[ 1811.473307] x1 : ffff8000091214d4 x0 : ffff8000133a0030
[ 1811.478624] Call trace:
[ 1811.481081]  sdhci_esdhc_imx_remove+0x28/0x15c [sdhci_esdhc_imx]
[ 1811.487098]  platform_drv_remove+0x2c/0x50
[ 1811.491198]  __device_release_driver+0x188/0x230
[ 1811.495818]  driver_detach+0xc0/0x14c
[ 1811.499487]  bus_remove_driver+0x5c/0xb0
[ 1811.503413]  driver_unregister+0x30/0x60
[ 1811.507341]  platform_driver_unregister+0x14/0x20
[ 1811.512048]  sdhci_esdhc_imx_driver_exit+0x1c/0x3a8 [sdhci_esdhc_imx]
[ 1811.518495]  __arm64_sys_delete_module+0x19c/0x230
[ 1811.523291]  el0_svc_common.constprop.0+0x78/0x1a0
[ 1811.528086]  do_el0_svc+0x24/0x90
[ 1811.531405]  el0_svc+0x14/0x20
[ 1811.534461]  el0_sync_handler+0x1a4/0x1b0
[ 1811.538474]  el0_sync+0x174/0x180
[ 1811.541801] Code: a9025bf5 f9403e95 f9400ea0 9100c000 (b9400000)
[ 1811.547902] ---[ end trace 3fb1a3bd48ff7be5 ]---

Signed-off-by: Frank Li <Frank.Li@nxp.com>
Cc: stable@vger.kernel.org # v4.0+
Link: https://lore.kernel.org/r/20210210181933.29263-1-Frank.Li@nxp.com
[Ulf: Clarified the commit message a bit]
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-04 10:26:49 +01:00
..
alcor.c
mmc: alcor: Fix a resource leak in the error path for ->probe()
2020-05-20 08:20:21 +02:00
android-goldfish.c
MMC core:
2019-07-11 18:11:21 -07:00
atmel-mci.c
mmc: atmel-mci: Mark expected switch fall-throughs
2019-09-11 15:58:39 +02:00
au1xmmc.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
bcm2835.c
Merge branch 'fixes' into next
2019-09-11 15:59:01 +02:00
cavium-octeon.c
…
cavium-thunderx.c
…
cavium.c
mmc: cavium: Add the missing dma unmap when the dma has finished.
2019-08-06 18:59:14 +02:00
cavium.h
…
cb710-mmc.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
cb710-mmc.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
cqhci.c
mmc: cqhci: Add cqhci_deactivate()
2020-09-09 19:12:33 +02:00
cqhci.h
mmc: cqhci: Add cqhci_deactivate()
2020-09-09 19:12:33 +02:00
davinci_mmc.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
dw_mmc-bluefield.c
mmc: dw_mmc-bluefield: : Fix the license information
2019-01-22 08:46:20 +01:00
dw_mmc-exynos.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dw_mmc-exynos.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dw_mmc-hi3798cv200.c
mmc: dw_mmc: hi3798cv200: make array degrees static const, makes object smaller
2019-09-11 16:10:37 +02:00
dw_mmc-k3.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dw_mmc-pci.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dw_mmc-pltfm.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dw_mmc-pltfm.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dw_mmc-rockchip.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dw_mmc-zx.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dw_mmc-zx.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dw_mmc.c
mmc: dw_mmc: Re-store SDIO IRQs mask at system resume
2019-09-11 16:10:18 +02:00
dw_mmc.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
jz4740_mmc.c
mmc: jz4740: Drop dependency on arch header
2019-09-11 15:58:39 +02:00
Kconfig
mmc: host: sdhci-pci: Add Genesys Logic GL975x support
2019-09-27 20:48:20 +02:00
Makefile
mmc: host: sdhci-pci: Add Genesys Logic GL975x support
2019-09-27 20:48:20 +02:00
meson-gx-mmc.c
mmc: meson-gx: limit segments to 1 when dram-access-quirk is needed
2020-07-16 08:16:46 +02:00
meson-mx-sdio.c
mmc: meson-mx-sdio: trigger a soft reset after a timeout or CRC error
2020-06-22 09:30:56 +02:00
mmc_spi.c
mmc: spi: Toggle SPI polarity, do not hardcode it
2020-02-11 04:35:19 -08:00
mmci_qcom_dml.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284
2019-06-05 17:36:37 +02:00
mmci_stm32_sdmmc.c
mmc: mmci_sdmmc: fix DMA API warning overlapping mappings
2020-06-17 16:40:37 +02:00
mmci.c
mmc: mmci: Support any block sizes for ux500v2 and qcom variant
2020-07-22 09:32:57 +02:00
mmci.h
mmc: mmci: Support any block sizes for ux500v2 and qcom variant
2020-07-22 09:32:57 +02:00
moxart-mmc.c
…
mtk-sd.c
mmc: mediatek: add optional module reset property
2020-09-09 19:12:33 +02:00
mvsdio.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
mvsdio.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
mxcmmc.c
mmc: Remove dev_err() usage after platform_get_irq()
2019-09-11 15:58:39 +02:00
mxs-mmc.c
mmc: mxs: fix flags passed to dmaengine_prep_slave_sg
2019-10-21 16:16:38 +02:00
of_mmc_spi.c
mmc: mmc_spi: Convert to use SPDX identifier
2019-04-15 11:55:54 +02:00
omap_hsmmc.c
mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid of pandora_wl1251_init_card
2019-12-17 19:56:40 +01:00
omap.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
pxamci.c
mmc: pxamci: Fix error return code in pxamci_probe
2020-12-30 11:51:11 +01:00
pxamci.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
renesas_sdhi_core.c
mmc: renesas_sdhi_core: Add missing tmio_mmc_host_free() at remove
2020-11-18 19:20:31 +01:00
renesas_sdhi_internal_dmac.c
mmc: renesas_sdhi_internal_dmac: Fix DMA buffer alignment from 8 to 128-bytes
2021-03-04 10:26:31 +01:00
renesas_sdhi_sys_dmac.c
mmc: renesas_sdhi_sys_dmac: Remove all R-Car Gen3 SoCs
2019-09-11 15:58:39 +02:00
renesas_sdhi.h
mmc: renesas_sdhi: update copyright information
2019-04-15 11:55:54 +02:00
rtsx_pci_sdmmc.c
mmc: rtsx_pci: Fix support for speed-modes that relies on tuning
2020-03-25 08:25:54 +01:00
rtsx_usb_sdmmc.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
s3cmci.c
mmc: Remove dev_err() usage after platform_get_irq()
2019-09-11 15:58:39 +02:00
s3cmci.h
MMC core:
2019-07-11 18:11:21 -07:00
sdhci_am654.c
mmc: sdhci_am654: Reset Command and Data line after tuning
2020-01-29 16:45:28 +01:00
sdhci_f_sdh30.c
mmc: Remove dev_err() usage after platform_get_irq()
2019-09-11 15:58:39 +02:00
sdhci-acpi.c
mmc: sdhci-acpi: AMDI0040: Set SDHCI_QUIRK2_PRESET_VALUE_BROKEN
2020-11-05 11:43:23 +01:00
sdhci-bcm-kona.c
mmc: sdhci-bcm-kona: Drop unused includes
2019-02-25 08:40:58 +01:00
sdhci-brcmstb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
sdhci-cadence.c
mmc: sdhci-cadence: do not use hardware tuning for SD mode
2020-08-19 08:16:01 +02:00
sdhci-cns3xxx.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
sdhci-dove.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 176
2019-05-30 11:29:19 -07:00
sdhci-esdhc-imx.c
mmc: sdhci-esdhc-imx: fix kernel panic when remove module
2021-03-04 10:26:49 +01:00
sdhci-esdhc.h
mmc: sdhci-of-esdhc: fix up erratum A-008171 workaround
2020-01-04 19:19:18 +01:00
sdhci-iproc.c
mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711
2019-10-09 11:05:50 +02:00
sdhci-msm.c
mmc: sdhci-msm: Add retries when all tuning phases are found valid
2020-09-17 13:47:44 +02:00
sdhci-of-arasan.c
mmc: sdhci-of-arasan: Add Support for Intel LGM eMMC
2019-09-11 15:58:39 +02:00
sdhci-of-aspeed.c
mmc: sdhci-of-aspeed: Fix clock divider calculation
2020-07-29 10:18:44 +02:00
sdhci-of-at91.c
mmc: sdhci-of-at91: fix cd-gpios for SAMA5D2
2020-03-25 08:25:54 +01:00
sdhci-of-dwcmshc.c
mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation
2018-10-08 11:40:43 +02:00
sdhci-of-esdhc.c
mmc: sdhci-of-esdhc: Handle pulse width detection erratum for more SoCs
2020-11-18 19:20:31 +01:00
sdhci-of-hlwd.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
sdhci-omap.c
mmc: sdhci-omap: Fix busy detection by enabling MMC_CAP_NEED_RSP_BUSY
2020-04-01 11:01:28 +02:00
sdhci-pci-arasan.c
mmc:host:sdhci-pci:Addition of Arasan PCI Controller with integrated phy.
2018-01-04 12:46:11 +01:00
sdhci-pci-core.c
mmc: sdhci-pci: Prefer SDR25 timing for High Speed mode for BYT-based Intel controllers
2020-11-24 13:29:24 +01:00
sdhci-pci-data.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
sdhci-pci-dwc-mshc.c
mmc: sdhci-pci-dwc-mshc: synopsys dwc mshc support
2018-07-16 11:21:45 +02:00
sdhci-pci-gli.c
mmc: sdhci-pci-gli: Fix can not access GL9750 after reboot from Windows 10
2020-05-20 08:20:21 +02:00
sdhci-pci-o2micro.c
mmc: sdhci-pci-o2micro: Bug fix for O2 host controller Seabird1
2020-08-19 08:16:04 +02:00
sdhci-pci.h
mmc: sdhci-pci: Add support for Intel JSL
2020-02-01 09:34:50 +00:00
sdhci-pic32.c
mmc: sdhci-*: Don't emit error msg if sdhci_add_host() fails
2018-05-29 12:24:26 +02:00
sdhci-pltfm.c
mmc: Remove dev_err() usage after platform_get_irq()
2019-09-11 15:58:39 +02:00
sdhci-pltfm.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
sdhci-pxav2.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
sdhci-pxav3.c
mmc: sdhci-sprd: Fix the incorrect soft reset operation when runtime resuming
2019-08-06 18:59:14 +02:00
sdhci-s3c.c
mmc: Remove dev_err() usage after platform_get_irq()
2019-09-11 15:58:39 +02:00
sdhci-sirf.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 4
2019-05-21 11:28:40 +02:00
sdhci-spear.c
mmc: sdhci: spear: Use the slot GPIO descriptor
2018-10-08 11:40:43 +02:00
sdhci-sprd.c
mmc: sdhci-sprd: Fix some resource leaks in the remove function
2021-03-04 10:26:31 +01:00
sdhci-st.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
sdhci-tegra.c
sdhci: tegra: Add missing TMCLK for data timeout
2020-09-09 19:12:36 +02:00
sdhci-xenon-phy.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 372
2019-06-05 17:37:10 +02:00
sdhci-xenon.c
mmc: sdhci-xenon: fix 1.8v regulator stabilization
2021-01-27 11:47:41 +01:00
sdhci-xenon.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 372
2019-06-05 17:37:10 +02:00
sdhci.c
mmc: sdhci: Use Auto CMD Auto Select only when v4_mode is true
2020-11-05 11:43:36 +01:00
sdhci.h
mmc: sdhci: Refactor sdhci_set_timeout()
2020-04-17 10:50:25 +02:00
sdricoh_cs.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
sh_mmcif.c
mmc: sh_mmcif: Use platform_get_irq_optional() for optional interrupt
2019-10-03 11:38:37 +02:00
sunxi-mmc.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
tifm_sd.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
tmio_mmc_core.c
mmc: tmio: Further fixup runtime PM management at remove
2020-06-17 16:40:37 +02:00
tmio_mmc.c
Revert "mmc: tmio: move runtime PM enablement to the driver implementations"
2019-09-13 13:48:35 +02:00
tmio_mmc.h
mmc: tmio: Fixup runtime PM management during probe
2019-09-13 13:49:04 +02:00
toshsd.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
toshsd.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
uniphier-sd.c
mmc: uniphier-sd: call devm_request_irq() after tmio_mmc_host_probe()
2020-06-17 16:40:37 +02:00
usdhi6rol0.c
mmc: usdhi6rol0: Fix a resource leak in the error handling path of the probe
2021-03-04 10:26:31 +01:00
ushc.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
via-sdmmc.c
mmc: via-sdmmc: Fix data race bug
2020-11-05 11:43:16 +01:00
vub300.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 372
2019-06-05 17:37:10 +02:00
wbsd.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
wbsd.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
wmt-sdmmc.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00