iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/video/fbdev
History
Zqiang 64677f10e5 udlfb: Fix memory leak in dlfb_usb_probe 
commit 5c0e4110f751934e748a66887c61f8e73805f0f9 upstream.

The dlfb_alloc_urb_list function is called in dlfb_usb_probe function,
after that if an error occurs, the dlfb_free_urb_list function need to
be called.

BUG: memory leak
unreferenced object 0xffff88810adde100 (size 32):
  comm "kworker/1:0", pid 17, jiffies 4294947788 (age 19.520s)
  hex dump (first 32 bytes):
    10 30 c3 0d 81 88 ff ff c0 fa 63 12 81 88 ff ff  .0........c.....
    00 30 c3 0d 81 88 ff ff 80 d1 3a 08 81 88 ff ff  .0........:.....
  backtrace:
    [<0000000019512953>] kmalloc include/linux/slab.h:552 [inline]
    [<0000000019512953>] kzalloc include/linux/slab.h:664 [inline]
    [<0000000019512953>] dlfb_alloc_urb_list drivers/video/fbdev/udlfb.c:1892 [inline]
    [<0000000019512953>] dlfb_usb_probe.cold+0x289/0x988 drivers/video/fbdev/udlfb.c:1704
    [<0000000072160152>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<00000000a8d6726f>] really_probe+0x159/0x480 drivers/base/dd.c:554
    [<00000000c3ce4b0e>] driver_probe_device+0x84/0x100 drivers/base/dd.c:738
    [<00000000e942e01c>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:844
    [<00000000de0a5a5c>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<00000000463fbcb4>] __device_attach+0x122/0x250 drivers/base/dd.c:912
    [<00000000b881a711>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<00000000364bbda5>] device_add+0x5ac/0xc30 drivers/base/core.c:2936
    [<00000000eecca418>] usb_set_configuration+0x9de/0xb90 drivers/usb/core/message.c:2159
    [<00000000edfeca2d>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<000000001830872b>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<00000000a8d6726f>] really_probe+0x159/0x480 drivers/base/dd.c:554
    [<00000000c3ce4b0e>] driver_probe_device+0x84/0x100 drivers/base/dd.c:738
    [<00000000e942e01c>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:844
    [<00000000de0a5a5c>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431

Reported-by: syzbot+c9e365d7f450e8aa615d@syzkaller.appspotmail.com
Signed-off-by: Zqiang <qiang.zhang@windriver.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20201215063022.16746-1-qiang.zhang@windriver.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-07 12:20:42 +01:00
..
aty
video: fbdev: radeon: Fix memleak in radeonfb_pci_register
2020-10-29 09:57:38 +01:00
core
fbmem: add margin check to fb_check_caps()
2020-10-29 09:58:08 +01:00
geode
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
i810
…
intelfb
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
kyro
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
matrox
docs: fb: convert docs to ReST and rename to *.rst
2019-06-14 14:21:11 -06:00
mb862xx
fbdev changes for v5.3:
2019-07-09 09:55:45 -07:00
mbx
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
mmp
video: fbdev/mmp/core: Use struct_size() in kzalloc()
2019-08-19 15:52:28 +02:00
nvidia
video: fbdev: nvidia: Remove dead code
2019-07-23 17:16:48 +02:00
omap
video: fbdev: omapfb_main: Mark expected switch fall-throughs
2019-08-09 19:51:52 -05:00
omap2
omapfb: fix multiple reference count leaks due to pm_runtime_get_sync
2020-09-03 11:26:45 +02:00
riva
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
savage
video: fbdev: savage: fix memory leak on error handling path in probe
2020-08-19 08:16:00 +02:00
sis
video: fbdev: sis: fix null ptr dereference
2020-10-29 09:57:38 +01:00
vermilion
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 63
2019-05-24 17:36:46 +02:00
via
video: fbdev: viafb: Remove dead code
2019-08-19 15:52:28 +02:00
68328fb.c
…
acornfb.c
video: fbdev: acornfb: Mark expected switch fall-through
2019-08-20 19:44:01 -05:00
acornfb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
amba-clcd.c
video: amba-clcd: Spout an error if of_get_display_timing() gives an error
2019-07-26 16:32:28 +02:00
amifb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
arcfb.c
video: fbdev: arcfb: mark expected switch fall-through
2018-10-08 12:57:37 +02:00
arkfb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
asiliantfb.c
…
atafb_iplan2p2.c
fbdev: atafb: Remove obsolete module support
2019-04-01 17:46:55 +02:00
atafb_iplan2p4.c
fbdev: atafb: Remove obsolete module support
2019-04-01 17:46:55 +02:00
atafb_iplan2p8.c
fbdev: atafb: Remove obsolete module support
2019-04-01 17:46:55 +02:00
atafb_mfb.c
fbdev: atafb: Remove obsolete module support
2019-04-01 17:46:55 +02:00
atafb_utils.h
…
atafb.c
m68k: atari: Rename shifter to shifter_st to avoid conflict
2019-08-19 13:24:10 +02:00
atafb.h
…
atmel_lcdfb.c
video: fbdev: atmel_lcdfb: fix return error code in atmel_lcdfb_of_init()
2020-12-30 11:51:08 +01:00
au1100fb.c
au1100fb: fix DMA API abuse
2019-06-03 16:00:08 +02:00
au1100fb.h
au1100fb: fix DMA API abuse
2019-06-03 16:00:08 +02:00
au1200fb.c
au1200fb: don't use DMA_ATTR_NON_CONSISTENT
2019-07-23 17:14:55 +02:00
au1200fb.h
…
broadsheetfb.c
…
bt431.h
…
bt455.h
…
bw2.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
c2p_core.h
fbdev: c2p: Fix link failure on non-inlining
2019-11-04 10:48:14 +01:00
c2p_iplan2.c
…
c2p_planar.c
…
c2p.h
…
carminefb_regs.h
…
carminefb.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
carminefb.h
…
cg3.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
cg6.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
cg14.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
chipsfb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
cirrusfb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
clps711x-fb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cobalt_lcdfb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1
2019-05-21 11:28:39 +02:00
controlfb.c
video: fbdev: controlfb: fix warnings about comparing pointer to 0
2019-06-21 15:13:14 +02:00
controlfb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cyber2000fb.c
fbdev changes for v5.3:
2019-07-09 09:55:45 -07:00
cyber2000fb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
da8xx-fb.c
fbdev: da8xx: use resource management for dma
2019-08-26 17:54:00 +05:30
dnfb.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
edid.h
…
efifb.c
efi: avoid error message when booting under Xen
2020-08-26 10:41:04 +02:00
ep93xx-fb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
fb-puv3.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
ffb.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
fm2fb.c
…
fsl-diu-fb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
g364fb.c
…
gbefb.c
video: fbdev: gbefb: add COMPILE_TEST support
2019-06-07 14:38:07 +02:00
goldfishfb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
grvga.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
gxt4500.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
hecubafb.c
…
hgafb.c
video: hgafb: fix potential NULL pointer dereference
2019-04-01 17:46:58 +02:00
hitfb.c
…
hpfb.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
hyperv_fb.c
video: hyperv_fb: Fix the mmap() regression for v5.4.y and older
2021-01-12 20:16:17 +01:00
i740_reg.h
…
i740fb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
imsttfb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
imxfb.c
video: fbdev: imxfb: fix a typo in imxfb_probe()
2019-07-05 17:42:13 +02:00
Kconfig
fbdev: aty: SPARC64 requires FB_ATY_CT
2021-03-04 10:26:18 +01:00
leo.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
macfb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 139
2019-05-30 11:25:16 -07:00
macmodes.c
…
macmodes.h
…
Makefile
Main MIPS changes for v5.4:
2019-09-22 09:30:30 -07:00
maxinefb.c
…
metronomefb.c
video: fbdev: metronomefb: fix some off by one bugs
2018-07-24 19:11:26 +02:00
mx3fb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
n411.c
…
neofb.c
video: fbdev: neofb: fix memory leak in neo_scan_monitor()
2020-08-19 08:16:00 +02:00
ocfb.c
…
offb.c
video: offb: annotate implicit fall throughs
2019-02-08 19:24:46 +01:00
p9100.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
platinumfb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
platinumfb.h
…
pm2fb.c
video: fbdev: mark expected switch fall-throughs
2018-07-24 19:11:28 +02:00
pm3fb.c
…
pmag-aa-fb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
pmag-ba-fb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
pmagb-b-fb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
ps3fb.c
fbmem: pull fbcon_update_vcs() out of fb_set_var()
2020-09-03 11:27:09 +02:00
pvr2fb.c
video: fbdev: pvr2fb: initialize variables
2020-11-05 11:43:15 +01:00
pxa3xx-gcu.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
pxa3xx-gcu.h
…
pxa168fb.c
pxa168fb: Fix the function used to release some memory in an error handling path
2020-02-24 08:36:25 +01:00
pxa168fb.h
…
pxafb.c
video: pxafb: Fix the function used to balance a 'dma_alloc_coherent()' call
2020-08-19 08:16:06 +02:00
pxafb.h
video: pxafb: Remove cpufreq policy notifier
2019-08-26 10:02:02 +02:00
q40fb.c
…
s1d13xxxfb.c
…
s3c2410fb.c
video: fbdev: Use dev_get_drvdata()
2019-05-06 15:57:47 +02:00
s3c2410fb.h
…
s3c-fb.c
fbdev changes for v5.3:
2019-07-09 09:55:45 -07:00
s3fb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
sa1100fb.c
video: sa1100fb: Remove cpufreq policy notifier
2019-08-26 10:02:02 +02:00
sa1100fb.h
video: sa1100fb: Remove cpufreq policy notifier
2019-08-26 10:02:02 +02:00
sbuslib.c
fbdev: sbuslib: integer overflow in sbusfb_ioctl_helper()
2018-10-08 12:57:36 +02:00
sbuslib.h
…
sh7760fb.c
docs: fb: convert docs to ReST and rename to *.rst
2019-06-14 14:21:11 -06:00
sh_mobile_lcdcfb.c
video: fbdev: sh_mobile_lcdcfb: Mark expected switch fall-through
2019-08-19 15:52:26 +02:00
sh_mobile_lcdcfb.h
fbdev/sh_mobile: remove sh_mobile_lcdc_display_notify
2019-06-12 20:28:11 +02:00
simplefb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288
2019-06-05 17:36:37 +02:00
skeletonfb.c
…
sm501fb.c
video: fbdev: sm501fb: convert platform driver to use dev_groups
2019-08-02 13:22:37 +02:00
sm712.h
fbdev: sm712fb: use 1024x768 by default on non-MIPS, fix garbled display
2019-04-01 17:46:59 +02:00
sm712fb.c
video: fbdev: sm712fb: fix an issue about iounmap for a wrong address
2020-08-19 08:16:06 +02:00
smscufx.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
ssd1307fb.c
video: ssd1307fb: Add devicetree configuration of display setup
2019-07-23 17:26:56 +02:00
sstfb.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
sticore.h
…
stifb.c
video/fbdev/stifb: Fix spelling mistake in fall-through annotation
2018-09-26 18:50:54 +02:00
sunxvr500.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
sunxvr1000.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
sunxvr2500.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
tcx.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tdfxfb.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tgafb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
tmiofb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
tridentfb.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
udlfb.c
udlfb: Fix memory leak in dlfb_usb_probe
2021-03-07 12:20:42 +01:00
uvesafb.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
valkyriefb.c
powerpc, fbdev: Use NV_CMODE and NV_VMODE only when CONFIG_PPC32 && CONFIG_PPC_PMAC && CONFIG_NVRAM
2019-01-22 10:21:45 +01:00
valkyriefb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
vesafb.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
vfb.c
…
vga16fb.c
video: fbdev: vga16fb: fix setting of pixclock because a pass-by-value error
2020-10-29 09:57:38 +01:00
vt8500lcdfb.c
video: vt8500lcdfb: fix fallthrough warning
2020-06-17 16:40:33 +02:00
vt8500lcdfb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
vt8623fb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
w100fb.c
video: fbdev: w100fb: Fix a potential double free.
2020-06-17 16:40:33 +02:00
w100fb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
wm8505fb_regs.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
wm8505fb.c
video: fbdev: wm8505fb: convert platform driver to use dev_groups
2019-08-02 13:20:22 +02:00
wmt_ge_rops.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
wmt_ge_rops.h
…
xen-fbfront.c
xen, fbfront: mark expected switch fall-through
2019-04-01 17:46:57 +02:00
xilinxfb.c
…