iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/btrfs
History
Josef Bacik 0ed102453a btrfs: do not BUG_ON in link_to_fixup_dir 
[ Upstream commit 91df99a6eb50d5a1bc70fff4a09a0b7ae6aab96d ]

While doing error injection testing I got the following panic

  kernel BUG at fs/btrfs/tree-log.c:1862!
  invalid opcode: 0000 [#1] SMP NOPTI
  CPU: 1 PID: 7836 Comm: mount Not tainted 5.13.0-rc1+ #305
  Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-2.fc32 04/01/2014
  RIP: 0010:link_to_fixup_dir+0xd5/0xe0
  RSP: 0018:ffffb5800180fa30 EFLAGS: 00010216
  RAX: fffffffffffffffb RBX: 00000000fffffffb RCX: ffff8f595287faf0
  RDX: ffffb5800180fa37 RSI: ffff8f5954978800 RDI: 0000000000000000
  RBP: ffff8f5953af9450 R08: 0000000000000019 R09: 0000000000000001
  R10: 000151f408682970 R11: 0000000120021001 R12: ffff8f5954978800
  R13: ffff8f595287faf0 R14: ffff8f5953c77dd0 R15: 0000000000000065
  FS:  00007fc5284c8c40(0000) GS:ffff8f59bbd00000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 00007fc5287f47c0 CR3: 000000011275e002 CR4: 0000000000370ee0
  Call Trace:
   replay_one_buffer+0x409/0x470
   ? btree_read_extent_buffer_pages+0xd0/0x110
   walk_up_log_tree+0x157/0x1e0
   walk_log_tree+0xa6/0x1d0
   btrfs_recover_log_trees+0x1da/0x360
   ? replay_one_extent+0x7b0/0x7b0
   open_ctree+0x1486/0x1720
   btrfs_mount_root.cold+0x12/0xea
   ? __kmalloc_track_caller+0x12f/0x240
   legacy_get_tree+0x24/0x40
   vfs_get_tree+0x22/0xb0
   vfs_kern_mount.part.0+0x71/0xb0
   btrfs_mount+0x10d/0x380
   ? vfs_parse_fs_string+0x4d/0x90
   legacy_get_tree+0x24/0x40
   vfs_get_tree+0x22/0xb0
   path_mount+0x433/0xa10
   __x64_sys_mount+0xe3/0x120
   do_syscall_64+0x3d/0x80
   entry_SYSCALL_64_after_hwframe+0x44/0xae

We can get -EIO or any number of legitimate errors from
btrfs_search_slot(), panicing here is not the appropriate response.  The
error path for this code handles errors properly, simply return the
error.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-06-03 08:59:11 +02:00
..
tests
btrfs: Correctly handle empty trees in find_first_clear_extent_bit
2020-02-11 04:35:34 -08:00
acl.c
btrfs: cleanup btrfs_setxattr_trans and drop transaction parameter
2019-04-29 19:02:44 +02:00
async-thread.c
Btrfs: fix crash during unmount due to race with delayed inode workers
2020-04-17 10:50:15 +02:00
async-thread.h
Btrfs: fix crash during unmount due to race with delayed inode workers
2020-04-17 10:50:15 +02:00
backref.c
btrfs: backref, use correct count to resolve normal data refs
2021-02-07 15:35:47 +01:00
backref.h
btrfs: fiemap: preallocate ulists for btrfs_check_shared
2019-07-01 13:34:53 +02:00
block-group.c
btrfs: scrub: Don't check free space before marking a block group RO
2021-03-20 10:39:46 +01:00
block-group.h
btrfs: scrub: Don't check free space before marking a block group RO
2021-03-20 10:39:46 +01:00
block-rsv.c
btrfs: force chunk allocation if our global rsv is larger than metadata
2020-06-22 09:31:13 +02:00
block-rsv.h
btrfs: migrate the global_block_rsv helpers to block-rsv.c
2019-07-02 12:30:55 +02:00
btrfs_inode.h
btrfs: remove assumption about csum type form btrfs_print_data_csum_error()
2019-07-01 13:35:02 +02:00
check-integrity.c
btrfs: fix possible NULL-pointer dereference in integrity checks
2020-02-24 08:36:53 +01:00
check-integrity.h
…
compression.c
btrfs: move cond_wake_up functions out of ctree
2019-09-09 14:59:15 +02:00
compression.h
btrfs: compression: replace set_level callbacks by a common helper
2019-09-09 14:59:11 +02:00
ctree.c
btrfs: fix race when picking most recent mod log operation for an old root
2021-05-11 14:04:14 +02:00
ctree.h
btrfs: fix backport of 2175bf57dc952 in 5.4.95
2021-02-23 15:02:26 +01:00
delalloc-space.c
Btrfs: fix qgroup double free after failure to reserve metadata for delalloc
2019-10-17 20:13:44 +02:00
delalloc-space.h
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
delayed-inode.c
btrfs: free correct amount of space in btrfs_delayed_inode_reserve_metadata
2021-03-09 11:09:37 +01:00
delayed-inode.h
…
delayed-ref.c
Btrfs: fix race between adding and putting tree mod seq elements and nodes
2020-02-11 04:35:34 -08:00
delayed-ref.h
btrfs: migrate the delayed refs rsv code
2019-07-04 17:26:17 +02:00
dev-replace.c
btrfs: dev-replace: fail mount if we don't have replace item with target device
2020-11-18 19:20:29 +01:00
dev-replace.h
btrfs: get fs_info from trans in btrfs_run_dev_replace
2019-04-29 19:02:43 +02:00
dir-item.c
btrfs: remove unused parameter fs_info from btrfs_extend_item
2019-04-29 19:02:50 +02:00
disk-io.c
btrfs: fix overflow when copying corrupt csums for a message
2020-10-01 13:18:24 +02:00
disk-io.h
btrfs: Make reada_tree_block_flagged private
2019-09-09 14:59:11 +02:00
export.c
btrfs: export helpers for subvolume name/id resolution
2020-08-26 10:40:49 +02:00
export.h
btrfs: export helpers for subvolume name/id resolution
2020-08-26 10:40:49 +02:00
extent_io.c
btrfs: return whole extents in fiemap
2021-06-03 08:59:11 +02:00
extent_io.h
btrfs: trim: fix underflow in trim length to prevent access beyond device boundary
2020-12-30 11:51:37 +01:00
extent_map.c
Btrfs: fix race between using extent maps and merging them
2020-02-19 19:53:00 +01:00
extent_map.h
btrfs: Remove impossible condition from mergable_maps
2019-02-25 14:13:21 +01:00
extent-tree.c
btrfs: don't get an EINTR during drop_snapshot for reloc
2021-01-27 11:47:40 +01:00
file-item.c
btrfs: do not ignore error from btrfs_next_leaf() when inserting checksums
2020-06-22 09:30:55 +02:00
file.c
btrfs: unlock extents in btrfs_zero_range in case of quota reservation errors
2021-03-09 11:09:37 +01:00
free-space-cache.c
btrfs: clarify error returns values in __load_free_space_cache
2021-03-04 10:26:24 +01:00
free-space-cache.h
btrfs: move struct io_ctl to free-space-cache.h
2019-09-09 14:59:15 +02:00
free-space-tree.c
btrfs: fix possible free space tree corruption with online conversion
2021-02-03 23:25:57 +01:00
free-space-tree.h
btrfs: move basic block_group definitions to their own header
2019-09-09 14:59:03 +02:00
inode-item.c
btrfs: Make btrfs_find_name_in_ext_backref return struct btrfs_inode_extref
2019-09-09 14:59:16 +02:00
inode-map.c
btrfs: qgroup: Always free PREALLOC META reserve in btrfs_delalloc_release_extents()
2019-10-15 18:50:07 +02:00
inode-map.h
…
inode.c
btrfs: avoid RCU stalls while running delayed iputs
2021-05-26 12:05:16 +02:00
ioctl.c
btrfs: fix metadata extent leak after failure to create subvolume
2021-05-11 14:04:04 +02:00
Kconfig
btrfs: Fix build error while LIBCRC32C is module
2019-07-17 17:03:30 +02:00
locking.c
btrfs: move cond_wake_up functions out of ctree
2019-09-09 14:59:15 +02:00
locking.h
btrfs: Remove unused locking functions
2019-09-09 14:58:59 +02:00
lzo.c
btrfs: compression: replace set_level callbacks by a common helper
2019-09-09 14:59:11 +02:00
Makefile
btrfs: migrate the block group lookup code
2019-09-09 14:59:04 +02:00
misc.h
btrfs: move math functions to misc.h
2019-09-09 14:59:15 +02:00
ordered-data.c
Btrfs: fix btrfs_wait_ordered_range() so that it waits for all ordered extents
2020-02-28 17:22:24 +01:00
ordered-data.h
btrfs: don't assume ordered sums to be 4 bytes
2019-07-01 13:35:00 +02:00
orphan.c
…
print-tree.c
btrfs: require only sector size alignment for parent eb bytenr
2020-09-17 13:47:51 +02:00
print-tree.h
…
props.c
btrfs: rename the btrfs_calc_*_metadata_size helpers
2019-09-09 14:59:13 +02:00
props.h
btrfs: delete unused function btrfs_set_prop_trans
2019-04-29 19:02:54 +02:00
qgroup.c
btrfs: fix transaction leak and crash after RO remount caused by qgroup rescan
2021-01-19 18:26:14 +01:00
qgroup.h
btrfs: make btrfs_qgroup_check_reserved_leak take btrfs_inode
2020-09-03 11:26:47 +02:00
raid56.c
btrfs: fix raid6 qstripe kmap
2021-03-09 11:09:37 +01:00
raid56.h
btrfs: constify map parameter for nr_parity_stripes and nr_data_stripes
2019-07-01 13:34:58 +02:00
rcu-string.h
…
reada.c
btrfs: fix readahead hang and use-after-free after removing a device
2020-11-05 11:43:27 +01:00
ref-verify.c
btrfs: ref-verify: fix memory leak in btrfs_ref_tree_mod
2020-11-18 19:20:28 +01:00
ref-verify.h
btrfs: ref-verify: Use btrfs_ref to refactor btrfs_ref_tree_mod()
2019-04-29 19:02:49 +02:00
relocation.c
btrfs: convert logic BUG_ON()'s in replace_path to ASSERT()'s
2021-05-11 14:04:07 +02:00
root-tree.c
btrfs: do not delete mismatched root refs
2020-01-23 08:22:40 +01:00
scrub.c
btrfs: scrub: Don't check free space before marking a block group RO
2021-03-20 10:39:46 +01:00
send.c
btrfs: send: fix invalid clone operations when cloning from the same file and root
2021-01-27 11:47:41 +01:00
send.h
…
space-info.c
btrfs: take overcommit into account in inc_block_group_ro
2020-10-17 10:11:21 +02:00
space-info.h
btrfs: take overcommit into account in inc_block_group_ro
2020-10-17 10:11:21 +02:00
struct-funcs.c
btrfs: tie extent buffer and it's token together
2019-09-09 14:59:16 +02:00
super.c
btrfs: fix transaction leak and crash after RO remount caused by qgroup rescan
2021-01-19 18:26:14 +01:00
sysfs.c
btrfs: sysfs: use NOFS for device creation
2020-08-21 13:05:22 +02:00
sysfs.h
btrfs: sysfs: move helper macros to sysfs.c
2019-09-09 14:59:08 +02:00
transaction.c
btrfs: fix error handling in commit_fs_roots
2021-03-07 12:20:47 +01:00
transaction.h
btrfs: add wrapper for transaction abort predicate
2020-08-26 10:40:49 +02:00
tree-checker.c
btrfs: tree-checker: check if chunk item end overflows
2021-01-19 18:26:13 +01:00
tree-checker.h
btrfs: get fs_info from eb in btrfs_check_chunk_valid
2019-04-29 19:02:39 +02:00
tree-defrag.c
btrfs: open code now trivial btrfs_set_lock_blocking
2019-02-25 14:13:27 +01:00
tree-log.c
btrfs: do not BUG_ON in link_to_fixup_dir
2021-06-03 08:59:11 +02:00
tree-log.h
btrfs: get fs_info from trans in btrfs_set_log_full_commit
2019-04-29 19:02:41 +02:00
ulist.c
…
ulist.h
…
uuid-tree.c
btrfs: handle ENOENT in btrfs_uuid_tree_iterate
2019-12-31 16:42:05 +01:00
volumes.c
btrfs: fix lockdep splat in btrfs_recover_relocation
2021-01-27 11:47:40 +01:00
volumes.h
btrfs: fix readahead hang and use-after-free after removing a device
2020-11-05 11:43:27 +01:00
xattr.c
btrfs: fix warning when creating a directory with smack enabled
2021-03-09 11:09:37 +01:00
xattr.h
btrfs: cleanup btrfs_setxattr_trans and drop transaction parameter
2019-04-29 19:02:44 +02:00
zlib.c
btrfs: compression: replace set_level callbacks by a common helper
2019-09-09 14:59:11 +02:00
zstd.c
btrfs: move cond_wake_up functions out of ctree
2019-09-09 14:59:15 +02:00