linux

iv/linux

History

Dan Carpenter 6b121dc680 soc: aspeed: fix a ternary sign expansion bug

[ Upstream commit 5ffa828534036348fa90fb3079ccc0972d202c4a ]

The intent here was to return negative error codes but it actually
returns positive values.  The problem is that type promotion with
ternary operations is quite complicated.

"ret" is an int.  "copied" is a u32.  And the snoop_file_read() function
returns long.  What happens is that "ret" is cast to u32 and becomes
positive then it's cast to long and it's still positive.

Fix this by removing the ternary so that "ret" is type promoted directly
to long.

Fixes: 3772e5da4454 ("drivers/misc: Aspeed LPC snoop output using misc chardev")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Patrick Venture <venture@google.com>
Link: https://lore.kernel.org/r/YIE90PSXsMTa2Y8n@mwanda
Link: https://lore.kernel.org/r/20210423000919.1249474-1-joel@jms.id.au'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2021-05-14 09:44:23 +02:00

actions

…

amlogic

soc: amlogic: canvas: add missing put_device() call in meson_canvas_get()

2020-12-30 11:51:15 +01:00

aspeed

soc: aspeed: fix a ternary sign expansion bug

2021-05-14 09:44:23 +02:00

atmel

drivers: soc: atmel: add null entry at the end of at91_soc_allowed_list[]

2021-02-03 23:25:57 +01:00