iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv4
History
Jonathon Reinhart 9884f74510 net: Only allow init netns to set default tcp cong to a restricted algo 
commit 8d432592f30fcc34ef5a10aac4887b4897884493 upstream.

tcp_set_default_congestion_control() is netns-safe in that it writes
to &net->ipv4.tcp_congestion_control, but it also sets
ca->flags |= TCP_CONG_NON_RESTRICTED which is not namespaced.
This has the unintended side-effect of changing the global
net.ipv4.tcp_allowed_congestion_control sysctl, despite the fact that it
is read-only: 97684f0970f6 ("net: Make tcp_allowed_congestion_control
readonly in non-init netns")

Resolve this netns "leak" by only allowing the init netns to set the
default algorithm to one that is restricted. This restriction could be
removed if tcp_allowed_congestion_control were namespace-ified in the
future.

This bug was uncovered with
https://github.com/JonathonReinhart/linux-netns-sysctl-verify

Fixes: 6670e1524477 ("tcp: Namespace-ify sysctl_tcp_default_congestion_control")
Signed-off-by: Jonathon Reinhart <jonathon.reinhart@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-05-14 09:44:33 +02:00
..
bpfilter
SPDX update for 5.2-rc2, round 1
2019-05-21 12:33:38 -07:00
netfilter
netfilter: arp_tables: add pre_exit hook for table unregister
2021-04-21 12:56:16 +02:00
af_inet.c
net: remove empty inet_exit_net
2019-08-19 18:22:54 -07:00
ah4.c
xfrm: remove type and offload_type map from xfrm_state_afinfo
2019-06-06 08:34:50 +02:00
arp.c
Exempt multicast addresses from five-second neighbor lifetime
2020-11-24 13:28:56 +01:00
cipso_ipv4.c
cipso,calipso: resolve a number of problems with the DOI refcounts
2021-03-17 17:03:35 +01:00
datagram.c
inet: stop leaking jiffies on the wire
2019-11-01 14:57:52 -07:00
devinet.c
devinet: fix memleak in inetdev_init()
2020-06-10 20:24:54 +02:00
esp4_offload.c
esp: delete NETIF_F_SCTP_CRC bit from features for esp offload
2021-04-14 08:24:13 +02:00
esp4.c
esp: avoid unneeded kmap_atomic call
2021-01-23 15:57:58 +01:00
fib_frontend.c
ipv4: Ignore ECN bits for fib lookups in fib_compute_spec_dst()
2021-01-12 20:16:14 +01:00
fib_lookup.h
ipv4: Use accessors for fib_info nexthop data
2019-06-04 19:26:49 -07:00
fib_notifier.c
…
fib_rules.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2019-06-07 11:00:14 -07:00
fib_semantics.c
net: Fix the arp error in some cases
2020-06-30 15:36:44 -04:00
fib_trie.c
ipv4: Silence suspicious RCU usage warning
2020-09-12 14:18:54 +02:00
fou.c
fou: Fix IPv6 netlink policy
2020-01-29 16:45:22 +01:00
gre_demux.c
erspan: fix version 1 check in gre_parse_header()
2021-01-12 20:16:15 +01:00
gre_offload.c
net: gre: recompute gre csum for sctp over gre tunnels
2020-08-11 15:33:40 +02:00
icmp.c
net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending
2021-03-04 10:26:53 +01:00
igmp.c
net: fix __ip_mc_inc_group usage
2019-08-20 12:48:06 -07:00
inet_connection_sock.c
tcp: relookup sock for RST+ACK packets handled by obsolete req sock
2021-03-30 14:35:26 +02:00
inet_diag.c
inet_diag: Fix error path to cancel the meseage in inet_req_diag_fill()
2020-11-24 13:28:56 +01:00
inet_fragment.c
inet: frags: re-introduce skb coalescing for local delivery
2019-08-08 15:55:10 -07:00
inet_hashtables.c
net: initialize fastreuse on inet_inherit_port
2020-08-19 08:16:23 +02:00
inet_timewait_sock.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
inetpeer.c
inetpeer: fix data-race in inet_putpeer / inet_putpeer
2020-01-04 19:18:39 +01:00
ip_forward.c
ipv4: Revert removal of rt_uses_gateway
2019-09-20 18:23:33 -07:00
ip_fragment.c
inet: frags: re-introduce skb coalescing for local delivery
2019-08-08 15:55:10 -07:00
ip_gre.c
ip_gre: set dev->hard_header_len and dev->needed_headroom properly
2020-10-29 09:58:04 +01:00
ip_input.c
netfilter: drop bridge nf reset from nf_reset
2019-10-01 18:42:15 +02:00
ip_options.c
netfilter: nf_tables: add support for matching IPv4 options
2019-06-21 18:35:51 +02:00
ip_output.c
net: ip: always refragment ip defragmented packets
2021-01-17 14:05:32 +01:00
ip_sockglue.c
ip_sockglue: Fix missing-check bug in ip_ra_control()
2019-05-25 11:00:50 -07:00
ip_tunnel_core.c
ip_tunnel: allow not to count pkts on tstats by setting skb's dev to NULL
2019-06-18 20:48:45 -04:00
ip_tunnel.c
net: ip_tunnel: fix mtu calculation
2021-02-10 09:25:32 +01:00
ip_vti.c
ip_vti: receive ipip packet by calling ip_tunnel_rcv
2020-06-03 08:21:34 +02:00
ipcomp.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2019-07-05 15:01:15 -07:00
ipconfig.c
ipconfig: add carrier_timeout kernel parameter
2019-02-01 15:24:13 -08:00
ipip.c
net: ipip: fix wrong address family in init error path
2020-06-03 08:20:52 +02:00
ipmr_base.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2019-05-07 17:22:09 -07:00
ipmr.c
net: don't return invalid table id error when we fall back to PF_UNSPEC
2020-06-03 08:20:41 +02:00
Kconfig
vti[6]: fix packet tx through bpf_redirect() in XinY cases
2020-04-01 11:02:05 +02:00
Makefile
net: Initial nexthop code
2019-05-28 21:37:30 -07:00
metrics.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
netfilter.c
netfilter: use actual socket sk rather than skb sk when routing harder
2020-11-18 19:20:17 +01:00
netlink.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
nexthop.c
nexthop: Do not flush blackhole nexthops when loopback goes down
2021-03-17 17:03:35 +01:00
ping.c
ipv4: fill fl4_icmp_{type,code} in ping_v4_sendmsg
2020-07-22 09:32:47 +02:00
proc.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2019-06-17 20:20:36 -07:00
protocol.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
raw_diag.c
inet_diag: return classid for all socket types
2020-03-18 07:17:38 +01:00
raw.c
netfilter: drop bridge nf reset from nf_reset
2019-10-01 18:42:15 +02:00
route.c
inet: use bigger hash table for IP ID generation
2021-05-14 09:44:26 +02:00
syncookies.c
net: Update window_clamp if SOCK_RCVBUF is set
2020-11-18 19:20:32 +01:00
sysctl_net_ipv4.c
tcp: correct read of TFO keys on big endian systems
2020-08-19 08:16:23 +02:00
tcp_bbr.c
tcp: only postpone PROBE_RTT if RTT is < current min_rtt estimate
2020-11-24 13:28:59 +01:00
tcp_bic.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_bpf.c
bpf, sockmap: Ensure SO_RCVBUF memory is observed on ingress redirect
2020-11-24 13:29:08 +01:00
tcp_cdg.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_cong.c
net: Only allow init netns to set default tcp cong to a restricted algo
2021-05-14 09:44:33 +02:00
tcp_cubic.c
tcp_cubic: fix spurious HYSTART_DELAY exit upon drop in min RTT
2020-06-30 15:36:47 -04:00
tcp_dctcp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
tcp_dctcp.h
…
tcp_diag.c
tcp: annotate tp->write_seq lockless reads
2019-10-13 10:13:08 -07:00
tcp_fastopen.c
tcp: correct read of TFO keys on big endian systems
2020-08-19 08:16:23 +02:00
tcp_highspeed.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_htcp.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_hybla.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_illinois.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_input.c
tcp: make TCP_USER_TIMEOUT accurate for zero window probes
2021-02-07 15:35:47 +01:00
tcp_ipv4.c
tcp: do not mess with cloned skbs in tcp_add_backlog()
2021-01-27 11:47:55 +01:00
tcp_lp.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_metrics.c
tcp: refactor setting the initial congestion window
2019-05-01 11:47:54 -04:00
tcp_minisocks.c
tcp: relookup sock for RST+ACK packets handled by obsolete req sock
2021-03-30 14:35:26 +02:00
tcp_nv.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_offload.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
tcp_output.c
tcp: make TCP_USER_TIMEOUT accurate for zero window probes
2021-02-07 15:35:47 +01:00
tcp_rate.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
tcp_recovery.c
tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN
2021-02-03 23:26:02 +01:00
tcp_scalable.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_timer.c
tcp: make TCP_USER_TIMEOUT accurate for zero window probes
2021-02-07 15:35:47 +01:00
tcp_ulp.c
bpf: Sockmap/tls, push write_space updates through ulp updates
2020-01-23 08:22:45 +01:00
tcp_vegas.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_vegas.h
…
tcp_veno.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_westwood.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp_yeah.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
tcp.c
tcp: add sanity tests to TCP_QUEUE_SEQ
2021-03-17 17:03:32 +01:00
tunnel4.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
udp_diag.c
inet_diag: return classid for all socket types
2020-03-18 07:17:38 +01:00
udp_impl.h
udp: add missing rehash callback to udplite
2019-01-17 15:01:08 -08:00
udp_offload.c
net: Fix gro aggregation for udp encaps with zero csum
2021-03-17 17:03:30 +01:00
udp_tunnel.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
udp.c
net: udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);
2021-04-14 08:24:16 +02:00
udplite.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
xfrm4_input.c
…
xfrm4_output.c
xfrm: Always set XFRM_TRANSFORMED in xfrm{4,6}_output_finish
2020-04-29 16:33:11 +02:00
xfrm4_policy.c
net: add bool confirm_neigh parameter for dst_ops.update_pmtu
2020-01-04 19:18:58 +01:00
xfrm4_protocol.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
xfrm4_state.c
xfrm: remove eth_proto value from xfrm_state_afinfo
2019-06-06 08:34:50 +02:00
xfrm4_tunnel.c
xfrm: remove type and offload_type map from xfrm_state_afinfo
2019-06-06 08:34:50 +02:00