iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/arch/arm/kernel
History
Yang Jihong efdcd77660 arm_pmu: Fix write counter incorrect in ARMv7 big-endian mode 
commit fdbef8c4e68ad423416aa6cc93d1616d6f8ac5b3 upstream.

Commit 3a95200d3f89 ("arm_pmu: Change API to support 64bit counter values")
changes the input "value" type from 32-bit to 64-bit, which introduces the
following problem: ARMv7 PMU counters is 32-bit width, in big-endian mode,
write counter uses high 32-bit, which writes an incorrect value.

Before:

 Performance counter stats for 'ls':

              2.22 msec task-clock                #    0.675 CPUs utilized
                 0      context-switches          #    0.000 K/sec
                 0      cpu-migrations            #    0.000 K/sec
                49      page-faults               #    0.022 M/sec
        2150476593      cycles                    #  966.663 GHz
        2148588788      instructions              #    1.00  insn per cycle
        2147745484      branches                  # 965435.074 M/sec
        2147508540      branch-misses             #   99.99% of all branches

None of the above hw event counters are correct.

Solution:

"value" forcibly converted to 32-bit type before being written to PMU register.

After:

 Performance counter stats for 'ls':

              2.09 msec task-clock                #    0.681 CPUs utilized
                 0      context-switches          #    0.000 K/sec
                 0      cpu-migrations            #    0.000 K/sec
                46      page-faults               #    0.022 M/sec
           2807301      cycles                    #    1.344 GHz
           1060159      instructions              #    0.38  insn per cycle
            250496      branches                  #  119.914 M/sec
             23192      branch-misses             #    9.26% of all branches

Fixes: 3a95200d3f89 ("arm_pmu: Change API to support 64bit counter values")
Cc: <stable@vger.kernel.org>
Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20210430012659.232110-1-yangjihong1@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-07-14 16:53:02 +02:00
..
.gitignore
…
arch_timer.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
armksyms.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
asm-offsets.c
ARM: 9075/1: kernel: Fix interrupted SMC calls
2021-05-22 11:38:28 +02:00
atags_compat.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
atags_parse.c
ARM: 9011/1: centralize phys-to-virt conversion of DT/ATAGS address
2021-05-19 10:08:32 +02:00
atags_proc.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
atags.h
ARM: 9011/1: centralize phys-to-virt conversion of DT/ATAGS address
2021-05-19 10:08:32 +02:00
bios32.c
PCI: Remove PCI_REASSIGN_ALL_RSRC use on arm and arm64
2017-12-18 23:07:43 -06:00
bugs.c
treewide: fix typos of SPDX-License-Identifier
2019-06-01 18:29:58 +02:00
cpuidle.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 159
2019-05-30 11:26:37 -07:00
crash_dump.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
debug.S
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
devtree.c
ARM: 9011/1: centralize phys-to-virt conversion of DT/ATAGS address
2021-05-19 10:08:32 +02:00
dma-isa.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
dma.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
early_printk.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
efi.c
mm/pgtable: drop pgtable_t variable from pte_fn_t functions
2019-07-12 11:05:46 -07:00
elf.c
Merge branch 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-arm
2017-11-16 12:50:35 -08:00
entry-armv.S
ARM: 9030/1: entry: omit FP emulation for UND exceptions taken in kernel mode
2021-03-24 11:26:35 +01:00
entry-common.S
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
entry-ftrace.S
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
entry-header.S
ARM: uaccess: consolidate uaccess asm to asm/uaccess-asm.h
2020-06-03 08:21:18 +02:00
entry-v7m.S
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
fiq.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fiqasm.S
…
ftrace.c
ARM: function_graph: Simplify with function_graph_enter()
2018-11-27 20:29:52 -05:00
head-common.S
ARM: 8914/1: NOMMU: Fix exc_ret for XIP
2019-10-10 22:23:20 +01:00
head-inflate-data.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
head-nommu.S
ARM: 8914/1: NOMMU: Fix exc_ret for XIP
2019-10-10 22:23:20 +01:00
head.S
ARM: 9027/1: head.S: explicitly map DT even if it lives in the first physical section
2021-05-19 10:08:32 +02:00
hibernate.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194
2019-05-30 11:29:22 -07:00
hw_breakpoint.c
ARM: 9064/1: hw_breakpoint: Do not directly check the event's overflow_handler hook
2021-05-19 10:08:25 +02:00
hyp-stub.S
ARM: 8955/1: virt: Relax arch timer version check during early boot
2020-02-05 21:22:49 +00:00
insn.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
io.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
irq.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
isa.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
iwmmxt.S
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
jump_label.c
jump_label: move 'asm goto' support test to Kconfig
2019-01-06 09:46:51 +09:00
kgdb.c
kgdb/treewide: constify struct kgdb_arch arch_kgdb_ops
2018-12-30 08:33:06 +00:00
machine_kexec.c
ARM: kexec: fix oops after TLB are invalidated
2021-02-17 10:35:16 +01:00
Makefile
ARM: bugs: prepare processor bug infrastructure
2018-05-31 10:39:18 +01:00
module-plts.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
module.c
Modules updates for v5.3
2019-07-18 12:06:57 -07:00
module.lds
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
opcodes.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
paravirt.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
patch.c
ARM: 8839/1: kprobe: make patch_lock a raw_spinlock_t
2019-02-26 11:24:50 +00:00
perf_callchain.c
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
perf_event_v6.c
arm_pmu: Tidy up clear_event_idx call backs
2018-07-10 18:19:02 +01:00
perf_event_v7.c
arm_pmu: Fix write counter incorrect in ARMv7 big-endian mode
2021-07-14 16:53:02 +02:00
perf_event_xscale.c
arm_pmu: Tidy up clear_event_idx call backs
2018-07-10 18:19:02 +01:00
perf_regs.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
pj4-cp0.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
process.c
arm: Implement copy_thread_tls
2020-01-14 20:08:34 +01:00
psci_smp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
ptrace.c
ARM: 8977/1: ptrace: Fix mask for thumb breakpoint hook
2020-06-17 16:40:21 +02:00
reboot.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
reboot.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
relocate_kernel.S
ARM: kexec: fix oops after TLB are invalidated
2021-02-17 10:35:16 +01:00
return_address.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
setup.c
ARM: 9081/1: fix gcc-10 thumb2-kernel regression
2021-06-30 08:47:43 -04:00
signal.c
ARM: ensure the signal page contains defined contents
2021-02-17 10:35:16 +01:00
signal.h
ARM: signal handling support for FDPIC_FUNCPTRS functions
2017-09-10 19:31:46 -04:00
sigreturn_codes.S
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
sleep.S
ARM: 8847/1: pm: fix HYP/SVC mode mismatch when MCPM is used
2019-02-26 11:32:54 +00:00
smccc-call.S
ARM: 9075/1: kernel: Fix interrupted SMC calls
2021-05-22 11:38:28 +02:00
smp_scu.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
smp_tlb.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
smp_twd.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
smp.c
ARM: 8943/1: Fix topology setup in case of CPU hotplug for CONFIG_SCHED_MC
2020-01-17 19:48:55 +01:00
stacktrace.c
ARM: 8948/1: Prevent OOB access in stacktrace
2020-10-01 13:17:29 +02:00
suspend.c
ARM: 9066/1: ftrace: pause/unpause function graph tracer in cpu_suspend()
2021-05-22 11:38:28 +02:00
swp_emulate.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
sys_arm.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
sys_oabi-compat.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
tcm.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194
2019-05-30 11:29:22 -07:00
thumbee.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
time.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
topology.c
ARM: 8943/1: Fix topology setup in case of CPU hotplug for CONFIG_SCHED_MC
2020-01-17 19:48:55 +01:00
traps.c
ARM: 8948/1: Prevent OOB access in stacktrace
2020-10-01 13:17:29 +02:00
unwind.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
v7m.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
vdso.c
arm64: Introduce a way to disable the 32bit vdso
2020-07-22 09:32:50 +02:00
vmlinux-xip.lds.S
vmlinux.lds.h: Move LSM_TABLE into INIT_DATA
2018-10-10 20:40:21 -07:00
vmlinux.lds.h
vmlinux.lds.h: Fix incomplete .text.exit discards
2018-10-12 08:54:58 +11:00
vmlinux.lds.S
ARM: 8757/1: NOMMU: Support PMSAv8 MPU
2018-05-19 11:53:46 +01:00
xscale-cp0.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00