iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/ubifs
History
Zhihao Cheng 1d9d997850 ubifs: Set/Clear I_LINKABLE under i_lock for whiteout inode 
[ Upstream commit a801fcfeef96702fa3f9b22ad56c5eb1989d9221 ]

xfstests-generic/476 reports a warning message as below:

WARNING: CPU: 2 PID: 30347 at fs/inode.c:361 inc_nlink+0x52/0x70
Call Trace:
  do_rename+0x502/0xd40 [ubifs]
  ubifs_rename+0x8b/0x180 [ubifs]
  vfs_rename+0x476/0x1080
  do_renameat2+0x67c/0x7b0
  __x64_sys_renameat2+0x6e/0x90
  do_syscall_64+0x66/0xe0
  entry_SYSCALL_64_after_hwframe+0x44/0xae

Following race case can cause this:
         rename_whiteout(Thread 1)             wb_workfn(Thread 2)
ubifs_rename
  do_rename
                                          __writeback_single_inode
					    spin_lock(&inode->i_lock)
    whiteout->i_state |= I_LINKABLE
                                            inode->i_state &= ~dirty;
---- How race happens on i_state:
    (tmp = whiteout->i_state | I_LINKABLE)
		                           (tmp = inode->i_state & ~dirty)
    (whiteout->i_state = tmp)
		                           (inode->i_state = tmp)
----
					    spin_unlock(&inode->i_lock)
    inc_nlink(whiteout)
    WARN_ON(!(inode->i_state & I_LINKABLE)) !!!

Fix to add i_lock to avoid i_state update race condition.

Fixes: 9e0a1fff8db56ea ("ubifs: Implement RENAME_WHITEOUT")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-07-20 16:10:50 +02:00
..
auth.c
ubifs: Fix memleak in ubifs_init_authentication
2021-03-04 10:26:25 +01:00
budget.c
ubifs: Limit the number of pages in shrink_liability
2019-08-22 17:25:33 +02:00
commit.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336
2019-06-05 17:37:07 +02:00
compress.c
ubifs: Add support for zstd compression.
2019-07-08 19:43:53 +02:00
crypto.c
fscrypt: introduce fscrypt_decrypt_block_inplace()
2019-05-28 10:27:53 -07:00
debug.c
ubifs: dent: Fix some potential memory leaks while iterating entries
2020-11-05 11:43:32 +01:00
debug.h
Driver Core and debugfs changes for 5.3-rc1
2019-07-12 12:24:03 -07:00
dir.c
ubifs: Set/Clear I_LINKABLE under i_lock for whiteout inode
2021-07-20 16:10:50 +02:00
file.c
ubifs: remove broken lazytime support
2020-05-27 17:46:14 +02:00
find.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336
2019-06-05 17:37:07 +02:00
gc.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336
2019-06-05 17:37:07 +02:00
io.c
ubifs: wbuf: Don't leak kernel memory to flash
2020-12-30 11:51:40 +01:00
ioctl.c
ubifs: Fix FS_IOC_SETFLAGS unexpectedly clearing encrypt flag
2020-02-11 04:35:20 -08:00
journal.c
ubifs: journal: Make sure to not dirty twice for auth nodes
2020-11-05 11:43:32 +01:00
Kconfig
ubifs: Add support for zstd compression.
2019-07-08 19:43:53 +02:00
key.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336
2019-06-05 17:37:07 +02:00
log.c
ubifs: remove unnecessary check in ubifs_log_start_commit
2019-07-08 19:43:51 +02:00
lprops.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336
2019-06-05 17:37:07 +02:00
lpt_commit.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336
2019-06-05 17:37:07 +02:00
lpt.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336
2019-06-05 17:37:07 +02:00
Makefile
fscrypt: remove filesystem specific build config option
2019-01-23 23:56:43 -05:00
master.c
ubifs: support offline signed images
2019-07-08 19:43:52 +02:00
misc.c
ubifs: Allow setting assert action as mount parameter
2018-08-15 00:25:21 +02:00
misc.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336
2019-06-05 17:37:07 +02:00
orphan.c
ubifs: xattr: Fix some potential memory leaks while iterating entries
2020-11-05 11:43:32 +01:00
recovery.c
ubifs: Fix typo of output in get_cs_sqnum
2019-07-08 19:43:43 +02:00
replay.c
ubifs: Only check replay with inode type to judge if inode linked
2021-05-11 14:04:14 +02:00
sb.c
ubifs: Fix wrong memory allocation
2020-02-11 04:35:20 -08:00
scan.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336
2019-06-05 17:37:07 +02:00
shrinker.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336
2019-06-05 17:37:07 +02:00
super.c
ubifs: Fix races between xattr_{set|get} and listxattr operations
2021-07-19 08:53:16 +02:00
tnc_commit.c
ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps
2020-01-09 10:20:06 +01:00
tnc_misc.c
ubifs: Fix memory leak in read_znode() error path
2019-09-15 22:11:18 +02:00
tnc.c
ubifs: xattr: Fix some potential memory leaks while iterating entries
2020-11-05 11:43:32 +01:00
ubifs-media.h
ubifs: Add support for zstd compression.
2019-07-08 19:43:53 +02:00
ubifs.h
ubifs: Fix races between xattr_{set|get} and listxattr operations
2021-07-19 08:53:16 +02:00
xattr.c
ubifs: Fix races between xattr_{set|get} and listxattr operations
2021-07-19 08:53:16 +02:00