Vasily Gorbik
8eb521d192
s390/ftrace: fix ftrace_update_ftrace_func implementation ...
commit f8c2602733c953ed7a16e060640b8e96f9d94b9b upstream.
s390 enforces DYNAMIC_FTRACE if FUNCTION_TRACER is selected.
At the same time implementation of ftrace_caller is not compliant with
HAVE_DYNAMIC_FTRACE since it doesn't provide implementation of
ftrace_update_ftrace_func() and calls ftrace_trace_function() directly.
The subtle difference is that during ftrace code patching ftrace
replaces function tracer via ftrace_update_ftrace_func() and activates
it back afterwards. Unexpected direct calls to ftrace_trace_function()
during ftrace code patching leads to nullptr-dereferences when tracing
is activated for one of functions which are used during code patching.
Those function currently are:
copy_from_kernel_nofault()
copy_from_kernel_nofault_allowed()
preempt_count_sub() [with debug_defconfig]
preempt_count_add() [with debug_defconfig]
Corresponding KASAN report:
BUG: KASAN: nullptr-dereference in function_trace_call+0x316/0x3b0
Read of size 4 at addr 0000000000001e08 by task migration/0/15
CPU: 0 PID: 15 Comm: migration/0 Tainted: G B 5.13.0-41423-g08316af3644d
Hardware name: IBM 3906 M04 704 (LPAR)
Stopper: multi_cpu_stop+0x0/0x3e0 <- stop_machine_cpuslocked+0x1e4/0x218
Call Trace:
[<0000000001f77caa>] show_stack+0x16a/0x1d0
[<0000000001f8de42>] dump_stack+0x15a/0x1b0
[<0000000001f81d56>] print_address_description.constprop.0+0x66/0x2e0
[<000000000082b0ca>] kasan_report+0x152/0x1c0
[<00000000004cfd8e>] function_trace_call+0x316/0x3b0
[<0000000001fb7082>] ftrace_caller+0x7a/0x7e
[<00000000006bb3e6>] copy_from_kernel_nofault_allowed+0x6/0x10
[<00000000006bb42e>] copy_from_kernel_nofault+0x3e/0xd0
[<000000000014605c>] ftrace_make_call+0xb4/0x1f8
[<000000000047a1b4>] ftrace_replace_code+0x134/0x1d8
[<000000000047a6e0>] ftrace_modify_all_code+0x120/0x1d0
[<000000000047a7ec>] __ftrace_modify_code+0x5c/0x78
[<000000000042395c>] multi_cpu_stop+0x224/0x3e0
[<0000000000423212>] cpu_stopper_thread+0x33a/0x5a0
[<0000000000243ff2>] smpboot_thread_fn+0x302/0x708
[<00000000002329ea>] kthread+0x342/0x408
[<00000000001066b2>] __ret_from_fork+0x92/0xf0
[<0000000001fb57fa>] ret_from_fork+0xa/0x30
The buggy address belongs to the page:
page:(____ptrval____) refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1
flags: 0x1ffff00000001000(reserved|node=0|zone=0|lastcpupid=0x1ffff)
raw: 1ffff00000001000 0000040000000048 0000040000000048 0000000000000000
raw: 0000000000000000 0000000000000000 ffffffff00000001 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
0000000000001d00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
0000000000001d80: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
>0000000000001e00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
^
0000000000001e80: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
0000000000001f00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
==================================================================
To fix that introduce ftrace_func callback to be called from
ftrace_caller and update it in ftrace_update_ftrace_func().
Fixes: 4cc9bed034d1 ("[S390] cleanup ftrace backend functions")
Cc: stable@vger.kernel.org
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-07-28 13:30:58 +02:00
2019-07-23 10:45:53 +02:00
2019-05-03 17:17:58 +02:00
2020-06-30 15:37:05 -04:00
2018-03-28 08:38:24 +02:00
2020-06-30 15:37:05 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-09-03 13:53:56 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-01-18 09:33:18 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-05-27 09:36:28 -05:00
2021-04-14 08:24:17 +02:00
2019-03-12 10:04:01 -07:00
2020-07-09 09:37:50 +02:00
2020-05-02 08:48:44 +02:00
2021-05-11 14:04:01 +02:00
2019-08-06 13:58:35 +02:00
2019-08-29 15:34:58 +02:00
2020-07-16 08:16:35 +02:00
2018-08-23 18:48:43 -07:00
2019-06-14 10:48:56 +02:00
2021-04-28 13:19:15 +02:00
2019-04-17 10:40:57 +02:00
2021-07-28 13:30:58 +02:00
2017-11-13 11:47:01 -08:00
2019-09-17 14:04:43 -07:00
2019-10-31 17:26:48 +01:00
2019-04-29 10:44:03 +02:00
2019-04-26 12:34:05 +02:00
2019-08-06 13:58:34 +02:00
2020-10-01 13:17:40 +02:00
2019-06-07 10:10:10 +02:00
2019-01-28 15:58:55 +01:00
2019-09-10 13:27:51 +01:00
2019-08-19 21:54:15 -07:00
2019-04-29 10:47:10 +02:00
2017-11-24 15:37:12 +01:00
2020-05-27 17:46:49 +02:00
2020-05-27 17:46:47 +02:00
2020-01-04 19:18:31 +01:00
2019-08-21 12:58:52 +02:00
2021-07-28 13:30:58 +02:00
2019-08-29 15:34:57 +02:00
2019-05-02 13:54:11 +02:00
2019-05-06 16:42:54 -07:00
2019-04-11 13:36:53 +02:00
2017-11-02 11:10:55 +01:00
2019-02-22 09:19:55 +01:00
2019-12-31 16:45:43 +01:00
2019-07-11 20:40:01 +02:00
2019-12-31 16:45:43 +01:00
2020-11-24 13:29:23 +01:00
2019-12-31 16:44:30 +01:00
2018-07-02 11:24:54 +02:00
2019-04-29 10:47:10 +02:00
2020-04-13 10:48:06 +02:00
2020-04-23 10:36:33 +02:00
2021-04-28 13:19:14 +02:00
2019-05-02 13:54:11 +02:00
2019-05-02 13:54:11 +02:00
2020-08-26 10:41:02 +02:00
2021-07-20 16:10:43 +02:00
2019-05-27 09:36:28 -05:00
2021-03-17 17:03:45 +01:00
2019-08-21 12:58:53 +02:00
2018-10-15 12:17:00 +02:00
2018-02-27 08:05:23 +01:00
2019-06-07 10:09:37 +02:00
2019-01-18 09:33:19 +01:00
2019-01-28 15:58:55 +01:00
2020-11-05 11:43:30 +01:00
2019-09-23 23:27:52 +02:00
2020-05-02 08:48:44 +02:00
2019-07-08 21:48:15 -07:00
2020-01-04 19:18:29 +01:00
2018-04-23 07:57:16 +02:00
2019-09-17 14:04:43 -07:00
2019-08-06 13:58:35 +02:00
2021-03-24 11:26:35 +01:00
8eb521d192