Saurav Kashyap
b5eb54c4a9
scsi: qla2xxx: Sync queue idx with queue_pair_map idx ...
commit c8fadf019964d0eb1da410ba8b629494d3339db9 upstream.
The first invocation of function find_first_zero_bit will return 0 and
queue_id gets set to 0.
An index of queue_pair_map also gets set to 0.
qpair_id = find_first_zero_bit(ha->qpair_qid_map, ha->max_qpairs);
set_bit(qpair_id, ha->qpair_qid_map);
ha->queue_pair_map[qpair_id] = qpair;
In the alloc_queue callback driver checks the map, if queue is already
allocated:
ha->queue_pair_map[qidx]
This works fine as long as max_qpairs is greater than nvme_max_hw_queues(8)
since the size of the queue_pair_map is equal to max_qpair. In case nr_cpus
is less than 8, max_qpairs is less than 8. This creates wrong value
returned as qpair.
[ 1572.353669] qla2xxx [0000:24:00.3]-2121:6: Returning existing qpair of 4e00000000000000 for idx=2
[ 1572.354458] general protection fault: 0000 [#1 ] SMP PTI
[ 1572.354461] CPU: 1 PID: 44 Comm: kworker/1:1H Kdump: loaded Tainted: G IOE --------- - - 4.18.0-304.el8.x86_64 #1
[ 1572.354462] Hardware name: HP ProLiant DL380p Gen8, BIOS P70 03/01/2013
[ 1572.354467] Workqueue: kblockd blk_mq_run_work_fn
[ 1572.354485] RIP: 0010:qla_nvme_post_cmd+0x92/0x760 [qla2xxx]
[ 1572.354486] Code: 84 24 5c 01 00 00 00 00 b8 0a 74 1e 66 83 79 48 00 0f 85 a8 03 00 00 48 8b 44 24 08 48 89 ee 4c 89 e7 8b 50 24 e8 5e 8e 00 00 <f0> 41 ff 47 04 0f ae f0 41 f6 47 24 04 74 19 f0 41 ff 4f 04 b8 f0
[ 1572.354487] RSP: 0018:ffff9c81c645fc90 EFLAGS: 00010246
[ 1572.354489] RAX: 0000000000000001 RBX: ffff8ea3e5070138 RCX: 0000000000000001
[ 1572.354490] RDX: 0000000000000001 RSI: 0000000000000001 RDI: ffff8ea4c866b800
[ 1572.354491] RBP: ffff8ea4c866b800 R08: 0000000000005010 R09: ffff8ea4c866b800
[ 1572.354492] R10: 0000000000000001 R11: 000000069d1ca3ff R12: ffff8ea4bc460000
[ 1572.354493] R13: ffff8ea3e50702b0 R14: ffff8ea4c4c16a58 R15: 4e00000000000000
[ 1572.354494] FS: 0000000000000000(0000) GS:ffff8ea4dfd00000(0000) knlGS:0000000000000000
[ 1572.354495] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1572.354496] CR2: 000055884504fa58 CR3: 00000005a1410001 CR4: 00000000000606e0
[ 1572.354497] Call Trace:
[ 1572.354503] ? check_preempt_curr+0x62/0x90
[ 1572.354506] ? dma_direct_map_sg+0x72/0x1f0
[ 1572.354509] ? nvme_fc_start_fcp_op.part.32+0x175/0x460 [nvme_fc]
[ 1572.354511] ? blk_mq_dispatch_rq_list+0x11c/0x730
[ 1572.354515] ? __switch_to_asm+0x35/0x70
[ 1572.354516] ? __switch_to_asm+0x41/0x70
[ 1572.354518] ? __switch_to_asm+0x35/0x70
[ 1572.354519] ? __switch_to_asm+0x41/0x70
[ 1572.354521] ? __switch_to_asm+0x35/0x70
[ 1572.354522] ? __switch_to_asm+0x41/0x70
[ 1572.354523] ? __switch_to_asm+0x35/0x70
[ 1572.354525] ? entry_SYSCALL_64_after_hwframe+0xb9/0xca
[ 1572.354527] ? __switch_to_asm+0x41/0x70
[ 1572.354529] ? __blk_mq_sched_dispatch_requests+0xc6/0x170
[ 1572.354531] ? blk_mq_sched_dispatch_requests+0x30/0x60
[ 1572.354532] ? __blk_mq_run_hw_queue+0x51/0xd0
[ 1572.354535] ? process_one_work+0x1a7/0x360
[ 1572.354537] ? create_worker+0x1a0/0x1a0
[ 1572.354538] ? worker_thread+0x30/0x390
[ 1572.354540] ? create_worker+0x1a0/0x1a0
[ 1572.354541] ? kthread+0x116/0x130
[ 1572.354543] ? kthread_flush_work_fn+0x10/0x10
[ 1572.354545] ? ret_from_fork+0x35/0x40
Fix is to use index 0 for admin and first IO queue.
Link: https://lore.kernel.org/r/20210810043720.1137-14-njavali@marvell.com
Fixes: e84067d74301 ("scsi: qla2xxx: Add FC-NVMe F/W initialization and transport registration")
Cc: stable@vger.kernel.org
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-09-22 12:26:37 +02:00
2020-10-01 13:17:56 +02:00
2021-07-25 14:35:12 +02:00
2021-07-25 14:35:13 +02:00
2019-05-21 10:50:46 +02:00
2020-08-19 08:16:09 +02:00
2021-07-20 16:10:53 +02:00
2020-10-29 09:57:57 +01:00
2021-06-16 11:59:35 +02:00
2021-07-20 16:10:43 +02:00
2020-10-29 09:57:37 +01:00
2021-07-20 16:10:43 +02:00
2020-10-01 13:18:02 +02:00
2021-08-26 08:36:14 -04:00
2019-05-30 11:26:32 -07:00
2020-01-23 08:22:58 +01:00
2020-09-03 11:26:47 +02:00
2021-02-07 15:35:48 +01:00
2021-07-25 14:35:13 +02:00
2021-05-14 09:44:25 +02:00
2019-07-30 15:59:53 -04:00
2021-07-25 14:35:13 +02:00
2021-07-25 14:35:13 +02:00
2021-07-25 14:35:13 +02:00
2021-07-20 16:10:42 +02:00
2021-08-26 08:36:14 -04:00
2021-07-14 16:53:45 +02:00
2021-07-25 14:35:13 +02:00
2021-09-22 12:26:24 +02:00
2021-07-25 14:35:13 +02:00
2021-09-22 12:26:24 +02:00
2021-09-22 12:26:24 +02:00
2021-09-22 12:26:37 +02:00
2020-10-29 09:57:36 +01:00
2021-09-22 12:26:24 +02:00
2019-01-29 00:40:54 -05:00
2019-08-12 21:58:07 -04:00
2021-05-26 12:05:20 +02:00
2019-02-25 21:37:25 -05:00
2019-03-02 11:39:54 -08:00
2018-12-19 21:54:07 -05:00
2019-05-24 17:36:45 +02:00
2019-01-08 07:58:37 -05:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-07-11 15:17:41 -07:00
2019-07-11 15:17:41 -07:00
2019-05-21 10:50:45 +02:00
2018-12-18 23:13:12 -05:00
2019-05-21 10:50:45 +02:00
2020-01-04 19:18:10 +01:00
2019-05-21 10:50:45 +02:00
2021-09-22 12:26:37 +02:00
2021-06-03 08:59:11 +02:00
2019-05-21 10:50:45 +02:00
2019-10-09 23:39:35 -04:00
2018-12-18 23:19:21 -05:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-07-11 15:17:41 -07:00
2019-06-20 15:21:33 -04:00
2019-07-30 12:18:24 -04:00
2019-06-18 19:46:18 -04:00
2019-07-30 12:17:28 -04:00
2019-06-18 19:46:22 -04:00
2021-07-14 16:53:41 +02:00
2019-05-21 10:50:45 +02:00
2019-01-08 21:58:35 -05:00
2019-01-08 21:58:35 -05:00
2019-01-08 21:57:42 -05:00
2019-05-30 11:25:18 -07:00
2019-01-08 21:58:35 -05:00
2019-05-21 10:50:45 +02:00
2021-07-20 16:10:42 +02:00
2019-07-11 15:14:01 -07:00
2020-11-18 19:20:22 +01:00
2019-06-18 19:46:18 -04:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-11 15:17:41 -07:00
2019-05-21 11:28:46 +02:00
2020-04-01 11:01:54 +02:00
2020-04-01 11:01:54 +02:00
2018-12-18 23:19:21 -05:00
2020-06-24 17:50:37 +02:00
2020-02-24 08:36:50 +01:00
2019-05-30 11:26:37 -07:00
2021-05-14 09:44:25 +02:00
2020-07-22 09:32:57 +02:00
2019-05-24 17:36:45 +02:00
2019-07-11 15:14:01 -07:00
2021-07-20 16:10:43 +02:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2020-01-04 19:18:10 +01:00
2019-07-17 22:39:27 +09:00
2019-09-23 23:09:42 -04:00
2020-08-19 08:16:15 +02:00
2019-05-21 10:50:45 +02:00
2018-12-18 23:13:12 -05:00
2020-10-29 09:58:04 +01:00
2019-05-30 11:26:39 -07:00
2018-12-28 14:48:06 -08:00
2021-03-24 11:26:40 +01:00
2019-08-07 21:53:23 -04:00
2019-05-24 17:36:45 +02:00
2020-01-04 19:18:16 +01:00
2019-06-20 15:37:02 -04:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2019-08-12 21:57:13 -04:00
2019-05-30 11:26:35 -07:00
2019-06-20 15:21:33 -04:00
2019-05-30 11:26:38 -07:00
2019-08-16 11:33:56 -07:00
2019-08-16 11:33:56 -07:00
2019-03-19 17:11:37 -04:00
2018-12-18 23:19:21 -05:00
2019-08-07 21:32:53 -04:00
2019-02-13 22:07:03 -05:00
2019-06-05 17:37:17 +02:00
2019-05-24 17:36:45 +02:00
2020-08-19 08:16:11 +02:00
2019-07-30 12:42:55 -04:00
2019-05-21 06:16:21 -04:00
2021-06-18 09:58:59 +02:00
2020-07-29 10:18:27 +02:00
2019-10-03 21:43:04 -04:00
2019-05-21 06:16:21 -04:00
2021-07-14 16:53:48 +02:00
2019-08-07 21:47:29 -04:00
2019-05-30 11:26:35 -07:00
2020-06-07 13:18:50 +02:00
2019-06-18 19:46:17 -04:00
2019-07-30 13:07:42 +02:00
2021-08-26 08:36:14 -04:00
2019-05-30 11:29:53 -07:00
2021-09-03 10:08:13 +02:00
2020-01-23 08:22:59 +01:00
2019-07-11 15:14:01 -07:00
2021-07-28 13:30:56 +02:00
2020-01-23 08:22:58 +01:00
2021-01-12 20:16:09 +01:00
2021-04-21 12:56:14 +02:00
2019-07-11 15:14:01 -07:00
2019-06-05 17:37:14 +02:00
2019-11-05 23:17:53 -05:00
2021-01-27 11:47:43 +01:00
2019-08-04 21:41:29 -06:00
2019-07-11 15:14:01 -07:00
2020-05-20 08:20:07 +02:00
2018-12-18 23:19:21 -05:00
2019-05-24 17:36:45 +02:00
2021-05-14 09:44:25 +02:00
2020-07-22 09:32:57 +02:00
2021-08-12 13:20:56 +02:00
2021-04-07 14:47:39 +02:00
2019-05-30 11:26:32 -07:00
2020-01-23 08:22:38 +01:00
2020-01-04 19:18:10 +01:00
2021-05-14 09:44:25 +02:00
2019-05-21 10:50:45 +02:00
2019-09-10 22:10:17 -04:00
2021-06-16 11:59:35 +02:00
2019-08-07 21:35:59 -04:00
2019-05-24 17:39:02 +02:00
2019-07-11 15:14:01 -07:00
2018-12-18 23:13:12 -05:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2020-01-04 19:17:37 +01:00
b5eb54c4a9