iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
v5.4.155
linux/drivers/ata
History
Wang Hai 97e6dcb416 ata: ahci_platform: fix null-ptr-deref in ahci_platform_enable_regulators() 
commit 776c75010803849c1cc4f11031a2b3960ab05202 upstream.

I got a null-ptr-deref report:

KASAN: null-ptr-deref in range [0x0000000000000090-0x0000000000000097]
...
RIP: 0010:regulator_enable+0x84/0x260
...
Call Trace:
 ahci_platform_enable_regulators+0xae/0x320
 ahci_platform_enable_resources+0x1a/0x120
 ahci_probe+0x4f/0x1b9
 platform_probe+0x10b/0x280
...
 entry_SYSCALL_64_after_hwframe+0x44/0xae

If devm_regulator_get() in ahci_platform_get_resources() fails,
hpriv->phy_regulator will point to NULL, when enabling or disabling it,
null-ptr-deref will occur.

ahci_probe()
	ahci_platform_get_resources()
		devm_regulator_get(, "phy") // failed, let phy_regulator = NULL
	ahci_platform_enable_resources()
		ahci_platform_enable_regulators()
			regulator_enable(hpriv->phy_regulator) // null-ptr-deref

commit 962399bb7fbf ("ata: libahci_platform: Fix regulator_get_optional()
misuse") replaces devm_regulator_get_optional() with devm_regulator_get(),
but PHY regulator omits to delete "hpriv->phy_regulator = NULL;" like AHCI.
Delete it like AHCI regulator to fix this bug.

Fixes: commit 962399bb7fbf ("ata: libahci_platform: Fix regulator_get_optional() misuse")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-20 11:40:16 +02:00
..
acard-ahci.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
ahci_brcm.c
ata: ahci_brcm: Add back regulators management
2021-03-04 10:26:23 +01:00
ahci_ceva.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201
2019-05-30 11:29:52 -07:00
ahci_da850.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
ahci_dm816.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
ahci_imx.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201
2019-05-30 11:29:52 -07:00
ahci_mtk.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
ahci_mvebu.c
ata: ahci: mvebu: Make SATA PHY optional for Armada 3720
2020-11-01 12:01:05 +01:00
ahci_octeon.c
Delete redundant return value check of platform_get_resource()
2017-03-06 15:40:59 -05:00
ahci_platform.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
ahci_qoriq.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
ahci_seattle.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235
2019-06-19 17:09:07 +02:00
ahci_st.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
ahci_sunxi.c
ata: ahci_sunxi: Disable DIPM
2021-07-19 08:53:15 +02:00
ahci_tegra.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
ahci_xgene.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13
2019-05-21 11:28:45 +02:00
ahci.c
ata: ahci: Disable SXS for Hisilicon Kunpeng920
2021-05-11 14:04:10 +02:00
ahci.h
ata: ahci: Disable SXS for Hisilicon Kunpeng920
2021-05-11 14:04:10 +02:00
ata_generic.c
…
ata_piix.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
Kconfig
ata: add Buddha PATA controller driver
2019-02-08 06:32:01 -07:00
libahci_platform.c
ata: ahci_platform: fix null-ptr-deref in ahci_platform_enable_regulators()
2021-10-20 11:40:16 +02:00
libahci.c
ata: ahci: Disable SXS for Hisilicon Kunpeng920
2021-05-11 14:04:10 +02:00
libata-acpi.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
libata-core.c
libata: Add ATA_HORKAGE_NO_NCQ_ON_ATI for Samsung 860 and 870 SSD.
2021-10-09 14:39:50 +02:00
libata-eh.c
libata: don't request sense data on !ZAC ATA devices
2019-06-25 09:22:45 -06:00
libata-pmp.c
libata: Return correct status in sata_pmp_eh_recover_pm() when ATA_DFLAG_DETACH is set
2020-04-17 10:50:22 +02:00
libata-scsi.c
libata: implement ATA_HORKAGE_MAX_TRIM_128M and apply to Sandisks
2020-09-09 19:12:34 +02:00
libata-sff.c
libata: fix ata_pio_sector for CONFIG_HIGHMEM
2021-08-12 13:21:04 +02:00
libata-trace.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
libata-transport.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 209
2019-05-30 11:29:53 -07:00
libata-transport.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
libata-zpodd.c
libata: zpodd: Fix small read overflow in zpodd_get_mech_type()
2019-07-29 16:00:14 -06:00
libata.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
Makefile
ata: add Buddha PATA controller driver
2019-02-08 06:32:01 -07:00
pata_acpi.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_ali.c
ata: Deprecate pci_get_bus_and_slot()
2018-01-11 17:23:23 -06:00
pata_amd.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_arasan_cf.c
pata_arasan_cf: fix IRQ check
2021-05-14 09:44:24 +02:00
pata_artop.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_atiixp.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_atp867x.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_bk3710.c
pata_bk3710: clarify license version and use SPDX header
2018-03-01 13:59:03 -08:00
pata_buddha.c
ata/pata_buddha: Probe via modalias instead of initcall
2019-08-23 06:58:50 -06:00
pata_cmd64x.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_cmd640.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_cs5520.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_cs5530.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_cs5535.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_cs5536.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_cypress.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_efar.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_ep93xx.c
pata_ep93xx: fix deferred probing
2021-07-14 16:53:21 +02:00
pata_falcon.c
pata_falcon: clarify license version and use SPDX header
2018-03-01 13:58:17 -08:00
pata_ftide010.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_gayle.c
ata: add Amiga Gayle PATA controller driver
2018-03-19 07:41:36 -07:00
pata_hpt3x2n.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_hpt3x3.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_hpt37x.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_hpt366.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_icside.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_imx.c
Merge branch 'for-4.19' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
2018-08-24 13:20:33 -07:00
pata_isapnp.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_it821x.c
pata_it821x: Delete an error message for a failed memory allocation in it821x_firmware_command()
2018-02-18 05:26:07 -08:00
pata_it8213.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_ixp4xx_cf.c
pata_ipx4xx_cf: fix IRQ check
2021-05-14 09:44:24 +02:00
pata_jmicron.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_legacy.c
pata_legacy: fix a couple uninitialized variable bugs
2021-10-20 11:40:16 +02:00
pata_macio.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
pata_marvell.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_mpc52xx.c
pata_mpc52xx: Delete an error message for a failed memory allocation in mpc52xx_ata_probe()
2018-02-18 05:23:25 -08:00
pata_mpiix.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_netcell.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_ninja32.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_ns87410.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
pata_ns87415.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_octeon_cf.c
pata_octeon_cf: avoid WARN_ON() in ata_host_activate()
2021-07-14 16:53:21 +02:00
pata_of_platform.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
pata_oldpiix.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_opti.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_optidma.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_palmld.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
pata_pcmcia.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
pata_pdc202xx_old.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_pdc2027x.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_piccolo.c
…
pata_platform.c
ata: pata_platform: Add IRQF_SHARED to IRQ flags
2019-02-08 06:42:55 -07:00
pata_pxa.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
pata_radisys.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_rb532_cf.c
pata_rb532_cf: fix deferred probing
2021-07-14 16:53:20 +02:00
pata_rdc.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
pata_rz1000.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_samsung_cf.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
pata_sc1200.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_sch.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 300
2019-06-05 17:37:00 +02:00
pata_serverworks.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_sil680.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_sis.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_sl82c105.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_triflex.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_via.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pdc_adma.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_dwc_460ex.c
ata: sata_dwc_460ex: No need to call phy_exit() befre phy_init()
2021-09-22 12:26:30 +02:00
sata_fsl.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_gemini.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
sata_gemini.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sata_highbank.c
sata_highbank: fix deferred probing
2021-07-14 16:53:20 +02:00
sata_inic162x.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_mv.c
sata_mv: add IRQ checks
2021-05-14 09:44:24 +02:00
sata_nv.c
ata: sata_nv: Fix retrieving of active qcs
2020-11-05 11:43:12 +01:00
sata_promise.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_promise.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_qstor.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_rcar.c
ata: sata_rcar: Fix DMA boundary mask
2020-11-01 12:01:06 +01:00
sata_sil24.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_sil.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_sis.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_svw.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
sata_sx4.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_uli.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_via.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
sata_vsc.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
sis.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00