linux

iv/linux

History

Miklos Szeredi 43d9332526 ovl: simplify file splice

commit 82a763e61e2b601309d696d4fa514c77d64ee1be upstream.

generic_file_splice_read() and iter_file_splice_write() will call back into
f_op->iter_read() and f_op->iter_write() respectively.  These already do
the real file lookup and cred override.  So the code in ovl_splice_read()
and ovl_splice_write() is redundant.

In addition the ovl_file_accessed() call in ovl_splice_write() is
incorrect, though probably harmless.

Fix by calling generic_file_splice_read() and iter_file_splice_write()
directly.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
[reported to resolve issues with 1a980b8cbf00 ("ovl: add splice file read write helper")]
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2021-10-20 11:40:12 +02:00

copy_up.c

ovl: fix missing revert_creds() on error path

2021-05-14 09:44:16 +02:00

dir.c

ovl: fix missing negative dentry check in ovl_rename()

2021-10-13 10:08:17 +02:00

export.c

ovl: fix uninitialized pointer read in ovl_lookup_real_one()

2021-09-03 10:08:12 +02:00

file.c

ovl: simplify file splice