John Meneghini
bf2bd892a0
scsi: bnx2fc: Flush destroy_work queue before calling bnx2fc_interface_put()
...
commit 847f9ea4c5186fdb7b84297e3eeed9e340e83fce upstream.
The bnx2fc_destroy() functions are removing the interface before calling
destroy_work. This results multiple WARNings from sysfs_remove_group() as
the controller rport device attributes are removed too early.
Replace the fcoe_port's destroy_work queue. It's not needed.
The problem is easily reproducible with the following steps.
Example:
$ dmesg -w &
$ systemctl enable --now fcoe
$ fipvlan -s -c ens2f1
$ fcoeadm -d ens2f1.802
[ 583.464488] host2: libfc: Link down on port (7500a1)
[ 583.472651] bnx2fc: 7500a1 - rport not created Yet!!
[ 583.490468] ------------[ cut here ]------------
[ 583.538725] sysfs group 'power' not found for kobject 'rport-2:0-0'
[ 583.568814] WARNING: CPU: 3 PID: 192 at fs/sysfs/group.c:279 sysfs_remove_group+0x6f/0x80
[ 583.607130] Modules linked in: dm_service_time 8021q garp mrp stp llc bnx2fc cnic uio rpcsec_gss_krb5 auth_rpcgss nfsv4 ...
[ 583.942994] CPU: 3 PID: 192 Comm: kworker/3:2 Kdump: loaded Not tainted 5.14.0-39.el9.x86_64 #1
[ 583.984105] Hardware name: HP ProLiant DL120 G7, BIOS J01 07/01/2013
[ 584.016535] Workqueue: fc_wq_2 fc_rport_final_delete [scsi_transport_fc]
[ 584.050691] RIP: 0010:sysfs_remove_group+0x6f/0x80
[ 584.074725] Code: ff 5b 48 89 ef 5d 41 5c e9 ee c0 ff ff 48 89 ef e8 f6 b8 ff ff eb d1 49 8b 14 24 48 8b 33 48 c7 c7 ...
[ 584.162586] RSP: 0018:ffffb567c15afdc0 EFLAGS: 00010282
[ 584.188225] RAX: 0000000000000000 RBX: ffffffff8eec4220 RCX: 0000000000000000
[ 584.221053] RDX: ffff8c1586ce84c0 RSI: ffff8c1586cd7cc0 RDI: ffff8c1586cd7cc0
[ 584.255089] RBP: 0000000000000000 R08: 0000000000000000 R09: ffffb567c15afc00
[ 584.287954] R10: ffffb567c15afbf8 R11: ffffffff8fbe7f28 R12: ffff8c1486326400
[ 584.322356] R13: ffff8c1486326480 R14: ffff8c1483a4a000 R15: 0000000000000004
[ 584.355379] FS: 0000000000000000(0000) GS:ffff8c1586cc0000(0000) knlGS:0000000000000000
[ 584.394419] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 584.421123] CR2: 00007fe95a6f7840 CR3: 0000000107674002 CR4: 00000000000606e0
[ 584.454888] Call Trace:
[ 584.466108] device_del+0xb2/0x3e0
[ 584.481701] device_unregister+0x13/0x60
[ 584.501306] bsg_unregister_queue+0x5b/0x80
[ 584.522029] bsg_remove_queue+0x1c/0x40
[ 584.541884] fc_rport_final_delete+0xf3/0x1d0 [scsi_transport_fc]
[ 584.573823] process_one_work+0x1e3/0x3b0
[ 584.592396] worker_thread+0x50/0x3b0
[ 584.609256] ? rescuer_thread+0x370/0x370
[ 584.628877] kthread+0x149/0x170
[ 584.643673] ? set_kthread_struct+0x40/0x40
[ 584.662909] ret_from_fork+0x22/0x30
[ 584.680002] ---[ end trace 53575ecefa942ece ]---
Link: https://lore.kernel.org/r/20220115040044.1013475-1-jmeneghi@redhat.com
Fixes: 0cbf32e1681d ("[SCSI] bnx2fc: Avoid calling bnx2fc_if_destroy with unnecessary locks")
Tested-by: Guangwu Zhang <guazhang@redhat.com>
Co-developed-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: John Meneghini <jmeneghi@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-02-01 17:24:36 +01:00
..
2020-10-01 13:17:56 +02:00
2021-07-25 14:35:12 +02:00
2021-07-25 14:35:13 +02:00
2019-05-21 10:50:46 +02:00
2020-08-19 08:16:09 +02:00
2021-07-20 16:10:53 +02:00
2020-10-29 09:57:57 +01:00
2022-02-01 17:24:36 +01:00
2021-07-20 16:10:43 +02:00
2021-11-17 09:48:43 +01:00
2021-07-20 16:10:43 +02:00
2020-10-01 13:18:02 +02:00
2021-08-26 08:36:14 -04:00
2019-05-30 11:26:32 -07:00
2020-01-23 08:22:58 +01:00
2020-09-03 11:26:47 +02:00
2021-02-07 15:35:48 +01:00
2021-07-25 14:35:13 +02:00
2021-05-14 09:44:25 +02:00
2019-07-30 15:59:53 -04:00
2021-07-25 14:35:13 +02:00
2021-07-25 14:35:13 +02:00
2021-07-25 14:35:13 +02:00
2022-01-27 09:19:48 +01:00
2021-08-26 08:36:14 -04:00
2021-12-01 09:23:32 +01:00
2021-07-25 14:35:13 +02:00
2021-09-22 12:26:24 +02:00
2021-07-25 14:35:13 +02:00
2021-09-22 12:26:24 +02:00
2021-09-22 12:26:24 +02:00
2021-11-17 09:48:46 +01:00
2020-10-29 09:57:36 +01:00
2021-09-22 12:26:24 +02:00
2019-01-29 00:40:54 -05:00
2019-08-12 21:58:07 -04:00
2022-01-27 09:19:38 +01:00
2019-02-25 21:37:25 -05:00
2019-03-02 11:39:54 -08:00
2018-12-19 21:54:07 -05:00
2019-05-24 17:36:45 +02:00
2019-01-08 07:58:37 -05:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2021-11-26 10:47:15 +01:00
2019-07-11 15:17:41 -07:00
2019-05-21 10:50:45 +02:00
2018-12-18 23:13:12 -05:00
2019-05-21 10:50:45 +02:00
2020-01-04 19:18:10 +01:00
2019-05-21 10:50:45 +02:00
2021-09-22 12:26:37 +02:00
2021-06-03 08:59:11 +02:00
2019-05-21 10:50:45 +02:00
2019-10-09 23:39:35 -04:00
2021-11-17 09:48:41 +01:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-07-11 15:17:41 -07:00
2019-06-20 15:21:33 -04:00
2019-07-30 12:18:24 -04:00
2019-06-18 19:46:18 -04:00
2019-07-30 12:17:28 -04:00
2019-06-18 19:46:22 -04:00
2021-07-14 16:53:41 +02:00
2019-05-21 10:50:45 +02:00
2019-01-08 21:58:35 -05:00
2019-01-08 21:58:35 -05:00
2019-01-08 21:57:42 -05:00
2019-05-30 11:25:18 -07:00
2019-01-08 21:58:35 -05:00
2019-05-21 10:50:45 +02:00
2021-10-27 09:54:29 +02:00
2019-07-11 15:14:01 -07:00
2020-11-18 19:20:22 +01:00
2019-06-18 19:46:18 -04:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-11 15:17:41 -07:00
2019-05-21 11:28:46 +02:00
2020-04-01 11:01:54 +02:00
2020-04-01 11:01:54 +02:00
2018-12-18 23:19:21 -05:00
2020-06-24 17:50:37 +02:00
2020-02-24 08:36:50 +01:00
2019-05-30 11:26:37 -07:00
2021-05-14 09:44:25 +02:00
2020-07-22 09:32:57 +02:00
2019-05-24 17:36:45 +02:00
2019-07-11 15:14:01 -07:00
2022-01-11 15:23:33 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2020-01-04 19:18:10 +01:00
2019-07-17 22:39:27 +09:00
2019-09-23 23:09:42 -04:00
2020-08-19 08:16:15 +02:00
2019-05-21 10:50:45 +02:00
2018-12-18 23:13:12 -05:00
2020-10-29 09:58:04 +01:00
2019-05-30 11:26:39 -07:00
2018-12-28 14:48:06 -08:00
2021-03-24 11:26:40 +01:00
2019-08-07 21:53:23 -04:00
2019-05-24 17:36:45 +02:00
2020-01-04 19:18:16 +01:00
2019-06-20 15:37:02 -04:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2019-08-12 21:57:13 -04:00
2019-05-30 11:26:35 -07:00
2019-06-20 15:21:33 -04:00
2019-05-30 11:26:38 -07:00
2019-08-16 11:33:56 -07:00
2019-08-16 11:33:56 -07:00
2019-03-19 17:11:37 -04:00
2018-12-18 23:19:21 -05:00
2019-08-07 21:32:53 -04:00
2019-02-13 22:07:03 -05:00
2019-06-05 17:37:17 +02:00
2019-05-24 17:36:45 +02:00
2021-12-22 09:29:40 +01:00
2022-01-27 09:19:52 +01:00
2019-05-21 06:16:21 -04:00
2021-06-18 09:58:59 +02:00
2020-07-29 10:18:27 +02:00
2019-10-03 21:43:04 -04:00
2019-05-21 06:16:21 -04:00
2021-07-14 16:53:48 +02:00
2019-08-07 21:47:29 -04:00
2019-05-30 11:26:35 -07:00
2020-06-07 13:18:50 +02:00
2019-06-18 19:46:17 -04:00
2019-07-30 13:07:42 +02:00
2021-08-26 08:36:14 -04:00
2019-05-30 11:29:53 -07:00
2021-12-01 09:23:33 +01:00
2020-01-23 08:22:59 +01:00
2019-07-11 15:14:01 -07:00
2021-12-08 09:01:09 +01:00
2020-01-23 08:22:58 +01:00
2021-01-12 20:16:09 +01:00
2021-04-21 12:56:14 +02:00
2021-11-06 13:59:44 +01:00
2019-06-05 17:37:14 +02:00
2019-11-05 23:17:53 -05:00
2021-10-09 14:39:49 +02:00
2019-08-04 21:41:29 -06:00
2021-10-17 10:42:34 +02:00
2020-05-20 08:20:07 +02:00
2018-12-18 23:19:21 -05:00
2019-05-24 17:36:45 +02:00
2021-05-14 09:44:25 +02:00
2022-01-27 09:19:48 +01:00
2022-01-27 09:19:48 +01:00
2021-04-07 14:47:39 +02:00
2019-05-30 11:26:32 -07:00
2020-01-23 08:22:38 +01:00
2020-01-04 19:18:10 +01:00
2021-05-14 09:44:25 +02:00
2019-05-21 10:50:45 +02:00
2021-10-17 10:42:34 +02:00
2022-01-05 12:37:46 +01:00
2019-08-07 21:35:59 -04:00
2019-05-24 17:39:02 +02:00
2019-07-11 15:14:01 -07:00
2018-12-18 23:13:12 -05:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2020-01-04 19:17:37 +01:00