iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/tools/perf
History
Adrian Hunter 9fbe8ea8df perf script: Fix hex dump character output 
commit 62942e9fda9fd1def10ffcbd5e1c025b3c9eec17 upstream.

Using grep -C with perf script -D can give erroneous results as grep loses
lines due to non-printable characters, for example, below the 0020, 0060
and 0070 lines are missing:

 $ perf script -D | grep -C10 AUX | head
 .  0010:  08 00 00 00 00 00 00 00 1f 00 00 00 00 00 00 00  ................
 .  0030:  01 00 00 00 00 00 00 00 00 04 00 00 00 00 00 00  ................
 .  0040:  00 08 00 00 00 00 00 00 02 00 00 00 00 00 00 00  ................
 .  0050:  00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00  ................
 .  0080:  02 00 00 00 00 00 00 00 1b 00 00 00 00 00 00 00  ................
 .  0090:  00 00 00 00 00 00 00 00                          ........

 0 0 0x450 [0x98]: PERF_RECORD_AUXTRACE_INFO type: 1
   PMU Type            8
   Time Shift          31

perf's isprint() is a custom implementation from the kernel, but the
kernel's _ctype appears to include characters from Latin-1 Supplement which
is not compatible with, for example, UTF-8. Fix by checking also isascii().

After:

 $ tools/perf/perf script -D | grep -C10 AUX | head
 .  0010:  08 00 00 00 00 00 00 00 1f 00 00 00 00 00 00 00  ................
 .  0020:  03 84 32 2f 00 00 00 00 63 7c 4f d2 fa ff ff ff  ..2/....c|O.....
 .  0030:  01 00 00 00 00 00 00 00 00 04 00 00 00 00 00 00  ................
 .  0040:  00 08 00 00 00 00 00 00 02 00 00 00 00 00 00 00  ................
 .  0050:  00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00  ................
 .  0060:  00 02 00 00 00 00 00 00 00 c0 03 00 00 00 00 00  ................
 .  0070:  e2 00 00 00 00 00 00 00 02 00 00 00 00 00 00 00  ................
 .  0080:  02 00 00 00 00 00 00 00 1b 00 00 00 00 00 00 00  ................
 .  0090:  00 00 00 00 00 00 00 00                          ........

Fixes: 3052ba56bcb58904 ("tools perf: Move from sane_ctype.h obtained from git to the Linux's original")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lore.kernel.org/lkml/20220112085057.277205-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-01-27 09:19:54 +01:00
..
arch
perf tools: Fix record failure when mixed with ARM SPE event
2020-08-05 09:59:49 +02:00
bench
perf bench futex: Fix memory leak of perf_cpu_map__new()
2021-11-26 10:47:18 +01:00
Documentation
perf record/stat: Explicitly call out event modifiers in the documentation
2020-09-05 11:22:49 +02:00
examples/bpf
perf augmented_raw_syscalls: Reduce perf_event_output() boilerplate
2019-08-26 11:58:29 -03:00
include/bpf
…
jvmti
perf jvmti: Link against tools/lib/ctype.h to have weak strlcpy()
2019-10-15 11:47:38 -03:00
lib
libperf: Add perf_evlist__poll() function
2019-09-25 09:51:49 -03:00
pmu-events
perf jevents: Fix getting maximum number of fds
2021-06-03 08:59:08 +02:00
python
tweewide: Fix most Shebang lines
2021-05-22 11:38:30 +02:00
scripts
perf scripts python: exported-sql-viewer.py: Fix warning display
2021-06-03 08:59:00 +02:00
tests
perf tests: Remove bash construct from record+zstd_comp_decomp.sh
2021-11-26 10:47:18 +01:00
trace
perf beauty: Fix fsconfig generator
2021-05-14 09:44:30 +02:00
ui
perf hist: Fix memory leak of a perf_hpp_fmt
2021-12-08 09:01:10 +01:00
util
perf script: Fix hex dump character output
2022-01-27 09:19:54 +01:00
.gitignore
perf: Update .gitignore file
2019-08-31 22:27:52 -03:00
Build
…
builtin-annotate.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-bench.c
perf tools: Remove perf.h from source files not needing it
2019-08-29 17:38:32 -03:00
builtin-buildid-cache.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-buildid-list.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-c2c.c
perf c2c: Fix return type for histogram sorting comparision functions
2020-02-05 21:22:40 +00:00
builtin-config.c
perf tools: Remove util.h from where it is not needed
2019-09-20 09:19:20 -03:00
builtin-data.c
perf debug: Remove needless include directives from debug.h
2019-08-31 19:10:19 -03:00
builtin-diff.c
perf diff: Use llabs() with 64-bit values
2020-01-04 19:18:26 +01:00
builtin-evlist.c
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
builtin-ftrace.c
perf ftrace: Fix access to pid in array when setting a pid filter
2021-05-07 10:51:37 +02:00
builtin-help.c
perf debug: Remove needless include directives from debug.h
2019-08-31 19:10:19 -03:00
builtin-inject.c
perf inject: Close inject.output on exit
2021-07-28 13:31:02 +02:00
builtin-kallsyms.c
perf dsos: Move the dsos struct and its methods to separate source files
2019-08-31 22:24:10 -03:00
builtin-kmem.c
perf kmem: Fix memory leak in compact_gfp_flags()
2019-10-16 10:08:32 -03:00
builtin-kvm.c
perf tools: Propagate get_cpuid() error
2019-09-30 17:29:54 -03:00
builtin-list.c
perf list: Allow plurals for metric, metricgroup
2019-09-25 09:51:42 -03:00
builtin-lock.c
perf lock: Don't free "lock_seq_stat" if read_count isn't zero
2020-11-24 13:29:05 +01:00
builtin-mem.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-probe.c
perf probe: Do not show the skipped events
2020-06-22 09:31:27 +02:00
builtin-record.c
perf record: Correct the help info of option "--no-bpf-event"
2020-09-09 19:12:36 +02:00
builtin-report.c
perf report: Fix memory leaks around perf_tip()
2021-12-08 09:01:10 +01:00
builtin-sched.c
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
builtin-script.c
perf script: Fix CPU filtering of a script's switch events
2022-01-05 12:37:46 +01:00
builtin-stat.c
perf stat: Skip duration_time in setup_system_wide
2020-10-29 09:57:50 +01:00
builtin-timechart.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-top.c
perf top: Fix stdio interface input handling with glibc 2.28+
2020-10-14 10:32:59 +02:00
builtin-trace.c
perf trace: Fix segfault when trying to trace events by cgroup
2020-11-18 19:20:18 +01:00
builtin-version.c
perf symbols: Move mem_info and branch_info out of symbol.h
2019-08-31 22:27:48 -03:00
builtin.h
perf tools: Remove needless util.h include from builtin.h
2019-08-28 17:19:34 -03:00
check-headers.sh
tools headers uapi: Sync linux/fs.h with the kernel sources
2019-09-30 17:29:22 -03:00
command-list.txt
…
CREDITS
…
design.txt
…
Makefile
tools: Let O= makes handle a relative path with -C option
2020-04-01 11:02:00 +02:00
Makefile.config
tools build: Remove needless libpython-version feature check that breaks test-all fast path
2021-12-14 14:49:03 +01:00
Makefile.perf
tools: Factor HOSTCC, HOSTLD, HOSTAR definitions
2021-01-30 13:54:10 +01:00
MANIFEST
…
perf-archive.sh
…
perf-completion.sh
…
perf-read-vdso.c
…
perf-sys.h
perf tools: Make usage of test_attr__* optional for perf-sys.h
2019-10-31 21:38:41 +01:00
perf-with-kcore.sh
…
perf.c
libperf: Merge libperf_set_print() into libperf_init()
2019-09-25 09:51:49 -03:00
perf.h
perf time-utils: Adopt rdclock() from perf.h
2019-08-29 17:38:32 -03:00