linux

iv/linux

History

Smith, Kyle Miller (Nimble Kernel) f767296626 nvme-pci: fix a NULL pointer dereference in nvme_alloc_admin_tags

[ Upstream commit da42761181627e9bdc37d18368b827948a583929 ]

In nvme_alloc_admin_tags, the admin_q can be set to an error (typically
-ENOMEM) if the blk_mq_init_queue call fails to set up the queue, which
is checked immediately after the call. However, when we return the error
message up the stack, to nvme_reset_work the error takes us to
nvme_remove_dead_ctrl()
  nvme_dev_disable()
   nvme_suspend_queue(&dev->queues[0]).

Here, we only check that the admin_q is non-NULL, rather than not
an error or NULL, and begin quiescing a queue that never existed, leading
to bad / NULL pointer dereference.

Signed-off-by: Kyle Smith <kyles@hpe.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2022-06-14 18:11:28 +02:00

core.c

nvme-multipath: fix hang when disk goes live over reconnect

2022-05-25 09:14:32 +02:00

fabrics.c

nvme-fabrics: decode host pathing error for connect

2021-06-16 11:59:36 +02:00

fabrics.h

nvme: Remove ADMIN_ONLY state

2019-10-14 23:21:44 +09:00

fault_inject.c

nvme: enable to inject errors into admin commands